All of lore.kernel.org
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: linux-block@vger.kernel.org, Omar Sandoval <osandov@fb.com>,
	Masato Suzuki <masato.suzuki@wdc.com>,
	Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Subject: Re: [PATCH blktests 0/5] Fix failures found with zoned block devices
Date: Wed, 20 Feb 2019 10:22:29 -0800	[thread overview]
Message-ID: <20190220182229.GC8325@vader> (raw)
In-Reply-To: <20190220081231.15366-1-shinichiro.kawasaki@wdc.com>

On Wed, Feb 20, 2019 at 05:12:26PM +0900, Shin'ichiro Kawasaki wrote:
> This patch series addresses two incorrect test failures found in the zbd test
> group. Two other problems with the check script and the common rc script are
> also fixed.
> 
> More specifically,
> * Patch 1 addresses an incorrect failure of block/024 caused by shorter write
>   I/O time than expected on very fast systems with a low overhead.
> * Patch 2 fixes test zbd/004 which can fail when a disk closes an implicitly
>   open zone after completion of a write command. To avoid this failure, the
>   closed zone condition is added as an allowed condition.
> * Patch 3 to 5 fix problems to access a block device sysfs attributes if the
>   target device is a partition.
> 
> Of note is that test block/004 still fails with a target device that is a
> partition of a zoned block device. The failure cause is due to an incorrect
> access to sysfs disk attributes by fio. A patch to fix this issue was sent to
> fio mailing list.

Thanks, I merged 1 and 2. I'm not necessarily opposed to the rest, but
I'm curious what your use case is for testing on partitions?

> Masato Suzuki (1):
>   block/024: Increase I/O time
> 
> Shin'ichiro Kawasaki (4):
>   zbd/004: Add zone condition "Closed" for sequential write required
>     zones
>   check: Add TEST_DEV_PART_SYSFS variable
>   common: Add _test_dev_is_partition() helper function
>   zbd: Change sysfs path for partition devices
> 
>  check           | 51 ++++++++++++++++++++++++++++++++-----------------
>  common/rc       |  8 ++++++++
>  new             | 16 ++++++++++++++--
>  tests/block/024 |  5 +++--
>  tests/zbd/004   |  9 ++++++++-
>  tests/zbd/rc    |  9 +++++++--
>  6 files changed, 74 insertions(+), 24 deletions(-)
> 
> -- 
> 2.20.1
> 

  parent reply	other threads:[~2019-02-20 18:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-20  8:12 [PATCH blktests 0/5] Fix failures found with zoned block devices Shin'ichiro Kawasaki
2019-02-20  8:12 ` [PATCH blktests 1/5] block/024: Increase I/O time Shin'ichiro Kawasaki
2019-02-20  8:12 ` [PATCH blktests 2/5] zbd/004: Add zone condition "Closed" for sequential write required zones Shin'ichiro Kawasaki
2019-02-20  8:12 ` [PATCH blktests 3/5] check: Add TEST_DEV_PART_SYSFS variable Shin'ichiro Kawasaki
2019-03-04 22:34   ` Omar Sandoval
2019-03-05  1:47     ` Shinichiro Kawasaki
2019-02-20  8:12 ` [PATCH blktests 4/5] common: Add _test_dev_is_partition() helper function Shin'ichiro Kawasaki
2019-03-04 22:36   ` Omar Sandoval
2019-02-20  8:12 ` [PATCH blktests 5/5] zbd: Change sysfs path for partition devices Shin'ichiro Kawasaki
2019-03-04 22:36   ` Omar Sandoval
2019-02-20 18:22 ` Omar Sandoval [this message]
2019-02-21  2:50   ` [PATCH blktests 0/5] Fix failures found with zoned block devices Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190220182229.GC8325@vader \
    --to=osandov@osandov.com \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=linux-block@vger.kernel.org \
    --cc=masato.suzuki@wdc.com \
    --cc=osandov@fb.com \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.