From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,1/2] nfit, mce: only handle uncorrectable machine checks From: Borislav Petkov Message-Id: <20190220191852.GF3447@zn.tnic> Date: Wed, 20 Feb 2019 20:18:52 +0100 To: Jeff Moyer Cc: Vishal Verma , linux-nvdimm@lists.01.org, Tony Luck , linux-edac@vger.kernel.org, Dan Williams List-ID: RHJvcCBzdGFibGVACgpPbiBXZWQsIEZlYiAyMCwgMjAxOSBhdCAwMTo1OToxNVBNIC0wNTAwLCBK ZWZmIE1veWVyIHdyb3RlOgo+IFNvcnJ5IGZvciBuZWNyb3Bvc3RpbmcuICBJIHRob3VnaHQgdGhl IHBvaW50IG9mIHRoZSBDRUMgd2FzIHRvIG1ha2Ugc3VyZQo+IHRoYXQgdGhlIG90aGVyIHJlZ2lz dGVyZWQgZGVjb2RlcnMgb25seSBldmVyIHNhdyB1bmNvcnJlY3RlZCBlcnJvcnMuCgpIYSwgZ29v ZCBwb2ludCEgWW91IG1lYW4gZHJpdmVycy9yYXMvY2VjLmMsIHJpZ2h0PwoKSWYgc28sIHRoZW4g SSBkb24ndCB0aGluayB3ZSd2ZSBldmVyIHRhbGtlZCBhYm91dCBjb25uZWN0aW5nIENFQyB3aXRo Ck5WRElNTSBhbmQgd2hldGhlciB0aGF0IHdvdWxkIG1ha2Ugc2Vuc2UuIExlbW1lIGFkZCBEYW4u Cgo+IEhvdyBkbyB3ZSBlbmQgdXAgZ2V0dGluZyBjYWxsZWQgd2l0aCBhIGNvcnJlY3RhYmxlIGVy cm9yPwoKR29vZCBxdWVzdGlvbi4gV2Ugc2hvdWxkbid0LgoKU28gd2UgbmVlZCB0byBmaWd1cmUg b3V0IGhlcmUgaG93IGV4YWN0bHkgc2hvdWxkIHRob3NlIHRoaW5ncyBpbnRlcmFjdAphbmQgd2hl dGhlciBORklUIHNob3VsZCBnZXQgYWxsIGVycm9ycyByZXBvcnRlZCBvciBpdCBzaG91bGQgcHV0 IGFsbCB0aGUKY29ycmVjdGFibGUgZXJyb3JzIHRocm91Z2ggdGhlIGRlY2F5IHRoaW5nLCBzZWUg dGhlIGNvbW1lbnQgYXQgdGhlIHRvcApvZiBkcml2ZXJzL3Jhcy9jZWMuYwoKVGh4IGZvciBwb2lu dGluZyB0aGF0IG91dCBKZWZmLgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B518221A07A92 for ; Wed, 20 Feb 2019 11:18:57 -0800 (PST) Date: Wed, 20 Feb 2019 20:18:52 +0100 From: Borislav Petkov Subject: Re: [PATCH v3 1/2] nfit, mce: only handle uncorrectable machine checks Message-ID: <20190220191852.GF3447@zn.tnic> References: <20181026003729.8420-1-vishal.l.verma@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Jeff Moyer Cc: Tony Luck , linux-edac@vger.kernel.org, linux-nvdimm@lists.01.org List-ID: Drop stable@ On Wed, Feb 20, 2019 at 01:59:15PM -0500, Jeff Moyer wrote: > Sorry for necroposting. I thought the point of the CEC was to make sure > that the other registered decoders only ever saw uncorrected errors. Ha, good point! You mean drivers/ras/cec.c, right? If so, then I don't think we've ever talked about connecting CEC with NVDIMM and whether that would make sense. Lemme add Dan. > How do we end up getting called with a correctable error? Good question. We shouldn't. So we need to figure out here how exactly should those things interact and whether NFIT should get all errors reported or it should put all the correctable errors through the decay thing, see the comment at the top of drivers/ras/cec.c Thx for pointing that out Jeff. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm