From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] habanalabs: add h/w queues module
Date: Wed, 20 Feb 2019 20:12:21 +0000 [thread overview]
Message-ID: <20190220201221.GA21409@kadam> (raw)
Hello Oded Gabbay,
The patch 9494a8dd8d22: "habanalabs: add h/w queues module" from Feb
16, 2019, leads to the following static checker warning:
drivers/misc/habanalabs/goya/goya.c:3386 goya_test_cpu_queue()
error: uninitialized symbol 'result'.
drivers/misc/habanalabs/goya/goya.c
3367 int goya_test_cpu_queue(struct hl_device *hdev)
3368 {
3369 struct armcp_packet test_pkt;
3370 long result;
3371 int rc;
3372
3373 /* cpu_queues_enable flag is always checked in send cpu message */
3374
3375 memset(&test_pkt, 0, sizeof(test_pkt));
3376
3377 test_pkt.ctl = ARMCP_PACKET_TEST << ARMCP_PKT_CTL_OPCODE_SHIFT;
3378 test_pkt.value = ARMCP_PACKET_FENCE_VAL;
3379
3380 rc = hdev->asic_funcs->send_cpu_message(hdev, (u32 *) &test_pkt,
3381 sizeof(test_pkt), HL_DEVICE_TIMEOUT_USEC, &result);
^^^^^^^
Presumably, result isn't set on all failure paths.
3382
3383 if (!rc)
3384 dev_info(hdev->dev, "queue test on CPU queue succeeded\n");
3385 else
--> 3386 dev_err(hdev->dev, "CPU queue test failed (0x%08lX)\n", result);
^^^^^^
3387
3388 return rc;
3389 }
regards,
dan carpenter
next reply other threads:[~2019-02-20 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 20:12 Dan Carpenter [this message]
2019-02-21 8:10 ` [bug report] habanalabs: add h/w queues module Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220201221.GA21409@kadam \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.