All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Glisse <jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: "Kuehling, Felix" <Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>
Cc: "Yang, Philip" <Philip.Yang-5C7GfCeVMHo@public.gmane.org>,
	"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu: select ARCH_HAS_HMM and ZONE_DEVICE option
Date: Wed, 20 Feb 2019 18:34:56 -0500	[thread overview]
Message-ID: <20190220233456.GB11325@redhat.com> (raw)
In-Reply-To: <d52f74c1-a9c2-d265-993d-dae3d367bf70-5C7GfCeVMHo@public.gmane.org>

On Wed, Feb 20, 2019 at 10:39:49PM +0000, Kuehling, Felix wrote:
> On 2019-02-20 5:12 p.m., Jerome Glisse wrote:
> > On Wed, Feb 20, 2019 at 07:18:17PM +0000, Kuehling, Felix wrote:
> >> [+Jerome]
> >>
> >> Why to we need ZONE_DEVICE. I didn't think this was needed for mirroring
> >> CPU page tables to device page tables.
> >>
> >> ARCH_HAS_HMM depends on (X86_64 || PPC64). Do we have some alternative
> >> for ARM support?
> >>
> >> Also, the name ARCH_HAS_HMM looks like it's meant to be selected by the
> >> CPU architecture rather than any driver. Jerome, do you have any advice?
> > This patch is wrong you need to depend on ARCH_HAS_HMM and
> 
> Who selects ARCH_HAS_HMM? Currently I don't see this selected anywhere. 
> So any config option that depends on it will be invisible in menuconfig. 
> Do we need ARCH_HAS_HMM somewhere in the arch/x86/Kconfig and 
> arch/powerpc/Kconfig?
> 
> Also, ARCH_HAS_HMM does not currently support ARM. Does that mean we 
> can't have ARM support in AMDGPU if we start using HMM?

ARCH_HAS_HMM is defined by architecture that support HMM. So par x86
and PPC. It should not be hard to add it to ARM (i can not remember if
ARM has DAX yet or not, if ARM does not have DAX then you need to add
that first).

> 
> Finally, ARCH_HAS_HMM has a bunch of dependencies. If they are not met, 
> I guess it can't be enabled. Should those be "select"s instead?

No they should not be selected, people configuring their system need
to have the freedom of doing so. All those option are selected in all
the big distribution.

> config ARCH_HAS_HMM
>          bool
>          default y
>          depends on (X86_64 || PPC64)
>          depends on ZONE_DEVICE
>          depends on MMU && 64BIT
>          depends on MEMORY_HOTPLUG
>          depends on MEMORY_HOTREMOVE
>          depends on SPARSEMEM_VMEMMAP
> 

Cheers,
Jérôme
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2019-02-20 23:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-20 18:56 [PATCH] drm/amdgpu: select ARCH_HAS_HMM and ZONE_DEVICE option Yang, Philip
     [not found] ` <20190220185544.19602-1-Philip.Yang-5C7GfCeVMHo@public.gmane.org>
2019-02-20 19:18   ` Kuehling, Felix
     [not found]     ` <1dfb54a4-67bf-2e96-40f4-7bfe24284232-5C7GfCeVMHo@public.gmane.org>
2019-02-20 22:12       ` Jerome Glisse
     [not found]         ` <20190220221243.GA29398-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-02-20 22:39           ` Kuehling, Felix
     [not found]             ` <d52f74c1-a9c2-d265-993d-dae3d367bf70-5C7GfCeVMHo@public.gmane.org>
2019-02-20 23:34               ` Jerome Glisse [this message]
     [not found]                 ` <20190220233456.GB11325-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-02-21  0:17                   ` Kuehling, Felix
     [not found]                     ` <3b6bcf86-c871-b23d-1da8-fe5b4d4ea081-5C7GfCeVMHo@public.gmane.org>
2019-02-21  0:25                       ` Jerome Glisse
     [not found]                         ` <20190221002542.GB24489-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-02-21 17:36                           ` Yang, Philip

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190220233456.GB11325@redhat.com \
    --to=jglisse-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=Felix.Kuehling-5C7GfCeVMHo@public.gmane.org \
    --cc=Philip.Yang-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.