All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, david.emett@broadcom.com,
	thomas.spurden@broadcom.com, Eric Anholt <eric@anholt.net>
Subject: [PATCH v3 3/3] drm/v3d: Make sure the GPU is on when measuring clocks.
Date: Wed, 20 Feb 2019 15:36:58 -0800	[thread overview]
Message-ID: <20190220233658.986-3-eric@anholt.net> (raw)
In-Reply-To: <20190220233658.986-1-eric@anholt.net>

You'll get garbage measurements if the registers always read back
0xdeadbeef

Signed-off-by: Eric Anholt <eric@anholt.net>
---
 drivers/gpu/drm/v3d/v3d_debugfs.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/v3d/v3d_debugfs.c b/drivers/gpu/drm/v3d/v3d_debugfs.c
index eb2b2d2f8553..a24af2d2f574 100644
--- a/drivers/gpu/drm/v3d/v3d_debugfs.c
+++ b/drivers/gpu/drm/v3d/v3d_debugfs.c
@@ -187,6 +187,11 @@ static int v3d_measure_clock(struct seq_file *m, void *unused)
 	uint32_t cycles;
 	int core = 0;
 	int measure_ms = 1000;
+	int ret;
+
+	ret = pm_runtime_get_sync(v3d->dev);
+	if (ret < 0)
+		return ret;
 
 	if (v3d->ver >= 40) {
 		V3D_CORE_WRITE(core, V3D_V4_PCTR_0_SRC_0_3,
@@ -210,6 +215,9 @@ static int v3d_measure_clock(struct seq_file *m, void *unused)
 		   cycles / (measure_ms * 1000),
 		   (cycles / (measure_ms * 100)) % 10);
 
+	pm_runtime_mark_last_busy(v3d->dev);
+	pm_runtime_put_autosuspend(v3d->dev);
+
 	return 0;
 }
 
-- 
2.20.1

  parent reply	other threads:[~2019-02-20 23:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-20 23:36 [PATCH v3 1/3] drm/v3d: Add support for V3D v4.2 Eric Anholt
2019-02-20 23:36 ` [PATCH v3 2/3] drm/v3d: Don't try to set OVRTMUOUT on V3D 4.x Eric Anholt
2019-03-08 16:45   ` Dave Emett
2019-02-20 23:36 ` Eric Anholt [this message]
2019-03-08 16:47   ` [PATCH v3 3/3] drm/v3d: Make sure the GPU is on when measuring clocks Dave Emett
2019-03-08 16:22 ` [PATCH v3 1/3] drm/v3d: Add support for V3D v4.2 Dave Emett
2019-03-08 16:38 ` Dave Emett
2019-03-08 16:51   ` Eric Anholt
2019-03-08 17:47     ` Eric Anholt
2019-03-08 17:47       ` Eric Anholt
2019-03-08 18:10     ` Dave Emett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190220233658.986-3-eric@anholt.net \
    --to=eric@anholt.net \
    --cc=david.emett@broadcom.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas.spurden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.