Re: [PATCH v2 2/2] Staging: rtl8192e: Avoid using bool structure members

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Thu, Feb 21, 2019 at 01:17:29PM +0530, Bhanusree Pola wrote:
> -Use 'u8' with bitfield instead of 'bool' to preserve space.
> -Also bool size can be 1 or sizeof(int) depending on the macro
>  definition given to bool
> -inorder to avoid alignment issues the u8 bitfield is placed as last
>  member of the structure.
> -removes checkpatch.pl check:
>  CHECK: Avoid using bool structure members because of possible alignment
>  issues
> 
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
>  drivers/staging/rtl8192e/dot11d.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/dot11d.h b/drivers/staging/rtl8192e/dot11d.h
> index 6d2b93acfa43..a1d879d316ed 100644
> --- a/drivers/staging/rtl8192e/dot11d.h
> +++ b/drivers/staging/rtl8192e/dot11d.h
> @@ -33,8 +33,6 @@ enum dot11d_state {
>   */
>  
>  struct rt_dot11d_info {
> -	bool enabled;
> -
>  	u16 country_len;
>  	u8  country_buffer[MAX_IE_LEN];
>  	u8  country_src_addr[6];
> @@ -44,6 +42,7 @@ struct rt_dot11d_info {
>  	u8  max_tx_power_list[MAX_CHANNEL_NUMBER + 1];
>  
>  	enum dot11d_state state;
> +	u8 enabled:1;

Again, no, this is not ok at all.  I thought I said so the last time you
sent this patch.  checkpatch.pl is a "hint", you do not always have to
follow everything it says to do.

thanks,

greg k-h