From: Greg KH <gregkh@linuxfoundation.org>
To: Yue Hu <zbestahu@gmail.com>
Cc: Michal Hocko <mhocko@kernel.org>,
akpm@linux-foundation.org, rientjes@google.com, joe@perches.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
huyue2@yulong.com
Subject: Re: [PATCH] mm/cma_debug: Check for null tmp in cma_debugfs_add_one()
Date: Thu, 21 Feb 2019 10:10:10 +0100 [thread overview]
Message-ID: <20190221091010.GA11118@kroah.com> (raw)
In-Reply-To: <20190221165642.00005d86.zbestahu@gmail.com>
On Thu, Feb 21, 2019 at 04:56:42PM +0800, Yue Hu wrote:
> On Thu, 21 Feb 2019 09:23:09 +0100
> Michal Hocko <mhocko@kernel.org> wrote:
>
> > On Thu 21-02-19 12:01:30, Yue Hu wrote:
> > > From: Yue Hu <huyue2@yulong.com>
> > >
> > > If debugfs_create_dir() failed, the following debugfs_create_file()
> > > will be meanless since it depends on non-NULL tmp dentry and it will
> > > only waste CPU resource.
> >
> > The file will be created in the debugfs root. But, more importantly.
> > Greg (CCed now) is working on removing the failure paths because he
> > believes they do not really matter for debugfs and they make code more
> > ugly. More importantly a check for NULL is not correct because you
> > get ERR_PTR after recent changes IIRC.
>
> Same check logic in cma_debugfs_init(), i'm just finding they do not stay
> the same.
I have patches to fix that up as well :)
thanks,
greg k-h
prev parent reply other threads:[~2019-02-21 9:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 4:01 [PATCH] mm/cma_debug: Avoid to use global cma_debugfs_root Yue Hu
2019-02-21 4:01 ` [PATCH] mm/cma_debug: Check for null tmp in cma_debugfs_add_one() Yue Hu
2019-02-21 8:23 ` Michal Hocko
2019-02-21 8:36 ` Greg KH
2019-02-21 8:45 ` Michal Hocko
2019-02-21 9:10 ` Greg KH
2019-02-21 8:56 ` Yue Hu
2019-02-21 9:10 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221091010.GA11118@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=huyue2@yulong.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.