From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/7] drm: Add a helper function for printing a debugfs_regset32. Date: Thu, 21 Feb 2019 10:37:57 +0100 Message-ID: <20190221093757.GL2665@phenom.ffwll.local> References: <20190220210343.28157-1-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id ADD3E893DB for ; Thu, 21 Feb 2019 09:38:01 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id c55so4765056edb.0 for ; Thu, 21 Feb 2019 01:38:01 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190220210343.28157-1-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: Paul Kocialkowski , Maxime Ripard , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBGZWIgMjAsIDIwMTkgYXQgMDE6MDM6MzdQTSAtMDgwMCwgRXJpYyBBbmhvbHQgd3Jv dGU6Cj4gVGhlIGRlYnVnZnNfcmVnc2V0MzIgaXMgbmljZSB0byB1c2UgZm9yIHJlZHVjaW5nIGJv aWxlcnBsYXRlIGluCj4gZHVtcGluZyBhIGJ1bmNoIG9mIHJlZ3MgaW4gZGVidWdmcywgYnV0IHdl IGFsc28gd2FudCB0byBiZSBhYmxlIHRvCj4gcHJpbnQgdG8gZG1lc2cgdGhlbSBhdCBydW50aW1l IGZvciBkcml2ZXIgZGVidWdnaW5nLiAgZHJtX3ByaW50ZXIgbGV0cwo+IHVzIGZvcm1hdCBkZWJ1 Z2ZzIGFuZCB0aGUgcHJpbnRrIHRoZSBzYW1lIHdheS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBFcmlj IEFuaG9sdCA8ZXJpY0BhbmhvbHQubmV0Pgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX3By aW50LmMgfCAxNiArKysrKysrKysrKysrKysrCj4gIGluY2x1ZGUvZHJtL2RybV9wcmludC5oICAg ICB8ICAyICsrCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW50LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X3ByaW50LmMKPiBpbmRleCAwZTdmYzNlN2RmYjQuLjVlY2MwZjA0Y2QwYyAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW50LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X3ByaW50LmMKPiBAQCAtMjUzLDMgKzI1MywxOSBAQCB2b2lkIGRybV9lcnIoY29uc3QgY2hhciAq Zm9ybWF0LCAuLi4pCj4gIAl2YV9lbmQoYXJncyk7Cj4gIH0KPiAgRVhQT1JUX1NZTUJPTChkcm1f ZXJyKTsKPiArCgpBIGJpdCBvZiBrZXJuZWxkb2Mgd291bGQgYmUgbmljZS4gV2l0aCB0aGF0OgoK UmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cgo+ICt2 b2lkIGRybV9wcmludF9yZWdzZXQzMihzdHJ1Y3QgZHJtX3ByaW50ZXIgKnAsIHN0cnVjdCBkZWJ1 Z2ZzX3JlZ3NldDMyICpyZWdzZXQpCj4gK3sKPiArCWludCBuYW1lbGVuID0gMDsKPiArCWludCBp Owo+ICsKPiArCWZvciAoaSA9IDA7IGkgPCByZWdzZXQtPm5yZWdzOyBpKyspCj4gKwkJbmFtZWxl biA9IG1heChuYW1lbGVuLCAoaW50KXN0cmxlbihyZWdzZXQtPnJlZ3NbaV0ubmFtZSkpOwo+ICsK PiArCWZvciAoaSA9IDA7IGkgPCByZWdzZXQtPm5yZWdzOyBpKyspIHsKPiArCQlkcm1fcHJpbnRm KHAsICIlKnMgPSAweCUwOHhcbiIsCj4gKwkJCSAgIG5hbWVsZW4sIHJlZ3NldC0+cmVnc1tpXS5u YW1lLAo+ICsJCQkgICByZWFkbChyZWdzZXQtPmJhc2UgKyByZWdzZXQtPnJlZ3NbaV0ub2Zmc2V0 KSk7Cj4gKwl9Cj4gK30KPiArRVhQT1JUX1NZTUJPTChkcm1fcHJpbnRfcmVnc2V0MzIpOwo+IGRp ZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fcHJpbnQuaCBiL2luY2x1ZGUvZHJtL2RybV9wcmlu dC5oCj4gaW5kZXggYWZiYzNiZWVmMDg5Li4zYTQyNDczMTllNjMgMTAwNjQ0Cj4gLS0tIGEvaW5j bHVkZS9kcm0vZHJtX3ByaW50LmgKPiArKysgYi9pbmNsdWRlL2RybS9kcm1fcHJpbnQuaAo+IEBA IC0zMCw2ICszMCw3IEBACj4gICNpbmNsdWRlIDxsaW51eC9wcmludGsuaD4KPiAgI2luY2x1ZGUg PGxpbnV4L3NlcV9maWxlLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9kZXZpY2UuaD4KPiArI2luY2x1 ZGUgPGxpbnV4L2RlYnVnZnMuaD4KPiAgCj4gIC8qKgo+ICAgKiBET0M6IHByaW50Cj4gQEAgLTg0 LDYgKzg1LDcgQEAgdm9pZCBfX2RybV9wcmludGZuX2RlYnVnKHN0cnVjdCBkcm1fcHJpbnRlciAq cCwgc3RydWN0IHZhX2Zvcm1hdCAqdmFmKTsKPiAgX19wcmludGYoMiwgMykKPiAgdm9pZCBkcm1f cHJpbnRmKHN0cnVjdCBkcm1fcHJpbnRlciAqcCwgY29uc3QgY2hhciAqZiwgLi4uKTsKPiAgdm9p ZCBkcm1fcHV0cyhzdHJ1Y3QgZHJtX3ByaW50ZXIgKnAsIGNvbnN0IGNoYXIgKnN0cik7Cj4gK3Zv aWQgZHJtX3ByaW50X3JlZ3NldDMyKHN0cnVjdCBkcm1fcHJpbnRlciAqcCwgc3RydWN0IGRlYnVn ZnNfcmVnc2V0MzIgKnJlZ3NldCk7Cj4gIAo+ICBfX3ByaW50ZigyLCAwKQo+ICAvKioKPiAtLSAK PiAyLjIwLjEKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jw b3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EC58C43381 for ; Thu, 21 Feb 2019 09:38:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B8A8214AF for ; Thu, 21 Feb 2019 09:38:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="HU8MCviB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726389AbfBUJiC (ORCPT ); Thu, 21 Feb 2019 04:38:02 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:47102 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725850AbfBUJiC (ORCPT ); Thu, 21 Feb 2019 04:38:02 -0500 Received: by mail-ed1-f66.google.com with SMTP id f2so22463205edy.13 for ; Thu, 21 Feb 2019 01:38:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=ReoiAJmgj456nojJUZ4xuw/Jy7Hmc2sVoEkMfntNpfQ=; b=HU8MCviBRTmSHR28WV6DPjfsjV1aVpC5d+3udPvhLLKMqzYPqe+CQcmgoGcsa6GEiA 4mOeIDoo93UCRlQ9Gj/pXX1oGcML3bQfGmwIwZWv8nyd9+ptqtzsAKzdqHY61lkDo/Y0 q2AatprA3Arg28+nGybWnvjAL6+kL3ixauHx8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=ReoiAJmgj456nojJUZ4xuw/Jy7Hmc2sVoEkMfntNpfQ=; b=nRO3v3VlUvNDgXy9j4UfN6BlkQfSyDxFfS4yyzkeuIs0vFSNmDHcfqFua4VZEc0RGu SJSJuJRy0y/Ubg3DJ4os1w7QKub3WYqXFBB3igvQiPdjIprQNl9scq6a8koogv01QuYR E+M4oWeX1lu+6mwDaOgloBZlxaetc0rU8K7Xpir8hAaBXPwK2WiX8Z4fI4gruXVUKWgJ TJkZ5dEV0h/ZBOGiis/fZ3wkpMNtiTeHkjoByWYu7HJHji/cWt4b0c3HqvOJXRnYa+jS fZUZgyPFUXMBX3Baz/VH6P7geuOBiDNTeIAMEsViJD45ItyONJGzcRuY1o6uHKAIeQd1 6F8g== X-Gm-Message-State: AHQUAuY6946fHQtUXSgS5SzJ8roiXyr7t3aHhDRzZjOIGlVLLViaUV/D Dqb6XNX37jaXzMbJD7hNLZ8+qA== X-Google-Smtp-Source: AHgI3IahAb+LbY5r6pGAfD0r4ybBd03aj5GT/cGOShodANkzYEcbqb6NttQE5UaAYj60KpnH6CT7OA== X-Received: by 2002:a50:9938:: with SMTP id k53mr25676145edb.134.1550741880302; Thu, 21 Feb 2019 01:38:00 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id k15sm2893697eda.22.2019.02.21.01.37.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Feb 2019 01:37:59 -0800 (PST) Date: Thu, 21 Feb 2019 10:37:57 +0100 From: Daniel Vetter To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, Paul Kocialkowski , Maxime Ripard , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] drm: Add a helper function for printing a debugfs_regset32. Message-ID: <20190221093757.GL2665@phenom.ffwll.local> Mail-Followup-To: Eric Anholt , dri-devel@lists.freedesktop.org, Paul Kocialkowski , Maxime Ripard , linux-kernel@vger.kernel.org References: <20190220210343.28157-1-eric@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190220210343.28157-1-eric@anholt.net> X-Operating-System: Linux phenom 4.19.0-1-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 20, 2019 at 01:03:37PM -0800, Eric Anholt wrote: > The debugfs_regset32 is nice to use for reducing boilerplate in > dumping a bunch of regs in debugfs, but we also want to be able to > print to dmesg them at runtime for driver debugging. drm_printer lets > us format debugfs and the printk the same way. > > Signed-off-by: Eric Anholt > --- > drivers/gpu/drm/drm_print.c | 16 ++++++++++++++++ > include/drm/drm_print.h | 2 ++ > 2 files changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c > index 0e7fc3e7dfb4..5ecc0f04cd0c 100644 > --- a/drivers/gpu/drm/drm_print.c > +++ b/drivers/gpu/drm/drm_print.c > @@ -253,3 +253,19 @@ void drm_err(const char *format, ...) > va_end(args); > } > EXPORT_SYMBOL(drm_err); > + A bit of kerneldoc would be nice. With that: Reviewed-by: Daniel Vetter > +void drm_print_regset32(struct drm_printer *p, struct debugfs_regset32 *regset) > +{ > + int namelen = 0; > + int i; > + > + for (i = 0; i < regset->nregs; i++) > + namelen = max(namelen, (int)strlen(regset->regs[i].name)); > + > + for (i = 0; i < regset->nregs; i++) { > + drm_printf(p, "%*s = 0x%08x\n", > + namelen, regset->regs[i].name, > + readl(regset->base + regset->regs[i].offset)); > + } > +} > +EXPORT_SYMBOL(drm_print_regset32); > diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h > index afbc3beef089..3a4247319e63 100644 > --- a/include/drm/drm_print.h > +++ b/include/drm/drm_print.h > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include > > /** > * DOC: print > @@ -84,6 +85,7 @@ void __drm_printfn_debug(struct drm_printer *p, struct va_format *vaf); > __printf(2, 3) > void drm_printf(struct drm_printer *p, const char *f, ...); > void drm_puts(struct drm_printer *p, const char *str); > +void drm_print_regset32(struct drm_printer *p, struct debugfs_regset32 *regset); > > __printf(2, 0) > /** > -- > 2.20.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch