[1/4] usb: xhci: fix build warning - missing prototype

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Thu, Feb 21, 2019 at 10:39:46AM +0100, Jean-Philippe Menil wrote:
> On Thu, 21 Feb 2019, Greg KH wrote:
> 
> > On Wed, Feb 20, 2019 at 09:54:12PM +0100, Jean-Philippe Menil wrote:
> > > On Wed, 20 Feb 2019, Greg KH wrote:
> > > 
> > > > On Wed, Feb 20, 2019 at 07:50:52PM +0200, Mathias Nyman wrote:
> > > > > From: Jean-Philippe Menil <jpmenil@gmail.com>
> > > > > 
> > > > > Fix build warning when building drivers/usb/host/xhci-mem.o due to missing
> > > > > prototype for xhci_free_virt_devices_depth_first.
> > > > 
> > > > There is no normal "build warning", this is a sparse fixup, right?
> > > > 
> > > > 
> > > 
> > > Hi Greg,
> > > 
> > > this is a build warning, at least with W=1 :
> > > 
> > > drivers/usb/host/xhci-mem.c:936:6: warning: no previous prototype for 
> > > ‘xhci_free_virt_devices_depth_first’ [-Wmissing-prototypes]
> > >  void xhci_free_virt_devices_depth_first(struct xhci_hcd *xhci, int 
> > > slot_id)
> > 
> > "W=1" is not a normal build option for anyone to use, except those that
> > wish to find crazy issues like this :)
> > 
> > Also, if that is the only way it shows up, you should mention it in the
> > changelog.
> > 
> > thanks,
> > 
> > greg k-h
> > 
> 
> Hmm, rereaind this mail from kernel-janitors
> https://marc.info/?l=kernel-janitors&m=154178546220848&w=2
> seem that you're right, this is not a normal option :)
> 
> Mathias, do you want me to re-send something?

No need, I'll go edit the changelog text...

greg k-h