All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bhanusree Pola <bhanusreemahesh@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 1/4] staging: netlogic: Add SPDX license Identifier
Date: Thu, 21 Feb 2019 12:24:55 +0100	[thread overview]
Message-ID: <20190221112455.GB17199@kroah.com> (raw)
In-Reply-To: <20190221111627.GA29041@bhanusree-MacBookAir>

On Thu, Feb 21, 2019 at 04:46:27PM +0530, Bhanusree Pola wrote:
> adds the SPDX GPL-2.0 license identifier which solves the checkpatch.pl warning
> Issue found with checkpatch.pl warning:
> "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"
> 
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
>  drivers/staging/netlogic/xlr_net.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/netlogic/xlr_net.h b/drivers/staging/netlogic/xlr_net.h
> index f76e16cfd15d..de51d64c1f23 100644
> --- a/drivers/staging/netlogic/xlr_net.h
> +++ b/drivers/staging/netlogic/xlr_net.h
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

Wait, no, that is NOT the proper license for this file.  The text below
your added line spells that out in detail.

Never mess with licensing information unless you _REALLY_ know what you
are doing, as doing it wrong (like this), is much more dangerous than
leaving it alone.

So all of these are not correct at all, please be more careful.

thanks,

greg k-h


  reply	other threads:[~2019-02-21 11:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21 11:16 [PATCH 1/4] staging: netlogic: Add SPDX license Identifier Bhanusree Pola
2019-02-21 11:24 ` Greg Kroah-Hartman [this message]
2019-02-21 11:32   ` [Outreachy kernel] " Greg Kroah-Hartman
2019-02-21 11:39     ` Bhanusree Mahesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190221112455.GB17199@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bhanusreemahesh@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.