From: Christoph Hellwig <hch@lst.de>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] MIPS: BCM63XX: provide DMA masks for ethernet devices
Date: Thu, 21 Feb 2019 14:40:24 +0100 [thread overview]
Message-ID: <20190221134024.GA20320@lst.de> (raw)
In-Reply-To: <20190221095642.26962-1-jonas.gorski@gmail.com>
On Thu, Feb 21, 2019 at 10:56:42AM +0100, Jonas Gorski wrote:
> The switch to the generic dma ops made dma masks mandatory, breaking
> devices having them not set. In case of bcm63xx, it broke ethernet with
> the following warning when trying to up the device:
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-02-21 13:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 9:56 [PATCH] MIPS: BCM63XX: provide DMA masks for ethernet devices Jonas Gorski
2019-02-21 13:40 ` Christoph Hellwig [this message]
2019-02-21 17:47 ` Florian Fainelli
2019-02-21 23:07 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221134024.GA20320@lst.de \
--to=hch@lst.de \
--cc=f.fainelli@gmail.com \
--cc=jhogan@kernel.org \
--cc=jonas.gorski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.