From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/hdcp: Silence compiler critics
Date: Thu, 21 Feb 2019 15:52:07 +0200 [thread overview]
Message-ID: <20190221135207.GJ20097@intel.com> (raw)
In-Reply-To: <20190221084833.19489-1-chris@chris-wilson.co.uk>
On Thu, Feb 21, 2019 at 08:48:33AM +0000, Chris Wilson wrote:
> drivers/gpu/drm/i915/intel_hdcp.c:92 intel_hdcp2_capable() warn: inconsistent indenting
> drivers/gpu/drm/i915/intel_hdcp.c:786:5: error: no previous prototype for ‘intel_hdcp_check_link’
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/intel_hdcp.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
> index 6178fe93f398..9ce09f67776d 100644
> --- a/drivers/gpu/drm/i915/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/intel_hdcp.c
> @@ -89,10 +89,10 @@ static bool intel_hdcp2_capable(struct intel_connector *connector)
>
> /* MEI interface is solid */
> mutex_lock(&dev_priv->hdcp_comp_mutex);
> - if (!dev_priv->hdcp_comp_added || !dev_priv->hdcp_master) {
> - mutex_unlock(&dev_priv->hdcp_comp_mutex);
> - return false;
> - }
> + if (!dev_priv->hdcp_comp_added || !dev_priv->hdcp_master) {
^^
That too looks a bit funky.
> + mutex_unlock(&dev_priv->hdcp_comp_mutex);
> + return false;
> + }
> mutex_unlock(&dev_priv->hdcp_comp_mutex);
>
> /* Sink's capability for HDCP2.2 */
> @@ -783,7 +783,7 @@ struct intel_connector *intel_hdcp_to_connector(struct intel_hdcp *hdcp)
> }
>
> /* Implements Part 3 of the HDCP authorization procedure */
> -int intel_hdcp_check_link(struct intel_connector *connector)
> +static int intel_hdcp_check_link(struct intel_connector *connector)
> {
> struct intel_hdcp *hdcp = &connector->hdcp;
> struct drm_i915_private *dev_priv = connector->base.dev->dev_private;
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-02-21 13:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 8:48 [PATCH] drm/i915/hdcp: Silence compiler critics Chris Wilson
2019-02-21 9:02 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-02-21 9:10 ` [PATCH] " Mika Kuoppala
2019-02-21 10:02 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-02-21 13:52 ` Ville Syrjälä [this message]
2019-02-21 14:04 ` [PATCH] " Chris Wilson
2019-02-21 14:59 ` ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221135207.GJ20097@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.