From: Wei Yang <richardw.yang@linux.intel.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Wei Yang" <richardw.yang@linux.intel.com>,
qemu-devel@nongnu.org, xiaoguangrong.eric@gmail.com,
mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] pc-dimm: remove realize callback
Date: Fri, 22 Feb 2019 16:17:13 +0800 [thread overview]
Message-ID: <20190222081713.GA4743@richard> (raw)
In-Reply-To: <20190221153753.48b40fd0@redhat.com>
On Thu, Feb 21, 2019 at 03:37:53PM +0100, Igor Mammedov wrote:
>On Tue, 19 Feb 2019 13:36:57 +0100
>Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
>> On 2/19/19 7:07 AM, Wei Yang wrote:
>> > PCDIMM's realize callback is introduced to do proper setup for NVDIMM.
>> >
>> > Currently the NVDIMM setup task is nvdimm_prepare_memory_region(), which
>> > is done in pre_plug stage. This means related task has already been done
>> > at realize point.
>> >
>> > This patch remove PCDIMM realize callback.
>
>pre_plug is machine helper and that it calls nvdimm_prepare_memory_region()
>indirectly is just of side effect of current nvdimm impl. Another machine
>might choose to implement it's own pre_plug to use with nvdimms, in which
>case it might not call the function before realize, hence this patch makes
>nvdimm device model incomplete and less robust.
Sounds reasonable.
Call nvdimm_prepare_memory_region() two times is really ugly. Hmm... could we
improve this?
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2019-02-22 8:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 6:07 [Qemu-devel] [PATCH 0/2] PCDIMM cleanup Wei Yang
2019-02-19 6:07 ` [Qemu-devel] [PATCH 1/2] pc-dimm: remove check on pc-dimm hotpluggable Wei Yang
2019-02-19 12:26 ` Philippe Mathieu-Daudé
2019-02-21 14:30 ` Igor Mammedov
2019-02-19 12:29 ` Philippe Mathieu-Daudé
2019-02-19 13:02 ` Wei Yang
2019-02-19 6:07 ` [Qemu-devel] [PATCH 2/2] pc-dimm: remove realize callback Wei Yang
2019-02-19 12:36 ` Philippe Mathieu-Daudé
2019-02-19 13:05 ` Wei Yang
2019-02-21 14:37 ` Igor Mammedov
2019-02-22 8:17 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222081713.GA4743@richard \
--to=richardw.yang@linux.intel.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.