From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] net: dsa: Inherit dev addr from master
Date: Fri, 22 Feb 2019 15:30:03 +0100
Message-ID: <20190222143003.GL5653@lunn.ch>
References: <20190222125654.12478-1-vkoul@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <netdev-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20190222125654.12478-1-vkoul@kernel.org>
Sender: netdev-owner@vger.kernel.org
To: Vinod Koul <vkoul@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>, linux-arm-msm@vger.kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>, Xiaofei Shen <xiaofeis@codeaurora.org>, Vivien Didelot <vivien.didelot@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, Niklas Cassel <niklas.cassel@linaro.org>, netdev@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org

On Fri, Feb 22, 2019 at 06:26:54PM +0530, Vinod Koul wrote:
> From: Xiaofei Shen <xiaofeis@codeaurora.org>
> 
> When we create slave netdevice, the dev addr is inherited from master
> but the master dev addr maybe NULL at that time, so inherit it again
> while opening the slave.

Hi Xiaofei, Vinod

Inheriting it twice seems a bit clumsy. Can the first inherit be
removed? Can you change your MAC driver to set its MAC address in
probe?

	Andrew