Re: [PATCH net 1/2] selftests: pmtu: disable dad in all namespaces

[Stefano Brivio <sbrivio@redhat.com>]

On Fri, 22 Feb 2019 17:06:32 +0100
Paolo Abeni <pabeni@redhat.com> wrote:

> Otherwise, the configured IPv6 address could be still "tentative"
> at test time, possibly causing tests failures.
> We can also drop some sleep along the code and decrease the
> timeout for most commands so that the test runtime decreases.

Thanks for fixing this!

I tried this back then and it didn't work, perhaps some DAD changes
intervened meanwhile (or I simply tried it wrong).

Just one comment:

> Fixes: d1f1b9cbf34c ("selftests: net: Introduce first PMTU test")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
>  tools/testing/selftests/net/pmtu.sh | 28 +++++++++++++---------------
>  1 file changed, 13 insertions(+), 15 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh
> index e2c94e47707c..634e91e8fe25 100755
> --- a/tools/testing/selftests/net/pmtu.sh
> +++ b/tools/testing/selftests/net/pmtu.sh
> @@ -263,8 +263,6 @@ setup_fou_or_gue() {
>  
>  	${ns_a} ip link set ${encap}_a up
>  	${ns_b} ip link set ${encap}_b up
> -
> -	sleep 1
>  }
>  
>  setup_fou44() {
> @@ -302,6 +300,10 @@ setup_gue66() {
>  setup_namespaces() {
>  	for n in ${NS_A} ${NS_B} ${NS_R1} ${NS_R2}; do
>  		ip netns add ${n} || return 1
> +
> +		# disable dad, so that we don't have to wait to use the
> +		# configured IPv6 addresses

For consistency: "Disable DAD ..."

-- 
Stefano