Re: [rocko/master][PATCH] gcc-arm-none-eabi: extend to nativesdk class

[Denys Dmytriyenko <denys@ti.com>]

On Fri, Feb 22, 2019 at 12:12:44PM -0500, Jacob Stiffler wrote:
> 
> On 2/21/2019 9:29 PM, Denys Dmytriyenko wrote:
> >On Wed, Feb 20, 2019 at 09:12:06AM -0500, Jacob Stiffler wrote:
> >>Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> >>---
> >>  ...1-update.bb => gcc-arm-none-eabi_6-2017-q1-update.bb} | 16 ++++++++++++++--
> >>  1 file changed, 14 insertions(+), 2 deletions(-)
> >>  rename recipes-ti/devtools/{gcc-arm-none-eabi-native_6-2017-q1-update.bb => gcc-arm-none-eabi_6-2017-q1-update.bb} (67%)
> >>
> >>diff --git a/recipes-ti/devtools/gcc-arm-none-eabi-native_6-2017-q1-update.bb b/recipes-ti/devtools/gcc-arm-none-eabi_6-2017-q1-update.bb
> >>similarity index 67%
> >>rename from recipes-ti/devtools/gcc-arm-none-eabi-native_6-2017-q1-update.bb
> >>rename to recipes-ti/devtools/gcc-arm-none-eabi_6-2017-q1-update.bb
> >>index 1140f27..c10ee16 100644
> >>--- a/recipes-ti/devtools/gcc-arm-none-eabi-native_6-2017-q1-update.bb
> >>+++ b/recipes-ti/devtools/gcc-arm-none-eabi_6-2017-q1-update.bb
> >>@@ -3,7 +3,6 @@ LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
> >>  LIC_FILES_CHKSUM = "file://share/doc/gcc-arm-none-eabi/license.txt;md5=c224e429f53a1a6ce70bf8986ea2990b"
> >>-inherit native
> >>  require recipes-ti/includes/ti-paths.inc
> >>  SRC_URI = "https://developer.arm.com/-/media/Files/downloads/gnu-rm/6_1-2017q1/gcc-arm-none-eabi-6-2017-q1-update-linux.tar.bz2;name=gcc-arm-none"
> >>@@ -13,6 +12,17 @@ SRC_URI[gcc-arm-none.sha256sum] = "e7aad2579f02e3b095c6d7899ca5e6a70cfa9b8a8cbd6
> >>  S = "${WORKDIR}/gcc-arm-none-eabi-6-2017-q1-update"
> >>+# only x86_64 is supported
> >>+python __anonymous() {
> >>+    host_arch = d.getVar("HOST_ARCH")
> >>+
> >>+    if host_arch != "x86_64":
> >>+        pkgn = d.getVar("PN")
> >>+        pkgv = d.getVar("PV")
> >>+
> >>+        raise bb.parse.SkipPackage("%s-%s ONLY supported for x86_64 target" % (pkgn, pkgv))
> >>+}
> >>+
> >I've been thinking about this one.
> >Would it be better to have a common .inc file and 2 one-line native and
> >nativesdk recipes that include that .inc file, and avoid __anonymous()
> >function altogether?
> >
> 
> Would COMPATIBLE_HOST be more appropriate here? It appears that it will have
> the same effect as this anonymous function.

Fine with me, thanks.


> >>  do_install() {
> >>      install -d ${D}${GCC_ARM_NONE_TOOLCHAIN_RECIPE}
> >>      cp -r ${S}/. ${D}${GCC_ARM_NONE_TOOLCHAIN_RECIPE}
> >>@@ -20,4 +30,6 @@ do_install() {
> >>  FILES_${PN} = "${GCC_ARM_NONE_TOOLCHAIN_RECIPE}/*"
> >>-INSANE_SKIP_${PN} = "already-stripped"
> >>+INSANE_SKIP_${PN} = "already-stripped libdir staticdev"
> >>+
> >>+BBCLASSEXTEND = "native nativesdk"
> >>-- 
> >>2.7.4
> >>
> >>-- 
> >>_______________________________________________
> >>meta-ti mailing list
> >>meta-ti@yoctoproject.org
> >>https://lists.yoctoproject.org/listinfo/meta-ti