From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH v2] drm/i915: Sort newer to older platforms.
Date: Fri, 22 Feb 2019 13:25:33 -0800 [thread overview]
Message-ID: <20190222212533.GG2855@intel.com> (raw)
In-Reply-To: <20190221214858.GQ20097@intel.com>
On Thu, Feb 21, 2019 at 11:48:58PM +0200, Ville Syrjälä wrote:
> On Thu, Feb 21, 2019 at 01:44:30PM -0800, Rodrigo Vivi wrote:
> > No functional change. Just a reorg to match the preferred
> > behavior.
> >
> > v2: missing else (Ville)
> >
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Looks correct enough.
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
pushed to dinq, thanks for the reviews
>
> > ---
> > drivers/gpu/drm/i915/intel_hdmi.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> > index ad81691fa7bf..6bd724c7a6de 100644
> > --- a/drivers/gpu/drm/i915/intel_hdmi.c
> > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> > @@ -2575,14 +2575,14 @@ static u8 intel_hdmi_ddc_pin(struct drm_i915_private *dev_priv,
> > return info->alternate_ddc_pin;
> > }
> >
> > - if (IS_CHERRYVIEW(dev_priv))
> > - ddc_pin = chv_port_to_ddc_pin(dev_priv, port);
> > - else if (IS_GEN9_LP(dev_priv))
> > - ddc_pin = bxt_port_to_ddc_pin(dev_priv, port);
> > + if (HAS_PCH_ICP(dev_priv))
> > + ddc_pin = icl_port_to_ddc_pin(dev_priv, port);
> > else if (HAS_PCH_CNP(dev_priv))
> > ddc_pin = cnp_port_to_ddc_pin(dev_priv, port);
> > - else if (HAS_PCH_ICP(dev_priv))
> > - ddc_pin = icl_port_to_ddc_pin(dev_priv, port);
> > + else if (IS_GEN9_LP(dev_priv))
> > + ddc_pin = bxt_port_to_ddc_pin(dev_priv, port);
> > + else if (IS_CHERRYVIEW(dev_priv))
> > + ddc_pin = chv_port_to_ddc_pin(dev_priv, port);
> > else
> > ddc_pin = g4x_port_to_ddc_pin(dev_priv, port);
> >
> > --
> > 2.20.1
>
> --
> Ville Syrjälä
> Intel
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-02-22 21:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 21:33 [PATCH] drm/i915: Sort newer to older platforms Rodrigo Vivi
2019-02-21 21:39 ` Ville Syrjälä
2019-02-21 21:44 ` [PATCH v2] " Rodrigo Vivi
2019-02-21 21:48 ` Ville Syrjälä
2019-02-22 21:25 ` Rodrigo Vivi [this message]
2019-02-21 23:13 ` Lucas De Marchi
2019-02-22 1:17 ` ✓ Fi.CI.BAT: success for drm/i915: Sort newer to older platforms. (rev2) Patchwork
2019-02-22 15:27 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222212533.GG2855@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.