From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] net: dsa: Inherit dev addr from master Date: Mon, 25 Feb 2019 14:21:07 +0100 Message-ID: <20190225132107.GG20855@lunn.ch> References: <20190222125654.12478-1-vkoul@kernel.org> <20190222143003.GL5653@lunn.ch> <441ae81a814498876e4cfed6fd5b7bcb@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <441ae81a814498876e4cfed6fd5b7bcb@codeaurora.org> Sender: netdev-owner@vger.kernel.org To: xiaofeis@codeaurora.org Cc: Vinod Koul , "David S. Miller" , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vivien Didelot , Florian Fainelli , Niklas Cassel , netdev@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org > I think we can remove the first inherit, but if keep it, we can see > consistent address output by ifconfig -a before open master and slave > interface. True But it also means we see inconsistent MAC addresses on the master. The MAC address changes on open. Maybe it would be better to change your master so it sets its MAC address during probe? Everything is then consistent all the time. Andrew