From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 25 Feb 2019 15:19:46 -0000 Received: from mail.kernel.org ([198.145.29.99]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gyI2i-0007vo-An for speck@linutronix.de; Mon, 25 Feb 2019 16:19:44 +0100 Date: Mon, 25 Feb 2019 16:19:35 +0100 From: Greg KH Subject: [MODERATED] Re: [PATCH v6 31/43] MDSv6 Message-ID: <20190225151935.GA19947@kroah.com> References: <8d04705a73208de4bb4a4062bf3d977b5ee5c5f4.1551019522.git.ak@linux.intel.com> MIME-Version: 1.0 In-Reply-To: <8d04705a73208de4bb4a4062bf3d977b5ee5c5f4.1551019522.git.ak@linux.intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Sun, Feb 24, 2019 at 07:07:37AM -0800, speck for Andi Kleen wrote: > From: Andi Kleen > Subject: mds sweep: Clear cpu for usbmon intercepts > > usbmon touches user data in interrupts that otherwise don't > touch user data. Automatically schedule a clear cpu if > usbmon is called from an interrupt. I have written a long and very satisfying rant about this patch, that I than deleted, as it made me feel very better, but probably would not have helped anyone else out. In turn, I need you to properly justify this patch as these two tiny sentences, and this small patch make no sense to me at all. Please explain _WHY_ this is needed in this specific location. Before responding, I would strongly recommend reading up on exactly what usbmon is and who is allowed to use it. If after doing that, you still feel this patch is needed (and it might be, I still can not tell for sure), please reply with enough detail that anyone who does not know what usbmon is, or what mds really is, can understand why this patch is needed. thanks, greg k-h