From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 25 Feb 2019 15:27:05 -0000 Received: from mail.kernel.org ([198.145.29.99]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gyI9o-0008EM-23 for speck@linutronix.de; Mon, 25 Feb 2019 16:27:04 +0100 Date: Mon, 25 Feb 2019 16:26:54 +0100 From: Greg KH Subject: [MODERATED] Re: [PATCH v6 39/43] MDSv6 Message-ID: <20190225152654.GB19947@kroah.com> References: <4e5e24fd0c2111686f32a55581efa5070cf0a160.1551019522.git.ak@linux.intel.com> MIME-Version: 1.0 In-Reply-To: <4e5e24fd0c2111686f32a55581efa5070cf0a160.1551019522.git.ak@linux.intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Sun, Feb 24, 2019 at 07:07:45AM -0800, speck for Andi Kleen wrote: > From: Andi Kleen > Subject: mds sweep: Make usb hcd poll clear cpu > > Most USB interrupt handlers do not touch user data, except > in some cases hcd poll is called which can copy a user buffer. This does not make sense to me. From a USB driver point of view, there are very _few_ irqs that do _not_ contain "user data". > Instead of marking all the USB interrupts and timers as clear cpu > only clear it when the user data touching actually happens. Um, almost all irqs here _do_ receive data across the wire, and your patch shows this happening. The text here is all wrong. Also, why are you classifying USB data as "user data"? It's coming from some random piece of hardware. I don't see a definition of what you are calling "user data" anywhere in this patchset, did I miss that somewhere? I know I asked previously for this, without that defintion, this huge patchset is pretty much impossible to review. greg k-h