From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 25 Feb 2019 16:24:39 -0000 Received: from mga11.intel.com ([192.55.52.93]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gyJ3W-0001nP-1w for speck@linutronix.de; Mon, 25 Feb 2019 17:24:38 +0100 Date: Mon, 25 Feb 2019 08:24:35 -0800 From: Andi Kleen Subject: [MODERATED] Re: [PATCH v6 31/43] MDSv6 Message-ID: <20190225162435.GQ16922@tassilo.jf.intel.com> References: <8d04705a73208de4bb4a4062bf3d977b5ee5c5f4.1551019522.git.ak@linux.intel.com> <20190225151935.GA19947@kroah.com> <20190225153411.GO16922@tassilo.jf.intel.com> <20190225154935.GA17057@kroah.com> MIME-Version: 1.0 In-Reply-To: <20190225154935.GA17057@kroah.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: Sorry didn't answer the second part of the message. On Mon, Feb 25, 2019 at 04:49:35PM +0100, speck for Greg KH wrote: > > > However I will probably not be able to write a detailed > > description for each of the interrupt handlers changed because > > there are just too many. > > Then how do you expect each subsystem / driver author to know if this is > an acceptable change or not? How do you expect to educate driver They will need to read clearcpu.txt at some point. They will need to do that anyways to learn what they need to know for future code reviews. If there's something missing in that file please point it out and I'll try to address it. In theory we could duplicate clearcpu.txt into every patch, but I don't that would be a good approach I can perhaps add some standard disclaimer as in "Please see Documentation/clearcpu.txt for more details" > authors to have them determine if they need to do this on their new > drivers or not? Are you going to hand-audit each new driver that gets > added to the kernel for forever? Yes ongoing audit is needed. See 00/00. That's the drawback of "really lazy". The earlier "opt in" patch kits didn't need that, but Linus didn't like it. -Andi