From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 25 Feb 2019 16:28:29 -0000 Received: from mga18.intel.com ([134.134.136.126]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gyJ7E-0001yK-CQ for speck@linutronix.de; Mon, 25 Feb 2019 17:28:28 +0100 Date: Mon, 25 Feb 2019 08:28:25 -0800 From: Andi Kleen Subject: [MODERATED] Re: [PATCH v6 39/43] MDSv6 Message-ID: <20190225162825.GR16922@tassilo.jf.intel.com> References: <4e5e24fd0c2111686f32a55581efa5070cf0a160.1551019522.git.ak@linux.intel.com> <20190225152654.GB19947@kroah.com> MIME-Version: 1.0 In-Reply-To: <20190225152654.GB19947@kroah.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: > > Instead of marking all the USB interrupts and timers as clear cpu > > only clear it when the user data touching actually happens. > > Um, almost all irqs here _do_ receive data across the wire, and your > patch shows this happening. The text here is all wrong. Just to be clear touching here it means "access with the CPU" especially copying. Just manipulating data addresses is fine. > Also, why are you classifying USB data as "user data"? It's coming from > some random piece of hardware. I don't see a definition of what you are > calling "user data" anywhere in this patchset, did I miss that > somewhere? user data includes IO data (but not metadata) USB could be key presses (e.g. your password) or mouse movements or block IO data These are all considered sensitive. -Andi