From: Nathan Chancellor <natechancellor@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: Clang patches for 4.9
Date: Mon, 25 Feb 2019 10:35:08 -0700 [thread overview]
Message-ID: <20190225173508.GA7885@archlinux-ryzen> (raw)
In-Reply-To: <20190225144719.GA14597@kroah.com>
On Mon, Feb 25, 2019 at 03:47:19PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 25, 2019 at 03:45:13PM +0100, Greg Kroah-Hartman wrote:
> > On Sun, Feb 24, 2019 at 11:13:01PM -0700, Nathan Chancellor wrote:
> > > Hi Greg and Sasha,
> > >
> > > Attached are three mbox files containing patches that bring the Clang
> > > backports that Nick did in 4.9.139 up to date with what is currently in
> > > 4.14 and mainline, as well as fix warnings that are present in the arm64
> > > and x86_64 defconfigs here and in AOSP (cuttlefish_defconfig). All of
> > > these warnings are fixed in 4.14 so there will be no regressions from
> > > upgrading.
> >
> > Really? I see a number of these only showing up in much newer kernels.
Sigh that's what I get for not double checking my email after adding
patches :(
> > Specifically these patches:
> > 1f60652dd586 ("pinctrl: max77620: Use define directive for max77620_pinconf_param values")
> > a0dd6773038f ("phy: tegra: remove redundant self assignment of 'map'")
> > a9903f04e0a4 ("sched/sysctl: Fix attributes of some extern declarations")
> >
> > from the "arm" mbox you provided. Why shouldn't the above patches go
> > into 4.14.y and in some cases, also 4.19.y and 4.20.y?
They should. All three pick cleanly to 4.14.y. Only the first one needs
to be taken into 4.19.y and 4.20.y.
>
> Also, why are you wanting 238bcbc4e07f ("kbuild: consolidate Clang
> compiler flags") to be in 4.9? You put it as the last patch in the
> series, nothing depends on it, which seems odd...
>
> greg k-h
This was more of a "to make future backports easier" commit, plus makes
that block way easier to read. I should have included 3bd9805090af
("Makefile: Export clang toolchain variables") as well though. I don't
feel strongly about it either way but I also don't think the commit
hurts anything.
I'll leave it up to you and provide you with an updated merge resolution
accordingly.
Thanks!
Nathan
next prev parent reply other threads:[~2019-02-25 17:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 6:13 Clang patches for 4.9 Nathan Chancellor
2019-02-25 14:45 ` Greg Kroah-Hartman
2019-02-25 14:47 ` Greg Kroah-Hartman
2019-02-25 17:35 ` Nathan Chancellor [this message]
2019-02-25 17:46 ` Nick Desaulniers
2019-02-25 17:55 ` Nathan Chancellor
2019-02-25 17:56 ` Greg Kroah-Hartman
2019-02-25 14:55 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225173508.GA7885@archlinux-ryzen \
--to=natechancellor@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.