From: Leslie Monis <lesliemonis@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 5/7] net: sched: pie: add more cases to auto-tune alpha and beta
Date: Mon, 25 Feb 2019 23:34:18 +0530 [thread overview]
Message-ID: <20190225180418.GA17596@Inspiron-3521> (raw)
In-Reply-To: <20190225.094038.1156384775297802527.davem@davemloft.net>
On Mon, Feb 25, 2019 at 09:40:38AM -0800, David Miller wrote:
> From: Leslie Monis <lesliemonis@gmail.com>
> Date: Mon, 25 Feb 2019 15:50:49 +0530
>
> > + power = 100;
> > + while (q->vars.prob < MAX_PROB / (u64)power &&
>
> You have to use div_u64() or similar when doing 64-bit divisons otherwise
> you'll get build failures on 32-bit platforms.
Alright. Thanks for the feedback.
next prev parent reply other threads:[~2019-02-25 18:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 10:20 [PATCH net-next v2 0/7] net: sched: pie: align PIE implementation with RFC 8033 Leslie Monis
2019-02-25 10:20 ` [PATCH net-next v2 1/7] net: sched: pie: change value of QUEUE_THRESHOLD Leslie Monis
2019-02-25 10:20 ` [PATCH net-next v2 2/7] net: sched: pie: change default value of pie_params->target Leslie Monis
2019-02-25 10:20 ` [PATCH net-next v2 3/7] net: sched: pie: change default value of pie_params->tupdate Leslie Monis
2019-02-25 10:20 ` [PATCH net-next v2 4/7] net: sched: pie: change initial value of pie_vars->burst_time Leslie Monis
2019-02-25 10:20 ` [PATCH net-next v2 5/7] net: sched: pie: add more cases to auto-tune alpha and beta Leslie Monis
2019-02-25 17:40 ` David Miller
2019-02-25 18:04 ` Leslie Monis [this message]
2019-02-26 5:31 ` kbuild test robot
2019-02-26 6:48 ` kbuild test robot
2019-02-25 10:20 ` [PATCH net-next v2 6/7] net: sched: pie: add derandomization mechanism Leslie Monis
2019-02-25 10:20 ` [PATCH net-next v2 7/7] net: sched: pie: update references Leslie Monis
2019-02-25 13:43 ` [PATCH net-next v2 0/7] net: sched: pie: align PIE implementation with RFC 8033 Jamal Hadi Salim
2019-02-25 13:47 ` Jamal Hadi Salim
2019-02-25 14:11 ` Dave Taht
2019-02-25 14:33 ` Jamal Hadi Salim
2019-02-25 15:04 ` Leslie Monis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225180418.GA17596@Inspiron-3521 \
--to=lesliemonis@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.