From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15A51C43381 for ; Mon, 25 Feb 2019 18:34:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D41AC20652 for ; Mon, 25 Feb 2019 18:34:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728833AbfBYSez (ORCPT ); Mon, 25 Feb 2019 13:34:55 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:46321 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725936AbfBYSez (ORCPT ); Mon, 25 Feb 2019 13:34:55 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id D30338029E; Mon, 25 Feb 2019 19:34:46 +0100 (CET) Date: Mon, 25 Feb 2019 19:34:53 +0100 From: Pavel Machek To: Joe Perches Cc: Florian Fainelli , Tristram.Ha@microchip.com, andrew@lunn.ch, sergio.paracuellos@gmail.com, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org Subject: Re: [PATCH v1 net-next 2/4] net: dsa: microchip: add MIB counter reading support Message-ID: <20190225183453.GA9243@amd> References: <1549598829-25970-1-git-send-email-Tristram.Ha@microchip.com> <1549598829-25970-3-git-send-email-Tristram.Ha@microchip.com> <20190209172249.GG30856@lunn.ch> <2cf3bf259bed9e44bd7e885850e45cb3a62e3779.camel@perches.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx" Content-Disposition: inline In-Reply-To: <2cf3bf259bed9e44bd7e885850e45cb3a62e3779.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2019-02-20 15:49:25, Joe Perches wrote: > On Tue, 2019-02-12 at 19:51 -0800, Florian Fainelli wrote: > > On February 12, 2019 6:39:49 PM PST, Tristram.Ha@microchip.com wrote: > > > > > +static void ksz9477_freeze_mib(struct ksz_device *dev, int port, > > > > > + bool freeze) > > > > > +{ > > > > > + struct ksz_port *p =3D &dev->ports[port]; > > > > > + u32 val =3D freeze ? MIB_COUNTER_FLUSH_FREEZE : 0; > > > >=20 > > > > Reverse Christmas tree. > > >=20 > > > There was a checkpatch.pl patch in 2016 that tried to check this, but > > > it was never accepted? >=20 > https://lore.kernel.org/patchwork/patch/732076/ >=20 > While I still think use of reverse christmas tree is misguided, > there were some disagreements about what form it really is: Agreed about "misguided". Often there's more logical order, like "self" pointer first... which this patch follows. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --dDRMvlgZJXvWKvBx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlx0NU0ACgkQMOfwapXb+vKNPACgvcJ9dZpadCJkNQ4NOxvUemLP /wYAoKMVajXEGkid5cIONSHklIBMWtbz =iq4G -----END PGP SIGNATURE----- --dDRMvlgZJXvWKvBx--