From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: extract AUX mask assignment to separate function Date: Mon, 25 Feb 2019 21:20:35 +0200 Message-ID: <20190225192035.GL20097@intel.com> References: <20190222235954.9795-1-lucas.demarchi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D0F389B78 for ; Mon, 25 Feb 2019 19:20:39 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190222235954.9795-1-lucas.demarchi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBGZWIgMjIsIDIwMTkgYXQgMDM6NTk6NTRQTSAtMDgwMCwgTHVjYXMgRGUgTWFyY2hp IHdyb3RlOgo+IE5vIGNoYW5nZSBpbiBiZWhhdmlvciwgdGhpcyBvbmx5IGFsbG93cyB0byBtb3Jl IGVhc2lseSBmb2xsb3cgdGhlIGZsb3cKPiBvZiBnZW44X2RlX2lycV9oYW5kbGVyIHdpdGhvdXQg dGhlIG1hc2sgYXNzaWdubWVudHMgZm9yIGVhY2ggcGxhdGZvcm0uCj4gVGhpcyBhbHNvIHJlLW9y Z2FuaXplcyB0aGUgYnJhbmNoZXMgYSBsaXR0bGUgYml0LCBzbyB0aGUgb25lLW9mZiBjYXNlCj4g Zm9yIENOTF9XSVRIX1BPUlRfRiBpcyBzZXBhcmF0ZSBmcm9tIHRoZSBnZW5lcmljIGdlbiA+PSAx MS4KPiAKPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv bT4KPiBDYzogSm9zZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1i eTogTHVjYXMgRGUgTWFyY2hpIDxsdWNhcy5kZW1hcmNoaUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgfCAzNCArKysrKysrKysrKysrKysrKysrLS0t LS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDE0IGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+IGluZGV4IDdjN2U4NGU4NmM2YS4u NTI0Y2FmMTY4YTAxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJx LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gQEAgLTI2NzYsNiAr MjY3NiwyNSBAQCBzdGF0aWMgdm9pZCBnZW4xMV9ocGRfaXJxX2hhbmRsZXIoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIgaWlyKQo+ICAJCURSTV9FUlJPUigiVW5leHBlY3Rl ZCBERSBIUEQgaW50ZXJydXB0IDB4JTA4eFxuIiwgaWlyKTsKPiAgfQo+ICAKPiArc3RhdGljIHUz MiBkZV9wb3J0X2lpcl9hdXhfbWFzayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp CgpJIHdvdWxkIGRyb3AgdGhlICJpaXIiIHNpbmNlIHRoaXMgYXBwbGllcyB0byBhbGwgaXJxIHJl Z2lzdGVycy4KQW5kIG1heWJlIHByZWZpeCB3aXRoICJnZW44XyIgPwoKT3RoZXJ3aXNlClJldmll d2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoK PiArewo+ICsJdTMyIG1hc2sgPSBHRU44X0FVWF9DSEFOTkVMX0E7Cj4gKwo+ICsJaWYgKElOVEVM X0dFTihkZXZfcHJpdikgPj0gOSkKPiArCQltYXNrIHw9IEdFTjlfQVVYX0NIQU5ORUxfQiB8Cj4g KwkJCUdFTjlfQVVYX0NIQU5ORUxfQyB8Cj4gKwkJCUdFTjlfQVVYX0NIQU5ORUxfRDsKPiArCj4g KwlpZiAoSVNfQ05MX1dJVEhfUE9SVF9GKGRldl9wcml2KSkKPiArCQltYXNrIHw9IENOTF9BVVhf Q0hBTk5FTF9GOwo+ICsKPiArCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDExKQo+ICsJCW1h c2sgfD0gSUNMX0FVWF9DSEFOTkVMX0UgfAo+ICsJCQlDTkxfQVVYX0NIQU5ORUxfRjsKPiArCj4g KwlyZXR1cm4gbWFzazsKPiArfQo+ICsKPiAgc3RhdGljIGlycXJldHVybl90Cj4gIGdlbjhfZGVf aXJxX2hhbmRsZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIgbWFzdGVy X2N0bCkKPiAgewo+IEBAIC0yNzMxLDIwICsyNzUwLDcgQEAgZ2VuOF9kZV9pcnFfaGFuZGxlcihz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiBtYXN0ZXJfY3RsKQo+ICAJCQlJ OTE1X1dSSVRFKEdFTjhfREVfUE9SVF9JSVIsIGlpcik7Cj4gIAkJCXJldCA9IElSUV9IQU5ETEVE Owo+ICAKPiAtCQkJdG1wX21hc2sgPSBHRU44X0FVWF9DSEFOTkVMX0E7Cj4gLQkJCWlmIChJTlRF TF9HRU4oZGV2X3ByaXYpID49IDkpCj4gLQkJCQl0bXBfbWFzayB8PSBHRU45X0FVWF9DSEFOTkVM X0IgfAo+IC0JCQkJCSAgICBHRU45X0FVWF9DSEFOTkVMX0MgfAo+IC0JCQkJCSAgICBHRU45X0FV WF9DSEFOTkVMX0Q7Cj4gLQo+IC0JCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMSkKPiAt CQkJCXRtcF9tYXNrIHw9IElDTF9BVVhfQ0hBTk5FTF9FOwo+IC0KPiAtCQkJaWYgKElTX0NOTF9X SVRIX1BPUlRfRihkZXZfcHJpdikgfHwKPiAtCQkJICAgIElOVEVMX0dFTihkZXZfcHJpdikgPj0g MTEpCj4gLQkJCQl0bXBfbWFzayB8PSBDTkxfQVVYX0NIQU5ORUxfRjsKPiAtCj4gLQkJCWlmIChp aXIgJiB0bXBfbWFzaykgewo+ICsJCQlpZiAoaWlyICYgZGVfcG9ydF9paXJfYXV4X21hc2soZGV2 X3ByaXYpKSB7Cj4gIAkJCQlkcF9hdXhfaXJxX2hhbmRsZXIoZGV2X3ByaXYpOwo+ICAJCQkJZm91 bmQgPSB0cnVlOwo+ICAJCQl9Cj4gLS0gCj4gMi4yMC4wCgotLSAKVmlsbGUgU3lyasOkbMOkCklu dGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==