From: Jonathan Nieder <jrnieder@gmail.com>
To: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/1] mingw: drop MakeMaker reference
Date: Mon, 25 Feb 2019 12:02:25 -0800 [thread overview]
Message-ID: <20190225200225.GA16965@google.com> (raw)
In-Reply-To: <061093e2f000829a560e7bcce1dc86cb6babbca5.1551122830.git.gitgitgadget@gmail.com>
Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> In 20d2a30f8ffe (Makefile: replace perl/Makefile.PL with simple make
> rules, 2017-12-10), Git stopped using MakeMaker. Therefore, that
> definition in the MINGW-specific section became useless.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> config.mak.uname | 1 -
> 1 file changed, 1 deletion(-)
Yay!
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Is there a way to automate checking for make variables that are set
but never used?
Thanks,
Jonathan
next prev parent reply other threads:[~2019-02-25 20:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 19:27 [PATCH 0/1] Drop last MakeMaker reference Johannes Schindelin via GitGitGadget
2019-02-25 19:27 ` [PATCH 1/1] mingw: drop " Johannes Schindelin via GitGitGadget
2019-02-25 20:02 ` Jonathan Nieder [this message]
2019-02-25 22:07 ` Johannes Schindelin
2019-03-03 1:19 ` [PATCH 0/1] Drop last " Junio C Hamano
2019-03-07 10:10 ` Johannes Schindelin
2019-03-08 1:41 ` Junio C Hamano
2019-03-08 16:27 ` Johannes Schindelin
2019-03-11 20:24 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225200225.GA16965@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.