From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/3] drm/i915/icl: move MG pll hw_state readout Date: Mon, 25 Feb 2019 22:42:12 +0200 Message-ID: <20190225204212.GO20097@intel.com> References: <20190222232324.16405-1-lucas.demarchi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 755A3892CD for ; Mon, 25 Feb 2019 20:42:15 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190222232324.16405-1-lucas.demarchi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBGZWIgMjIsIDIwMTkgYXQgMDM6MjM6MjJQTSAtMDgwMCwgTHVjYXMgRGUgTWFyY2hp IHdyb3RlOgo+IExldCB0aGUgTUcgcGxscyBoYXZlIHRoZWlyIG93biBob29rcyBzaW5jZSBpdCBz aGFyZXMgdmVyeSBsaXR0bGUgd2l0aAo+IG90aGVyIFBMTCB0eXBlcy4gSXQncyBhbHNvIGJldHRl ciBzbyB0aGUgcGxhdGZvcm0gaW5mbyBjb250YWlucyB0aGUgaW5mbwo+IGlmIHRoZSBQTEwgaXMg Zm9yIE1HIFBIWSByYXRoZXIgdGhhbiByZWx5aW5nIG9uIHRoZSBQTEwgaWRzLgo+IAo+IFNpZ25l ZC1vZmYtYnk6IEx1Y2FzIERlIE1hcmNoaSA8bHVjYXMuZGVtYXJjaGlAaW50ZWwuY29tPgoKVGhl cmUncyBxdWl0ZSBhIGJpdCBtb3JlIGNsZWFudXAgdG8gYmUgZG9uZSBpbiB0aGlzIGFyZWEuIEFz IGEgc3RhcnQKaHR0cHM6Ly9wYXRjaHdvcmsuZnJlZWRlc2t0b3Aub3JnL3Nlcmllcy81NjM1NC8g OykKClRoaXMgcGF0Y2ggbG9va3MgZ29vZCB0byBtZS4gSXQnbGwgY29uZmxpY3Qgd2l0aCBteSBz ZXJpZXMgdGhvdWdoLCBidXQKbm8gYmlnZ2llLgpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOk IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RwbGxfbWdyLmMgfCAxMjIgKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0K PiAgMSBmaWxlIGNoYW5nZWQsIDc0IGluc2VydGlvbnMoKyksIDQ4IGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+IGluZGV4IDBhNDJkMTFjNGMzMy4u ZTRlYzczZDQxNWQ5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw bGxfbWdyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4g QEAgLTI5NjYsNiArMjk2Niw2OCBAQCBzdGF0aWMgaTkxNV9yZWdfdCBpY2xfcGxsX2lkX3RvX2Vu YWJsZV9yZWcoZW51bSBpbnRlbF9kcGxsX2lkIGlkKQo+ICAJcmV0dXJuIE1HX1BMTF9FTkFCTEUo aWNsX3BsbF9pZF90b190Y19wb3J0KGlkKSk7Cj4gIH0KPiAgCj4gK3N0YXRpYyBib29sIG1nX3Bs bF9nZXRfaHdfc3RhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICsJCQkJ c3RydWN0IGludGVsX3NoYXJlZF9kcGxsICpwbGwsCj4gKwkJCQlzdHJ1Y3QgaW50ZWxfZHBsbF9o d19zdGF0ZSAqaHdfc3RhdGUpCj4gK3sKPiArCWNvbnN0IGVudW0gaW50ZWxfZHBsbF9pZCBpZCA9 IHBsbC0+aW5mby0+aWQ7Cj4gKwllbnVtIHRjX3BvcnQgdGNfcG9ydCA9IGljbF9wbGxfaWRfdG9f dGNfcG9ydChpZCk7Cj4gKwlpbnRlbF93YWtlcmVmX3Qgd2FrZXJlZjsKPiArCWJvb2wgcmV0ID0g ZmFsc2U7Cj4gKwl1MzIgdmFsOwo+ICsKPiArCXdha2VyZWYgPSBpbnRlbF9kaXNwbGF5X3Bvd2Vy X2dldF9pZl9lbmFibGVkKGRldl9wcml2LAo+ICsJCQkJCQkgICAgIFBPV0VSX0RPTUFJTl9QTExT KTsKPiArCWlmICghd2FrZXJlZikKPiArCQlyZXR1cm4gZmFsc2U7Cj4gKwo+ICsJdmFsID0gSTkx NV9SRUFEKE1HX1BMTF9FTkFCTEUodGNfcG9ydCkpOwo+ICsJaWYgKCEodmFsICYgUExMX0VOQUJM RSkpCj4gKwkJZ290byBvdXQ7Cj4gKwo+ICsJaHdfc3RhdGUtPm1nX3JlZmNsa2luX2N0bCA9IEk5 MTVfUkVBRChNR19SRUZDTEtJTl9DVEwodGNfcG9ydCkpOwo+ICsJaHdfc3RhdGUtPm1nX3JlZmNs a2luX2N0bCAmPSBNR19SRUZDTEtJTl9DVExfT0RfMl9NVVhfTUFTSzsKPiArCj4gKwlod19zdGF0 ZS0+bWdfY2xrdG9wMl9jb3JlY2xrY3RsMSA9Cj4gKwkJSTkxNV9SRUFEKE1HX0NMS1RPUDJfQ09S RUNMS0NUTDEodGNfcG9ydCkpOwo+ICsJaHdfc3RhdGUtPm1nX2Nsa3RvcDJfY29yZWNsa2N0bDEg Jj0KPiArCQlNR19DTEtUT1AyX0NPUkVDTEtDVEwxX0FfRElWUkFUSU9fTUFTSzsKPiArCj4gKwlo d19zdGF0ZS0+bWdfY2xrdG9wMl9oc2Nsa2N0bCA9Cj4gKwkJSTkxNV9SRUFEKE1HX0NMS1RPUDJf SFNDTEtDVEwodGNfcG9ydCkpOwo+ICsJaHdfc3RhdGUtPm1nX2Nsa3RvcDJfaHNjbGtjdGwgJj0K PiArCQlNR19DTEtUT1AyX0hTQ0xLQ1RMX1RMSU5FRFJWX0NMS1NFTF9NQVNLIHwKPiArCQlNR19D TEtUT1AyX0hTQ0xLQ1RMX0NPUkVfSU5QVVRTRUxfTUFTSyB8Cj4gKwkJTUdfQ0xLVE9QMl9IU0NM S0NUTF9IU0RJVl9SQVRJT19NQVNLIHwKPiArCQlNR19DTEtUT1AyX0hTQ0xLQ1RMX0RTRElWX1JB VElPX01BU0s7Cj4gKwo+ICsJaHdfc3RhdGUtPm1nX3BsbF9kaXYwID0gSTkxNV9SRUFEKE1HX1BM TF9ESVYwKHRjX3BvcnQpKTsKPiArCWh3X3N0YXRlLT5tZ19wbGxfZGl2MSA9IEk5MTVfUkVBRChN R19QTExfRElWMSh0Y19wb3J0KSk7Cj4gKwlod19zdGF0ZS0+bWdfcGxsX2xmID0gSTkxNV9SRUFE KE1HX1BMTF9MRih0Y19wb3J0KSk7Cj4gKwlod19zdGF0ZS0+bWdfcGxsX2ZyYWNfbG9jayA9IEk5 MTVfUkVBRChNR19QTExfRlJBQ19MT0NLKHRjX3BvcnQpKTsKPiArCWh3X3N0YXRlLT5tZ19wbGxf c3NjID0gSTkxNV9SRUFEKE1HX1BMTF9TU0ModGNfcG9ydCkpOwo+ICsKPiArCWh3X3N0YXRlLT5t Z19wbGxfYmlhcyA9IEk5MTVfUkVBRChNR19QTExfQklBUyh0Y19wb3J0KSk7Cj4gKwlod19zdGF0 ZS0+bWdfcGxsX3RkY19jb2xkc3RfYmlhcyA9Cj4gKwkJSTkxNV9SRUFEKE1HX1BMTF9URENfQ09M RFNUX0JJQVModGNfcG9ydCkpOwo+ICsKPiArCWlmIChkZXZfcHJpdi0+Y2RjbGsuaHcucmVmID09 IDM4NDAwKSB7Cj4gKwkJaHdfc3RhdGUtPm1nX3BsbF90ZGNfY29sZHN0X2JpYXNfbWFzayA9IE1H X1BMTF9URENfQ09MRFNUX0NPTERTVEFSVDsKPiArCQlod19zdGF0ZS0+bWdfcGxsX2JpYXNfbWFz ayA9IDA7Cj4gKwl9IGVsc2Ugewo+ICsJCWh3X3N0YXRlLT5tZ19wbGxfdGRjX2NvbGRzdF9iaWFz X21hc2sgPSAtMVU7Cj4gKwkJaHdfc3RhdGUtPm1nX3BsbF9iaWFzX21hc2sgPSAtMVU7Cj4gKwl9 Cj4gKwo+ICsJaHdfc3RhdGUtPm1nX3BsbF90ZGNfY29sZHN0X2JpYXMgJj0gaHdfc3RhdGUtPm1n X3BsbF90ZGNfY29sZHN0X2JpYXNfbWFzazsKPiArCWh3X3N0YXRlLT5tZ19wbGxfYmlhcyAmPSBo d19zdGF0ZS0+bWdfcGxsX2JpYXNfbWFzazsKPiArCj4gKwlyZXQgPSB0cnVlOwo+ICtvdXQ6Cj4g KwlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJpdiwgUE9XRVJfRE9NQUlOX1BMTFMsIHdh a2VyZWYpOwo+ICsJcmV0dXJuIHJldDsKPiArfQo+ICsKPiAgc3RhdGljIGJvb2wgaWNsX3BsbF9n ZXRfaHdfc3RhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCQkJIHN0 cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAqcGxsLAo+ICAJCQkJIHN0cnVjdCBpbnRlbF9kcGxsX2h3 X3N0YXRlICpod19zdGF0ZSkKPiBAQCAtMjk4NCw1MCArMzA0Niw4IEBAIHN0YXRpYyBib29sIGlj bF9wbGxfZ2V0X2h3X3N0YXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAg CWlmICghKHZhbCAmIFBMTF9FTkFCTEUpKQo+ICAJCWdvdG8gb3V0Owo+ICAKPiAtCWlmIChpbnRl bF9kcGxsX2lzX2NvbWJvcGh5KGlkKSB8fAo+IC0JICAgIGlkID09IERQTExfSURfSUNMX1RCVFBM TCkgewo+IC0JCWh3X3N0YXRlLT5jZmdjcjAgPSBJOTE1X1JFQUQoSUNMX0RQTExfQ0ZHQ1IwKGlk KSk7Cj4gLQkJaHdfc3RhdGUtPmNmZ2NyMSA9IEk5MTVfUkVBRChJQ0xfRFBMTF9DRkdDUjEoaWQp KTsKPiAtCX0gZWxzZSB7Cj4gLQkJZW51bSB0Y19wb3J0IHRjX3BvcnQgPSBpY2xfcGxsX2lkX3Rv X3RjX3BvcnQoaWQpOwo+IC0KPiAtCQlod19zdGF0ZS0+bWdfcmVmY2xraW5fY3RsID0gSTkxNV9S RUFEKE1HX1JFRkNMS0lOX0NUTCh0Y19wb3J0KSk7Cj4gLQkJaHdfc3RhdGUtPm1nX3JlZmNsa2lu X2N0bCAmPSBNR19SRUZDTEtJTl9DVExfT0RfMl9NVVhfTUFTSzsKPiAtCj4gLQkJaHdfc3RhdGUt Pm1nX2Nsa3RvcDJfY29yZWNsa2N0bDEgPQo+IC0JCQlJOTE1X1JFQUQoTUdfQ0xLVE9QMl9DT1JF Q0xLQ1RMMSh0Y19wb3J0KSk7Cj4gLQkJaHdfc3RhdGUtPm1nX2Nsa3RvcDJfY29yZWNsa2N0bDEg Jj0KPiAtCQkJTUdfQ0xLVE9QMl9DT1JFQ0xLQ1RMMV9BX0RJVlJBVElPX01BU0s7Cj4gLQo+IC0J CWh3X3N0YXRlLT5tZ19jbGt0b3AyX2hzY2xrY3RsID0KPiAtCQkJSTkxNV9SRUFEKE1HX0NMS1RP UDJfSFNDTEtDVEwodGNfcG9ydCkpOwo+IC0JCWh3X3N0YXRlLT5tZ19jbGt0b3AyX2hzY2xrY3Rs ICY9Cj4gLQkJCU1HX0NMS1RPUDJfSFNDTEtDVExfVExJTkVEUlZfQ0xLU0VMX01BU0sgfAo+IC0J CQlNR19DTEtUT1AyX0hTQ0xLQ1RMX0NPUkVfSU5QVVRTRUxfTUFTSyB8Cj4gLQkJCU1HX0NMS1RP UDJfSFNDTEtDVExfSFNESVZfUkFUSU9fTUFTSyB8Cj4gLQkJCU1HX0NMS1RPUDJfSFNDTEtDVExf RFNESVZfUkFUSU9fTUFTSzsKPiAtCj4gLQkJaHdfc3RhdGUtPm1nX3BsbF9kaXYwID0gSTkxNV9S RUFEKE1HX1BMTF9ESVYwKHRjX3BvcnQpKTsKPiAtCQlod19zdGF0ZS0+bWdfcGxsX2RpdjEgPSBJ OTE1X1JFQUQoTUdfUExMX0RJVjEodGNfcG9ydCkpOwo+IC0JCWh3X3N0YXRlLT5tZ19wbGxfbGYg PSBJOTE1X1JFQUQoTUdfUExMX0xGKHRjX3BvcnQpKTsKPiAtCQlod19zdGF0ZS0+bWdfcGxsX2Zy YWNfbG9jayA9IEk5MTVfUkVBRChNR19QTExfRlJBQ19MT0NLKHRjX3BvcnQpKTsKPiAtCQlod19z dGF0ZS0+bWdfcGxsX3NzYyA9IEk5MTVfUkVBRChNR19QTExfU1NDKHRjX3BvcnQpKTsKPiAtCj4g LQkJaHdfc3RhdGUtPm1nX3BsbF9iaWFzID0gSTkxNV9SRUFEKE1HX1BMTF9CSUFTKHRjX3BvcnQp KTsKPiAtCQlod19zdGF0ZS0+bWdfcGxsX3RkY19jb2xkc3RfYmlhcyA9Cj4gLQkJCUk5MTVfUkVB RChNR19QTExfVERDX0NPTERTVF9CSUFTKHRjX3BvcnQpKTsKPiAtCj4gLQkJaWYgKGRldl9wcml2 LT5jZGNsay5ody5yZWYgPT0gMzg0MDApIHsKPiAtCQkJaHdfc3RhdGUtPm1nX3BsbF90ZGNfY29s ZHN0X2JpYXNfbWFzayA9IE1HX1BMTF9URENfQ09MRFNUX0NPTERTVEFSVDsKPiAtCQkJaHdfc3Rh dGUtPm1nX3BsbF9iaWFzX21hc2sgPSAwOwo+IC0JCX0gZWxzZSB7Cj4gLQkJCWh3X3N0YXRlLT5t Z19wbGxfdGRjX2NvbGRzdF9iaWFzX21hc2sgPSAtMVU7Cj4gLQkJCWh3X3N0YXRlLT5tZ19wbGxf Ymlhc19tYXNrID0gLTFVOwo+IC0JCX0KPiAtCj4gLQkJaHdfc3RhdGUtPm1nX3BsbF90ZGNfY29s ZHN0X2JpYXMgJj0gaHdfc3RhdGUtPm1nX3BsbF90ZGNfY29sZHN0X2JpYXNfbWFzazsKPiAtCQlo d19zdGF0ZS0+bWdfcGxsX2JpYXMgJj0gaHdfc3RhdGUtPm1nX3BsbF9iaWFzX21hc2s7Cj4gLQl9 Cj4gKwlod19zdGF0ZS0+Y2ZnY3IwID0gSTkxNV9SRUFEKElDTF9EUExMX0NGR0NSMChpZCkpOwo+ ICsJaHdfc3RhdGUtPmNmZ2NyMSA9IEk5MTVfUkVBRChJQ0xfRFBMTF9DRkdDUjEoaWQpKTsKPiAg Cj4gIAlyZXQgPSB0cnVlOwo+ICBvdXQ6Cj4gQEAgLTMyMDMsMTQgKzMyMjMsMjAgQEAgc3RhdGlj IGNvbnN0IHN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbF9mdW5jcyBpY2xfcGxsX2Z1bmNzID0gewo+ ICAJLmdldF9od19zdGF0ZSA9IGljbF9wbGxfZ2V0X2h3X3N0YXRlLAo+ICB9Owo+ICAKPiArc3Rh dGljIGNvbnN0IHN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbF9mdW5jcyBtZ19wbGxfZnVuY3MgPSB7 Cj4gKwkuZW5hYmxlID0gaWNsX3BsbF9lbmFibGUsCj4gKwkuZGlzYWJsZSA9IGljbF9wbGxfZGlz YWJsZSwKPiArCS5nZXRfaHdfc3RhdGUgPSBtZ19wbGxfZ2V0X2h3X3N0YXRlLAo+ICt9Owo+ICsK PiAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcGxsX2luZm8gaWNsX3BsbHNbXSA9IHsKPiAgCXsgIkRQ TEwgMCIsICAgJmljbF9wbGxfZnVuY3MsIERQTExfSURfSUNMX0RQTEwwLCAgMCB9LAo+ICAJeyAi RFBMTCAxIiwgICAmaWNsX3BsbF9mdW5jcywgRFBMTF9JRF9JQ0xfRFBMTDEsICAwIH0sCj4gIAl7 ICJUQlQgUExMIiwgICZpY2xfcGxsX2Z1bmNzLCBEUExMX0lEX0lDTF9UQlRQTEwsIDAgfSwKPiAt CXsgIk1HIFBMTCAxIiwgJmljbF9wbGxfZnVuY3MsIERQTExfSURfSUNMX01HUExMMSwgMCB9LAo+ IC0JeyAiTUcgUExMIDIiLCAmaWNsX3BsbF9mdW5jcywgRFBMTF9JRF9JQ0xfTUdQTEwyLCAwIH0s Cj4gLQl7ICJNRyBQTEwgMyIsICZpY2xfcGxsX2Z1bmNzLCBEUExMX0lEX0lDTF9NR1BMTDMsIDAg fSwKPiAtCXsgIk1HIFBMTCA0IiwgJmljbF9wbGxfZnVuY3MsIERQTExfSURfSUNMX01HUExMNCwg MCB9LAo+ICsJeyAiTUcgUExMIDEiLCAmbWdfcGxsX2Z1bmNzLCBEUExMX0lEX0lDTF9NR1BMTDEs IDAgfSwKPiArCXsgIk1HIFBMTCAyIiwgJm1nX3BsbF9mdW5jcywgRFBMTF9JRF9JQ0xfTUdQTEwy LCAwIH0sCj4gKwl7ICJNRyBQTEwgMyIsICZtZ19wbGxfZnVuY3MsIERQTExfSURfSUNMX01HUExM MywgMCB9LAo+ICsJeyAiTUcgUExMIDQiLCAmbWdfcGxsX2Z1bmNzLCBEUExMX0lEX0lDTF9NR1BM TDQsIDAgfSwKPiAgCXsgfSwKPiAgfTsKPiAgCj4gLS0gCj4gMi4yMC4wCj4gCj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGlu ZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3ly asOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eA==