From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 3/3] drm/i915/icl: decouple dpll ids from
 type
Date: Mon, 25 Feb 2019 22:45:34 +0200
Message-ID: <20190225204534.GP20097@intel.com>
References: <20190222232324.16405-1-lucas.demarchi@intel.com>
 <20190222232324.16405-3-lucas.demarchi@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by gabe.freedesktop.org (Postfix) with ESMTPS id E863688E45
 for <intel-gfx@lists.freedesktop.org>; Mon, 25 Feb 2019 20:45:37 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190222232324.16405-3-lucas.demarchi@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBGZWIgMjIsIDIwMTkgYXQgMDM6MjM6MjRQTSAtMDgwMCwgTHVjYXMgRGUgTWFyY2hp
IHdyb3RlOgo+IFVzZSB0aGUgZmlyc3QgMyBiaXRzIG9mIGRwbGxfaW5mby5wbGF0Zm9ybV9mbGFn
cyB0byBtYXJrIHRoZSB0eXBlIG9mIHRoZQo+IFBMTCBpbnN0ZWFkIG9mIHJlbHlpbmcgb24gdGhl
IElEcy4gVGhpcyBpcyBtb3JlIGZ1dHVyZSBwcm9vZiBmb3IKPiBhbGxvd2luZyB0aGUgc2FtZSBz
ZXQgb2YgZnVuY3Rpb25zIHRvIGJlIHJldXNlZCwgZXZlbiBpZiB0aGUgSURzIGNoYW5nZS4KPiAK
PiBUaGUgd2FybmluZyBhYm91dCBQTEwgaWQgbm90IGNvcnJlc3BvbmRpbmcgdG8gYSBjb21ibyBw
aHkgaW4gaW50ZWxfZGlzcGxheQo+IHdhcyByZW1vdmVkIGFzIEkgZG9uJ3QgdGhpbmsgaXQgc2hv
dWxkIGV2ZXIgdHJpZ2dlci4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBMdWNhcyBEZSBNYXJjaGkgPGx1
Y2FzLmRlbWFyY2hpQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfZGlzcGxheS5jICB8ICAzIC0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxf
bWdyLmMgfCA1NCArKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfZHBsbF9tZ3IuaCB8ICAxIC0KPiAgMyBmaWxlcyBjaGFuZ2VkLCAzNSBpbnNl
cnRpb25zKCspLCAyMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz
cGxheS5jCj4gaW5kZXggYjFkNjNjMzJjYTk0Li5hMmJlMzUxMThkZDUgMTAwNjQ0Cj4gLS0tIGEv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTk1OTIsOSArOTU5Miw2IEBAIHN0YXRpYyB2
b2lkIGljZWxha2VfZ2V0X2RkaV9wbGwoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2
LAo+ICAJCXRlbXAgPSBJOTE1X1JFQUQoRFBDTEtBX0NGR0NSMF9JQ0wpICYKPiAgCQkgICAgICAg
RFBDTEtBX0NGR0NSMF9ERElfQ0xLX1NFTF9NQVNLKHBvcnQpOwo+ICAJCWlkID0gdGVtcCA+PiBE
UENMS0FfQ0ZHQ1IwX0RESV9DTEtfU0VMX1NISUZUKHBvcnQpOwo+IC0KPiAtCQlpZiAoV0FSTl9P
TighaW50ZWxfZHBsbF9pc19jb21ib3BoeShpZCkpKQo+IC0JCQlyZXR1cm47Cj4gIAl9IGVsc2Ug
aWYgKGludGVsX3BvcnRfaXNfdGMoZGV2X3ByaXYsIHBvcnQpKSB7Cj4gIAkJaWQgPSBpY2xfdGNf
cG9ydF90b19wbGxfaWQoaW50ZWxfcG9ydF90b190YyhkZXZfcHJpdiwgcG9ydCkpOwo+ICAJfSBl
bHNlIHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3Iu
YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMKPiBpbmRleCBlNGVjNzNk
NDE1ZDkuLmNkYjQ0NjNiYWI1ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9kcGxsX21nci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9t
Z3IuYwo+IEBAIC0yNjM5LDYgKzI2MzksMTMgQEAgaW50IGljbF9jYWxjX2RwX2NvbWJvX3BsbF9s
aW5rKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCXJldHVybiBsaW5rX2Ns
b2NrOwo+ICB9Cj4gIAo+ICtlbnVtIGljbF9kcGxsX2ZsYWdzIHsKPiArCUlDTF9EUExMX1RZUEVf
Q09NQk9QSFksCj4gKwlJQ0xfRFBMTF9UWVBFX1RCVCwKPiArCUlDTF9EUExMX1RZUEVfTUcsCj4g
KwlfSUNMX0RQTExfVFlQRV9NQVNLID0gMHg3LAo+ICt9Owo+ICsKPiAgc3RhdGljIGVudW0gdGNf
cG9ydCBpY2xfcGxsX2lkX3RvX3RjX3BvcnQoZW51bSBpbnRlbF9kcGxsX2lkIGlkKQo+ICB7Cj4g
IAlyZXR1cm4gaWQgLSBEUExMX0lEX0lDTF9NR1BMTDE7Cj4gQEAgLTI2NDksOSArMjY1Niw5IEBA
IGVudW0gaW50ZWxfZHBsbF9pZCBpY2xfdGNfcG9ydF90b19wbGxfaWQoZW51bSB0Y19wb3J0IHRj
X3BvcnQpCj4gIAlyZXR1cm4gdGNfcG9ydCArIERQTExfSURfSUNMX01HUExMMTsKPiAgfQo+ICAK
PiAtYm9vbCBpbnRlbF9kcGxsX2lzX2NvbWJvcGh5KGVudW0gaW50ZWxfZHBsbF9pZCBpZCkKPiAr
c3RhdGljIGVudW0gaWNsX2RwbGxfZmxhZ3MgaWNsX2RwbGxfdHlwZShjb25zdCBzdHJ1Y3QgZHBs
bF9pbmZvICppbmZvKQo+ICB7Cj4gLQlyZXR1cm4gaWQgPT0gRFBMTF9JRF9JQ0xfRFBMTDAgfHwg
aWQgPT0gRFBMTF9JRF9JQ0xfRFBMTDE7Cj4gKwlyZXR1cm4gaW5mby0+cGxhdGZvcm1fZmxhZ3Mg
JiBfSUNMX0RQTExfVFlQRV9NQVNLOwo+ICB9Cj4gIAo+ICBzdGF0aWMgYm9vbCBpY2xfbWdfcGxs
X2ZpbmRfZGl2aXNvcnMoaW50IGNsb2NrX2toeiwgYm9vbCBpc19kcCwgYm9vbCB1c2Vfc3NjLAo+
IEBAIC0yOTU2LDE0ICsyOTYzLDIyIEBAIGljbF9nZXRfZHBsbChzdHJ1Y3QgaW50ZWxfY3J0YyAq
Y3J0Yywgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gIAlyZXR1cm4gcGxs
Owo+ICB9Cj4gIAo+IC1zdGF0aWMgaTkxNV9yZWdfdCBpY2xfcGxsX2lkX3RvX2VuYWJsZV9yZWco
ZW51bSBpbnRlbF9kcGxsX2lkIGlkKQo+ICtzdGF0aWMgaTkxNV9yZWdfdAo+ICtpY2xfcGxsX2lu
Zm9fdG9fZW5hYmxlX3JlZyhjb25zdCBzdHJ1Y3QgZHBsbF9pbmZvICppbmZvKQo+ICB7Cj4gLQlp
ZiAoaW50ZWxfZHBsbF9pc19jb21ib3BoeShpZCkpCj4gLQkJcmV0dXJuIENOTF9EUExMX0VOQUJM
RShpZCk7Cj4gLQllbHNlIGlmIChpZCA9PSBEUExMX0lEX0lDTF9UQlRQTEwpCj4gLQkJcmV0dXJu
IFRCVF9QTExfRU5BQkxFOwo+ICsJZW51bSBpY2xfZHBsbF9mbGFncyB0eXBlID0gaWNsX2RwbGxf
dHlwZShpbmZvKTsKPiAgCj4gLQlyZXR1cm4gTUdfUExMX0VOQUJMRShpY2xfcGxsX2lkX3RvX3Rj
X3BvcnQoaWQpKTsKPiArCXN3aXRjaCAodHlwZSkgewo+ICsJY2FzZSBJQ0xfRFBMTF9UWVBFX0NP
TUJPUEhZOgo+ICsJCXJldHVybiBDTkxfRFBMTF9FTkFCTEUoaW5mby0+aWQpOwo+ICsJY2FzZSBJ
Q0xfRFBMTF9UWVBFX1RCVDoKPiArCQlyZXR1cm4gVEJUX1BMTF9FTkFCTEU7Cj4gKwljYXNlIElD
TF9EUExMX1RZUEVfTUc6Cj4gKwkJcmV0dXJuIE1HX1BMTF9FTkFCTEUoaWNsX3BsbF9pZF90b190
Y19wb3J0KGluZm8tPmlkKSk7Cj4gKwlkZWZhdWx0Ogo+ICsJCU1JU1NJTkdfQ0FTRSh0eXBlKTsK
PiArCQlyZXR1cm4gQ05MX0RQTExfRU5BQkxFKGluZm8tPmlkKTsKPiArCX0KPiAgfQoKVGhpcyBz
ZWVtcyBhIHJhdGhlciByb3VuZGFib3V0IHdheSBvZiBkb2luZyB0aGluZ3Mgd2hlbiB3ZSBhbHJl
YWR5IGhhdmUKdGhlIHZmdW5jcy4KCkhvdyBhYm91dCBqdXN0OgoKbWdfcGxsX2VuYWJsZSgpCnsK
CWljbF9wbGxfZW5hYmxlKE1HX1JFRyk7Cn0KCmNvbWJvX3BsbF9lbmFibGUoKQp7CglpY2xfcGxs
X2VuYWJsZShDT01CT19SRUcpOwp9CgpvciBzb21ldGhpbmcgYWxvbmcgdGhvc2UgbGluZXMuCgoK
PiAgCj4gIHN0YXRpYyBib29sIG1nX3BsbF9nZXRfaHdfc3RhdGUoc3RydWN0IGRybV9pOTE1X3By
aXZhdGUgKmRldl9wcml2LAo+IEBAIC0zMDQyLDcgKzMwNTcsNyBAQCBzdGF0aWMgYm9vbCBpY2xf
cGxsX2dldF9od19zdGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAlp
ZiAoIXdha2VyZWYpCj4gIAkJcmV0dXJuIGZhbHNlOwo+ICAKPiAtCXZhbCA9IEk5MTVfUkVBRChp
Y2xfcGxsX2lkX3RvX2VuYWJsZV9yZWcoaWQpKTsKPiArCXZhbCA9IEk5MTVfUkVBRChpY2xfcGxs
X2luZm9fdG9fZW5hYmxlX3JlZyhwbGwtPmluZm8pKTsKPiAgCWlmICghKHZhbCAmIFBMTF9FTkFC
TEUpKQo+ICAJCWdvdG8gb3V0Owo+ICAKPiBAQCAtMzEyMCw3ICszMTM1LDggQEAgc3RhdGljIHZv
aWQgaWNsX3BsbF9lbmFibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJ
CQkgICBzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBsbCkKPiAgewo+ICAJY29uc3QgZW51bSBp
bnRlbF9kcGxsX2lkIGlkID0gcGxsLT5pbmZvLT5pZDsKPiAtCWk5MTVfcmVnX3QgZW5hYmxlX3Jl
ZyA9IGljbF9wbGxfaWRfdG9fZW5hYmxlX3JlZyhpZCk7Cj4gKwllbnVtIGljbF9kcGxsX2ZsYWdz
IHR5cGUgPSBpY2xfZHBsbF90eXBlKHBsbC0+aW5mbyk7Cj4gKwlpOTE1X3JlZ190IGVuYWJsZV9y
ZWcgPSBpY2xfcGxsX2luZm9fdG9fZW5hYmxlX3JlZyhwbGwtPmluZm8pOwo+ICAJdTMyIHZhbDsK
PiAgCj4gIAl2YWwgPSBJOTE1X1JFQUQoZW5hYmxlX3JlZyk7Cj4gQEAgLTMxMzUsNyArMzE1MSw3
IEBAIHN0YXRpYyB2b2lkIGljbF9wbGxfZW5hYmxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk
ZXZfcHJpdiwKPiAgCQkJCSAgICBQTExfUE9XRVJfU1RBVEUsIDEpKQo+ICAJCURSTV9FUlJPUigi
UExMICVkIFBvd2VyIG5vdCBlbmFibGVkXG4iLCBpZCk7Cj4gIAo+IC0JaWYgKGludGVsX2RwbGxf
aXNfY29tYm9waHkoaWQpIHx8IGlkID09IERQTExfSURfSUNMX1RCVFBMTCkKPiArCWlmICh0eXBl
ID09IElDTF9EUExMX1RZUEVfQ09NQk9QSFkgfHwgdHlwZSA9PSBJQ0xfRFBMTF9UWVBFX1RCVCkK
PiAgCQlpY2xfZHBsbF93cml0ZShkZXZfcHJpdiwgcGxsKTsKPiAgCWVsc2UKPiAgCQlpY2xfbWdf
cGxsX3dyaXRlKGRldl9wcml2LCBwbGwpOwo+IEBAIC0zMTYxLDcgKzMxNzcsNyBAQCBzdGF0aWMg
dm9pZCBpY2xfcGxsX2Rpc2FibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+
ICAJCQkgICAgc3RydWN0IGludGVsX3NoYXJlZF9kcGxsICpwbGwpCj4gIHsKPiAgCWNvbnN0IGVu
dW0gaW50ZWxfZHBsbF9pZCBpZCA9IHBsbC0+aW5mby0+aWQ7Cj4gLQlpOTE1X3JlZ190IGVuYWJs
ZV9yZWcgPSBpY2xfcGxsX2lkX3RvX2VuYWJsZV9yZWcoaWQpOwo+ICsJaTkxNV9yZWdfdCBlbmFi
bGVfcmVnID0gaWNsX3BsbF9pbmZvX3RvX2VuYWJsZV9yZWcocGxsLT5pbmZvKTsKPiAgCXUzMiB2
YWw7Cj4gIAo+ICAJLyogVGhlIGZpcnN0IHN0ZXBzIGFyZSBkb25lIGJ5IGludGVsX2RkaV9wb3N0
X2Rpc2FibGUoKS4gKi8KPiBAQCAtMzIzMCwxMyArMzI0NiwxMyBAQCBzdGF0aWMgY29uc3Qgc3Ry
dWN0IGludGVsX3NoYXJlZF9kcGxsX2Z1bmNzIG1nX3BsbF9mdW5jcyA9IHsKPiAgfTsKPiAgCj4g
IHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHBsbF9pbmZvIGljbF9wbGxzW10gPSB7Cj4gLQl7ICJEUExM
IDAiLCAgICZpY2xfcGxsX2Z1bmNzLCBEUExMX0lEX0lDTF9EUExMMCwgIDAgfSwKPiAtCXsgIkRQ
TEwgMSIsICAgJmljbF9wbGxfZnVuY3MsIERQTExfSURfSUNMX0RQTEwxLCAgMCB9LAo+IC0JeyAi
VEJUIFBMTCIsICAmaWNsX3BsbF9mdW5jcywgRFBMTF9JRF9JQ0xfVEJUUExMLCAwIH0sCj4gLQl7
ICJNRyBQTEwgMSIsICZtZ19wbGxfZnVuY3MsIERQTExfSURfSUNMX01HUExMMSwgMCB9LAo+IC0J
eyAiTUcgUExMIDIiLCAmbWdfcGxsX2Z1bmNzLCBEUExMX0lEX0lDTF9NR1BMTDIsIDAgfSwKPiAt
CXsgIk1HIFBMTCAzIiwgJm1nX3BsbF9mdW5jcywgRFBMTF9JRF9JQ0xfTUdQTEwzLCAwIH0sCj4g
LQl7ICJNRyBQTEwgNCIsICZtZ19wbGxfZnVuY3MsIERQTExfSURfSUNMX01HUExMNCwgMCB9LAo+
ICsJeyAiRFBMTCAwIiwgICAmaWNsX3BsbF9mdW5jcywgRFBMTF9JRF9JQ0xfRFBMTDAsIDAsIElD
TF9EUExMX1RZUEVfQ09NQk9QSFkgfSwKPiArCXsgIkRQTEwgMSIsICAgJmljbF9wbGxfZnVuY3Ms
IERQTExfSURfSUNMX0RQTEwxLCAwLCBJQ0xfRFBMTF9UWVBFX0NPTUJPUEhZIH0sCj4gKwl7ICJU
QlQgUExMIiwgICZpY2xfcGxsX2Z1bmNzLCBEUExMX0lEX0lDTF9UQlRQTEwsIDAsIElDTF9EUExM
X1RZUEVfVEJUIH0sCj4gKwl7ICJNRyBQTEwgMSIsICZtZ19wbGxfZnVuY3MsIERQTExfSURfSUNM
X01HUExMMSwgMCwgSUNMX0RQTExfVFlQRV9NRyB9LAo+ICsJeyAiTUcgUExMIDIiLCAmbWdfcGxs
X2Z1bmNzLCBEUExMX0lEX0lDTF9NR1BMTDIsIDAsIElDTF9EUExMX1RZUEVfTUcgfSwKPiArCXsg
Ik1HIFBMTCAzIiwgJm1nX3BsbF9mdW5jcywgRFBMTF9JRF9JQ0xfTUdQTEwzLCAwLCBJQ0xfRFBM
TF9UWVBFX01HIH0sCj4gKwl7ICJNRyBQTEwgNCIsICZtZ19wbGxfZnVuY3MsIERQTExfSURfSUNM
X01HUExMNCwgMCwgSUNMX0RQTExfVFlQRV9NRyB9LAo+ICAJeyB9LAo+ICB9Owo+ICAKPiBkaWZm
IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaCBiL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmgKPiBpbmRleCBiMWZkY2UxYmU5NDIuLjEyZmZl
ODM1OThhYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21n
ci5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaAo+IEBAIC0z
NTIsNiArMzUyLDUgQEAgaW50IGljbF9jYWxjX2RwX2NvbWJvX3BsbF9saW5rKHN0cnVjdCBkcm1f
aTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJICAgICAgIHUzMiBwbGxfaWQpOwo+ICBpbnQg
Y25sX2hkbWlfcGxsX3JlZl9jbG9jayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp
Owo+ICBlbnVtIGludGVsX2RwbGxfaWQgaWNsX3RjX3BvcnRfdG9fcGxsX2lkKGVudW0gdGNfcG9y
dCB0Y19wb3J0KTsKPiAtYm9vbCBpbnRlbF9kcGxsX2lzX2NvbWJvcGh5KGVudW0gaW50ZWxfZHBs
bF9pZCBpZCk7Cj4gIAo+ICAjZW5kaWYgLyogX0lOVEVMX0RQTExfTUdSX0hfICovCj4gLS0gCj4g
Mi4yMC4wCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w
Lm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50
ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4
QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls
bWFuL2xpc3RpbmZvL2ludGVsLWdmeA==