All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 3.18, 4.4] libceph: handle an empty authorize reply
Date: Mon, 25 Feb 2019 22:02:28 +0100	[thread overview]
Message-ID: <20190225210228.GC12242@kroah.com> (raw)
In-Reply-To: <20190225201206.30079-1-idryomov@gmail.com>

On Mon, Feb 25, 2019 at 09:12:06PM +0100, Ilya Dryomov wrote:
> The authorize reply can be empty, for example when the ticket used to
> build the authorizer is too old and TAG_BADAUTHORIZER is returned from
> the service.  Calling ->verify_authorizer_reply() results in an attempt
> to decrypt and validate (somewhat) random data in au->buf (most likely
> the signature block from calc_signature()), which fails and ends up in
> con_fault_finish() with !con->auth_retry.  The ticket isn't invalidated
> and the connection is retried again and again until a new ticket is
> obtained from the monitor:
> 
>   libceph: osd2 192.168.122.1:6809 bad authorize reply
>   libceph: osd2 192.168.122.1:6809 bad authorize reply
>   libceph: osd2 192.168.122.1:6809 bad authorize reply
>   libceph: osd2 192.168.122.1:6809 bad authorize reply
> 
> Let TAG_BADAUTHORIZER handler kick in and increment con->auth_retry.
> 
> Cc: stable@vger.kernel.org
> Fixes: 5c056fdc5b47 ("libceph: verify authorize reply on connect")
> Link: https://tracker.ceph.com/issues/20164
> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
> Reviewed-by: Sage Weil <sage@redhat.com>
> [idryomov@gmail.com: backport to 4.4: extra arg, no CEPHX_V2]
> ---
>  net/ceph/messenger.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)

What is the git commit id of this patch in Linus's tree?

thanks,

greg k-h

  reply	other threads:[~2019-02-25 21:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25 20:12 [PATCH 3.18, 4.4] libceph: handle an empty authorize reply Ilya Dryomov
2019-02-25 21:02 ` Greg KH [this message]
2019-02-26  9:39   ` Ilya Dryomov
2019-02-27 14:13     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190225210228.GC12242@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=idryomov@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.