From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/2] USB: gadget: pxa25x: Add DT bindings From: Rob Herring Message-Id: <20190225212354.GA9627@bogus> Date: Mon, 25 Feb 2019 15:23:54 -0600 To: Linus Walleij Cc: Greg Kroah-Hartman , Felipe Balbi , linux-usb@vger.kernel.org, Robert Jarzmik , devicetree@vger.kernel.org List-ID: T24gU3VuLCBGZWIgMDMsIDIwMTkgYXQgMTI6NTk6MDdBTSArMDEwMCwgTGludXMgV2FsbGVpaiB3 cm90ZToKPiBUaGlzIGFkZHMgZGV2aWNlIHRyZWUgYmluZGluZ3MgZm9yIHRoZSBQWEEyNXggVVNC IERldmljZQo+IENvbnRyb2xsZXIgYXMgZm91bmQgaW4gdGhlIFBYQTI1eCBhbmQgdGhlIElYUDR4 eC4KPiAKPiBDYzogUm9iZXJ0IEphcnptaWsgPHJvYmVydC5qYXJ6bWlrQGZyZWUuZnI+Cj4gQ2M6 IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnCj4gU2lnbmVkLW9mZi1ieTogTGludXMgV2FsbGVp aiA8bGludXMud2FsbGVpakBsaW5hcm8ub3JnPgo+IC0tLQo+ICAuLi4vZGV2aWNldHJlZS9iaW5k aW5ncy91c2IvcHhhMjV4LXVkYy50eHQgICAgfCAyNyArKysrKysrKysrKysrKysrKysrCj4gIDEg ZmlsZSBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL3B4YTI1eC11ZGMudHh0Cj4gCj4gZGlm ZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvcHhhMjV4LXVk Yy50eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL3B4YTI1eC11ZGMu dHh0Cj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAuLmJiZGJlMGRm MzU2NQo+IC0tLSAvZGV2L251bGwKPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvdXNiL3B4YTI1eC11ZGMudHh0Cj4gQEAgLTAsMCArMSwyNyBAQAo+ICtQWEEyNXggVURD IChVU0IgRGV2aWNlIENvbnRyb2xsZXIpCj4gKwo+ICtUaGUgUFhBMjV4IGFuZCBJWFA0eHggVVNC IERldmljZSBDb250cm9sbGVyIGlzIGRpZmZlcmVudCBmcm9tIHRoZQo+ICtQWEEyN3ggVURDIGRl c2NyaWJlZCBpbiBweGEtdXNiLnR4dCBhbmQgaXMgY29tcGF0aWJsZSBiZXR3ZWVuIHRoZQo+ICtN YXJ2ZWxsIFBYQTI1eCBhbmQgdGhlIEludGVsIElYUDR4eCBkZXZpY2VzLgo+ICsKPiArUmVxdWly ZWQgcHJvcGVydGllczoKPiArIC0gY29tcGF0aWJsZTogU2hvdWxkIGJlIG9uZSBvZgo+ICsgICAi bWFydmVsbCxweGEyNXgtdWRjIgoKTG9vayBhdCB0aGUgJ2hhc19jZnInIGZsYWcgaW4gdGhlIGRy aXZlci4gWW91IHNob3VsZCBoYXZlIDI1MCBhbmQgMjU1IApjb21wYXRpYmxlIHN0cmluZ3MgdG8g ZGlzdGluZ3Vpc2guIFRoYXQgd291bGQgZ2V0IHJpZCBvZiB0aGUgYXNzZW1ibHkgCmluc3RydWN0 aW9uIGhlbHBpbmcgdG93YXJkcyBidWlsZGluZyBvbiAhQVJNLgoKPiArICAgImludGVsLGl4cDR4 eC11ZGMiCj4gKyAgIGZvciBVU0IgY29udHJvbGxlcnMgdXNlZCBpbiBkZXZpY2UgbW9kZS4KPiAr IC0gcmVnOiB1c2IgZGV2aWNlIE1NSU8gYWRkcmVzcyBzcGFjZQo+ICsgLSBpbnRlcnJ1cHRzOiBz aW5nbGUgaW50ZXJydXB0IGdlbmVyYXRlZCBieSB0aGUgVURDIElQCj4gKyAtIGNsb2NrczogaW5w dXQgY2xvY2sgb2YgdGhlIFVEQyBJUCAoc2VlIGNsb2NrLWJpbmRpbmdzLnR4dCkKPiArCj4gK09w dGlvbmFsIHByb3BlcnRpZXM6Cj4gKyAtIGdwaW9zOgo+ICsgICAtIGdwaW8gYWN0aXZhdGVkIHRv IGNvbnRyb2wgdGhlIFVTQiBEKyBwdWxsdXAgKHNlZSBncGlvLnR4dCkKClRoaXMgcmVhbGx5IHNo b3VsZCBiZSBwYXJ0IG9mIGEgY29ubmVjdG9yLiBBbHNvLCB0aGUgTHViYm9jayBib2FyZCBpcyAK ZGlmZmVyZW50LgoKPiArCj4gK0V4YW1wbGU6Cj4gKwo+ICt1c2JAYzgwMGIwMDAgewo+ICsJY29t cGF0aWJsZSA9ICJpbnRlbCxpeHA0eHgtdWRjIjsKPiArCXJlZyA9IDwweGM4MDBiMDAwIDB4MTAw MD47Cj4gKwlpbnRlcnJ1cHRzID0gPDEyIElSUV9UWVBFX0xFVkVMX0hJR0g+Owo+ICsJY2xvY2tz ID0gPCZwY2xrIDA+Owo+ICt9Owo+IC0tIAo+IDIuMjAuMQo+Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 25 Feb 2019 15:23:54 -0600 From: Rob Herring Subject: Re: [PATCH 1/2] USB: gadget: pxa25x: Add DT bindings Message-ID: <20190225212354.GA9627@bogus> References: <20190202235908.30751-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190202235908.30751-1-linus.walleij@linaro.org> To: Linus Walleij Cc: Greg Kroah-Hartman , Felipe Balbi , linux-usb@vger.kernel.org, Robert Jarzmik , devicetree@vger.kernel.org List-ID: On Sun, Feb 03, 2019 at 12:59:07AM +0100, Linus Walleij wrote: > This adds device tree bindings for the PXA25x USB Device > Controller as found in the PXA25x and the IXP4xx. > > Cc: Robert Jarzmik > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij > --- > .../devicetree/bindings/usb/pxa25x-udc.txt | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/pxa25x-udc.txt > > diff --git a/Documentation/devicetree/bindings/usb/pxa25x-udc.txt b/Documentation/devicetree/bindings/usb/pxa25x-udc.txt > new file mode 100644 > index 000000000000..bbdbe0df3565 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/pxa25x-udc.txt > @@ -0,0 +1,27 @@ > +PXA25x UDC (USB Device Controller) > + > +The PXA25x and IXP4xx USB Device Controller is different from the > +PXA27x UDC described in pxa-usb.txt and is compatible between the > +Marvell PXA25x and the Intel IXP4xx devices. > + > +Required properties: > + - compatible: Should be one of > + "marvell,pxa25x-udc" Look at the 'has_cfr' flag in the driver. You should have 250 and 255 compatible strings to distinguish. That would get rid of the assembly instruction helping towards building on !ARM. > + "intel,ixp4xx-udc" > + for USB controllers used in device mode. > + - reg: usb device MMIO address space > + - interrupts: single interrupt generated by the UDC IP > + - clocks: input clock of the UDC IP (see clock-bindings.txt) > + > +Optional properties: > + - gpios: > + - gpio activated to control the USB D+ pullup (see gpio.txt) This really should be part of a connector. Also, the Lubbock board is different. > + > +Example: > + > +usb@c800b000 { > + compatible = "intel,ixp4xx-udc"; > + reg = <0xc800b000 0x1000>; > + interrupts = <12 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&pclk 0>; > +}; > -- > 2.20.1 >