From: Rob Herring <robh@kernel.org>
To: Artur Rojek <contact@artur-rojek.eu>
Cc: Sebastian Reichel <sre@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Paul Cercueil <paul@crapouillou.net>
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: gpio-charger: Add status-gpios property
Date: Mon, 25 Feb 2019 15:53:17 -0600 [thread overview]
Message-ID: <20190225215316.GA10117@bogus> (raw)
In-Reply-To: <20190205190316.19296-1-contact@artur-rojek.eu>
On Tue, Feb 05, 2019 at 08:03:15PM +0100, Artur Rojek wrote:
> Add documentation for the "status-gpios" property.
>
> Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
> ---
> .../devicetree/bindings/power/supply/gpio-charger.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/gpio-charger.txt b/Documentation/devicetree/bindings/power/supply/gpio-charger.txt
> index adbb5dc5b6e9..b98a05a4973c 100644
> --- a/Documentation/devicetree/bindings/power/supply/gpio-charger.txt
> +++ b/Documentation/devicetree/bindings/power/supply/gpio-charger.txt
> @@ -14,12 +14,16 @@ Required properties :
> usb-cdp (USB charging downstream port)
> usb-aca (USB accessory charger adapter)
>
> +Optional properties:
> + - status-gpios: GPIO indicating the charger status
So when it is asserted it has 'status'? What does status mean?
> +
> Example:
>
> usb_charger: charger {
> compatible = "gpio-charger";
> charger-type = "usb-sdp";
> gpios = <&gpf0 2 0 0 0>;
> + status-gpios = <&gpf0 3 0 0 0>;
Humm, not sure what the thinking for 'gpios' was, but it's wrong and you
just copied it. If we follow the normal cell encoding with 2 cells, this
means the property takes 3 gpios (though the last 2 are marked not
present with 0).
Rob
next prev parent reply other threads:[~2019-02-25 21:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 19:03 [PATCH 1/2] dt-bindings: power: supply: gpio-charger: Add status-gpios property Artur Rojek
2019-02-05 19:03 ` [PATCH 2/2] power: supply: gpio-charger: Add support for charger status Artur Rojek
2019-02-25 21:53 ` Rob Herring [this message]
2019-02-26 14:40 ` [PATCH 1/2] dt-bindings: power: supply: gpio-charger: Add status-gpios property Artur Rojek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225215316.GA10117@bogus \
--to=robh@kernel.org \
--cc=contact@artur-rojek.eu \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paul@crapouillou.net \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.