From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43027C43381 for ; Tue, 26 Feb 2019 09:09:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 086C42083D for ; Tue, 26 Feb 2019 09:09:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="Sj56OMP7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727295AbfBZJJC (ORCPT ); Tue, 26 Feb 2019 04:09:02 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:35057 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726223AbfBZJJB (ORCPT ); Tue, 26 Feb 2019 04:09:01 -0500 Received: by mail-wr1-f65.google.com with SMTP id t18so13022338wrx.2 for ; Tue, 26 Feb 2019 01:09:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5FuD5aQ/EfOz1rg6bdNC92rKMI0UNGRvOM0F/KC/mds=; b=Sj56OMP7jRhyGXjCDuX9QIWCDji7u98epWQLPd3iTKNyl0AzOCJWfpJcn1ck+Prrxx zhF2SYuXheyravTudoc59vwn62phwvH54wYcGXdt7maENY+ZJ5QamS4pEe6cr5I1s7SK de4D9rJd78MFOoQ4Pe04dq7PRLkZAeHNYWeXAu93C/cimnN4z0jXlX8ObcojqbwQ+dbX c6kBwBp+f8vNrldZZGnp120x+lBtgyfgWQR8sBrx4CBoB2tYDmChrwyeNaYqEHoh9ShM JBkw66+bsC49rQCrpJfHWIvshoYzAFcmPgi+dzg2QbTncTcSRb0eZ3KL8k4NY3otfPwB lkFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5FuD5aQ/EfOz1rg6bdNC92rKMI0UNGRvOM0F/KC/mds=; b=PP9VYG1GGP+7esSI03dtqClYXVIL6/BQKZ8bZg19AGU3ZBM3eMa+CETqAjc1h3AEdF NVVUUtKXbAqiv4VxEln3IXYAGZ3Zc5fb6DEJxe2amGioCfjhECfqDmj0+vFX1i5bWqy0 z+cdgRDzdsOeQl8X4KbUFICae1ajKoIBYbiHTRuGzFlGG6J+tHjM3VilGByJKnF/QUmu Elkjl+RkbfkzYRVSgARBw5razJTa8eUWuPWgQ6hRKlHJznlH/qJVcaoVD/vDk5AauYQn PoDLQYnMRZwR5lcTR+X7gQgfJrWsQOw1Obhx0zpl1qmdrHVDKvclYscM04VoRlzfIP4R Yc6A== X-Gm-Message-State: AHQUAuZ0amyDNlCgvN4gvKo07LT1YyKb9MFnxITGieIYnSx9W0Y8O++2 PR+Hqci9fleqGmqD5OQhoJgGCA== X-Google-Smtp-Source: AHgI3IZSoQYEAn6Pat7YKbvrrsU2f5bqtQatYqpvm3aPJkHmDHVyCgCVL73uOXBaY+rqair7yGKK8g== X-Received: by 2002:adf:f543:: with SMTP id j3mr15001997wrp.220.1551172140033; Tue, 26 Feb 2019 01:09:00 -0800 (PST) Received: from localhost ([2001:718:603:100a:93d:1bfc:765a:ba68]) by smtp.gmail.com with ESMTPSA id o14sm7873548wrp.34.2019.02.26.01.08.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Feb 2019 01:08:59 -0800 (PST) Date: Tue, 26 Feb 2019 09:59:09 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, mkubecek@suse.cz, andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next v4 6/6] devlink: require non-NULL ops for devlink instances Message-ID: <20190226085909.GD5451@nanopsycho> References: <20190226033407.32625-1-jakub.kicinski@netronome.com> <20190226033407.32625-7-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190226033407.32625-7-jakub.kicinski@netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, Feb 26, 2019 at 04:34:07AM CET, jakub.kicinski@netronome.com wrote: >Commit 76726ccb7f46 ("devlink: add flash update command") and >commit 2d8dc5bbf4e7 ("devlink: Add support for reload") >access devlink ops without NULL-checking. There is, however, no >driver which would pass in NULL ops, so let's just make that >a requirement. Remove the now unnecessary NULL-checking. > >Signed-off-by: Jakub Kicinski Acked-by: Jiri Pirko Thanks Kuba!