From: Joerg Roedel <joro@8bytes.org>
To: Julia Cartwright <julia@ni.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>
Subject: Re: [PATCH] iommu/dmar: fix buffer overflow during PCI bus notification
Date: Tue, 26 Feb 2019 11:25:27 +0100 [thread overview]
Message-ID: <20190226102527.GF20740@8bytes.org> (raw)
In-Reply-To: <20190220191744.GC1076@jcartwri.amer.corp.natinst.com>
On Wed, Feb 20, 2019 at 07:17:45PM +0000, Julia Cartwright wrote:
> On Wed, Feb 20, 2019 at 10:46:31AM -0600, Julia Cartwright wrote:
> > - size = sizeof(*info) + level * sizeof(struct acpi_dmar_pci_path);
> > + size = sizeof(*info) + level * sizeof(info->path[0]);
>
> This is probably a candidate for struct_size() instead, if that's what
> is preferred.
No, patch is fine as-is. Thanks a lot, applied to iommu/fixes branch.
Joerg
prev parent reply other threads:[~2019-02-26 10:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 16:46 [PATCH] iommu/dmar: fix buffer overflow during PCI bus notification Julia Cartwright
2019-02-20 19:17 ` Julia Cartwright
2019-02-26 10:25 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226102527.GF20740@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=julia@ni.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.