From: Joerg Roedel <joro@8bytes.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Alex Williamson <alex.williamson@redhat.com>,
Kirti Wankhede <kwankhede@nvidia.com>,
ashok.raj@intel.com, sanjay.k.kumar@intel.com,
jacob.jun.pan@intel.com, kevin.tian@intel.com,
Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
yi.l.liu@intel.com, yi.y.sun@intel.com, peterx@redhat.com,
tiwei.bie@intel.com, xin.zeng@intel.com,
iommu@lists.linux-foundation.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 0/9] vfio/mdev: IOMMU aware mediated device
Date: Tue, 26 Feb 2019 11:37:08 +0100 [thread overview]
Message-ID: <20190226103707.GG20740@8bytes.org> (raw)
In-Reply-To: <20190222021927.13132-1-baolu.lu@linux.intel.com>
On Fri, Feb 22, 2019 at 10:19:18AM +0800, Lu Baolu wrote:
> Lu Baolu (9):
> iommu: Add APIs for multiple domains per device
> iommu/vt-d: Move enable pasid out of CONFIG_INTEL_IOMMU_SVM
> iommu/vt-d: Add per-device IOMMU feature ops entries
> iommu/vt-d: Move common code out of iommu_attch_device()
> iommu/vt-d: Aux-domain specific domain attach/detach
> iommu/vt-d: Return ID associated with an auxiliary domain
> vfio/mdev: Add iommu related member in mdev_device
> vfio/type1: Add domain at(de)taching group helpers
> vfio/type1: Handle different mdev isolation type
This looks mostly good to me from an IOMMU point of view. I have some
ideas for improving it further, but that can be left for later work. For
example, I wonder if it makes sense to track the enabled/disabled state
for features in core iommu code to safe the call-backs into the
iommu-drivers for the is_enabled checks.
When Alex Acks the vfio changes I am inclined to merge this for v5.1.
Regards,
Joerg
prev parent reply other threads:[~2019-02-26 10:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 2:19 [PATCH v7 0/9] vfio/mdev: IOMMU aware mediated device Lu Baolu
2019-02-22 2:19 ` [PATCH v7 1/9] iommu: Add APIs for multiple domains per device Lu Baolu
2019-02-22 2:19 ` [PATCH v7 2/9] iommu/vt-d: Move enable pasid out of CONFIG_INTEL_IOMMU_SVM Lu Baolu
2019-02-22 2:19 ` [PATCH v7 3/9] iommu/vt-d: Add per-device IOMMU feature ops entries Lu Baolu
2019-02-22 2:19 ` [PATCH v7 4/9] iommu/vt-d: Move common code out of iommu_attch_device() Lu Baolu
2019-02-22 2:19 ` [PATCH v7 5/9] iommu/vt-d: Aux-domain specific domain attach/detach Lu Baolu
2019-02-22 2:19 ` [PATCH v7 6/9] iommu/vt-d: Return ID associated with an auxiliary domain Lu Baolu
2019-02-22 2:19 ` [PATCH v7 7/9] vfio/mdev: Add iommu related member in mdev_device Lu Baolu
2019-02-22 14:34 ` Christoph Hellwig
2019-02-22 15:31 ` Alex Williamson
2019-02-22 2:19 ` [PATCH v7 8/9] vfio/type1: Add domain at(de)taching group helpers Lu Baolu
2019-03-26 9:33 ` Kirti Wankhede
2019-03-26 9:33 ` Kirti Wankhede
2019-02-22 2:19 ` [PATCH v7 9/9] vfio/type1: Handle different mdev isolation type Lu Baolu
[not found] ` <20190222021927.13132-10-baolu.lu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2019-03-07 8:44 ` Neo Jia
2019-03-07 8:44 ` Neo Jia
2019-03-07 23:56 ` Alex Williamson
2019-03-07 23:56 ` Alex Williamson
2019-03-08 18:03 ` Neo Jia
2019-03-08 18:03 ` Neo Jia
2019-03-20 5:52 ` Lu Baolu
2019-02-26 10:37 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226103707.GG20740@8bytes.org \
--to=joro@8bytes.org \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=jean-philippe.brucker@arm.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterx@redhat.com \
--cc=sanjay.k.kumar@intel.com \
--cc=tiwei.bie@intel.com \
--cc=xin.zeng@intel.com \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.