Re: [PATCH] Staging: rtlwifi: rtl8822be: Use __func__ instead of func name

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Tue, Feb 26, 2019 at 05:52:43AM +0530, Bhanusree Pola wrote:
> Fix checkpatch warning:
> WARNING: Prefer using '"%s...", __func__' to using 'rtl8822be_set_fw_rsvdpagepkt', this function's name, in a string
> 
> Use __func__ instead of using complete function name.
> Avoid line over 80 characters
> 
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
>  drivers/staging/rtlwifi/rtl8822be/fw.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtlwifi/rtl8822be/fw.c b/drivers/staging/rtlwifi/rtl8822be/fw.c
> index f061dd1382aa..43a56962e37a 100644
> --- a/drivers/staging/rtlwifi/rtl8822be/fw.c
> +++ b/drivers/staging/rtlwifi/rtl8822be/fw.c
> @@ -736,10 +736,10 @@ void rtl8822be_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished)
>  	totalpacketlen = TOTAL_RESERVED_PKT_LEN;
>  
>  	RT_PRINT_DATA(rtlpriv, COMP_CMD, DBG_LOUD,
> -		      "rtl8822be_set_fw_rsvdpagepkt(): HW_VAR_SET_TX_CMD: ALL\n",
> +		      ("%s: HW_VAR_SET_TX_CMD: ALL\n", __func__),

You did not even compile your change :(

This is not correct C, please fix up and always test your patches before
sending them out.

thanks,

greg k-h