From: Boris Brezillon <boris.brezillon@collabora.com>
To: Przemyslaw Gaj <pgaj@cadence.com>
Cc: linux-i3c@lists.infradead.org, rafalc@cadence.com,
vitor.soares@synopsys.com
Subject: Re: [PATCH 1/3] i3c: Drop support for I2C 10 bit addresing
Date: Tue, 26 Feb 2019 13:11:43 +0100 [thread overview]
Message-ID: <20190226131143.05ee3987@collabora.com> (raw)
In-Reply-To: <20190226110003.5909-2-pgaj@cadence.com>
On Tue, 26 Feb 2019 11:00:01 +0000
Przemyslaw Gaj <pgaj@cadence.com> wrote:
> This patch dropps support for I2C devices with 10 bit addressing. When I2C
> device with 10 bit address is defined in DT, I3C master registration fails.
>
> Signed-off-by: Przemyslaw Gaj <pgaj@cadence.com>
> ---
> drivers/i3c/master.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 2dc628d..6c7fa4b 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -1962,6 +1962,13 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
> if (ret)
> return ret;
>
> + /* The I3C Specification does not clearly say I2C devices with 10-bit
> + * address are supported. These devices can't be passed properly through
> + * DEFSLVS command.
> + */
> + if (boardinfo->base.flags & I2C_CLIENT_TEN)
Please add a dev_err() here so that the user knows why it failed.
The rest of the series looks good.
> + return -ENOTSUPP;
> +
> /* LVR is encoded in reg[2]. */
> boardinfo->lvr = reg[2];
>
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2019-02-26 12:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 11:00 [PATCH 0/3] Drop support for I2C 10 bit devices from I3C subsystem Przemyslaw Gaj
2019-02-26 11:00 ` [PATCH 1/3] i3c: Drop support for I2C 10 bit addresing Przemyslaw Gaj
2019-02-26 12:11 ` Boris Brezillon [this message]
2019-02-26 11:00 ` [PATCH 2/3] i3c: master: cdns: Drop support for I2C 10 bit addresing in Cadence I3C master Przemyslaw Gaj
2019-02-26 11:00 ` [PATCH 3/3] dt-bindings: i3c: Document dropped support for I2C 10 bit devices Przemyslaw Gaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226131143.05ee3987@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=linux-i3c@lists.infradead.org \
--cc=pgaj@cadence.com \
--cc=rafalc@cadence.com \
--cc=vitor.soares@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.