From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v1] mpt3sas: Use driver scsi lookup to track outstanding IOs Date: Tue, 26 Feb 2019 06:33:13 -0800 Message-ID: <20190226143313.GA23865@infradead.org> References: <1550751105-46065-1-git-send-email-sreekanth.reddy@broadcom.com> <61a8f703-3f20-b777-08b9-54ae34dffa59@suse.de> <0dfb09ca-8723-3a3c-a6a8-c643856c57e3@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <0dfb09ca-8723-3a3c-a6a8-c643856c57e3@suse.de> Sender: stable-owner@vger.kernel.org To: Hannes Reinecke Cc: Sreekanth Reddy , linux-scsi , Sathya Prakash , Suganath Prabu Subramani , stable@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On Tue, Feb 26, 2019 at 02:49:30PM +0100, Hannes Reinecke wrote: > Attached is a patch to demonstrate my approach. > I am aware that it'll only be useful for latest upstream where the legacy > I/O path has been dropped completely, so we wouldn't need to worry about it. > For older releases indeed you would need to with something like your > proposed patch, but for upstream I really would like to switch to > blk_mq_tagset_busy() iter. While this is better than the driver private tracking we really should not have to iterate all outstanding command, because if we have any there is a bug we need to fix in the higher layers instead of working around it in the drivers.