From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 3/3] drm/i915/icl: decouple dpll ids from
 type
Date: Tue, 26 Feb 2019 16:48:23 +0200
Message-ID: <20190226144823.GV20097@intel.com>
References: <20190222232324.16405-1-lucas.demarchi@intel.com>
 <20190222232324.16405-3-lucas.demarchi@intel.com>
 <20190225204534.GP20097@intel.com>
 <20190225212823.c7kinbsasku4pnmg@ldmartin-desk.jf.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 3CA4C89DA6
 for <intel-gfx@lists.freedesktop.org>; Tue, 26 Feb 2019 14:48:27 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190225212823.c7kinbsasku4pnmg@ldmartin-desk.jf.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCBGZWIgMjUsIDIwMTkgYXQgMDE6Mjg6MjNQTSAtMDgwMCwgTHVjYXMgRGUgTWFyY2hp
IHdyb3RlOgo+IE9uIE1vbiwgRmViIDI1LCAyMDE5IGF0IDEwOjQ1OjM0UE0gKzAyMDAsIFZpbGxl
IFN5cmrDpGzDpCB3cm90ZToKPiA+T24gRnJpLCBGZWIgMjIsIDIwMTkgYXQgMDM6MjM6MjRQTSAt
MDgwMCwgTHVjYXMgRGUgTWFyY2hpIHdyb3RlOgo+ID4+IFVzZSB0aGUgZmlyc3QgMyBiaXRzIG9m
IGRwbGxfaW5mby5wbGF0Zm9ybV9mbGFncyB0byBtYXJrIHRoZSB0eXBlIG9mIHRoZQo+ID4+IFBM
TCBpbnN0ZWFkIG9mIHJlbHlpbmcgb24gdGhlIElEcy4gVGhpcyBpcyBtb3JlIGZ1dHVyZSBwcm9v
ZiBmb3IKPiA+PiBhbGxvd2luZyB0aGUgc2FtZSBzZXQgb2YgZnVuY3Rpb25zIHRvIGJlIHJldXNl
ZCwgZXZlbiBpZiB0aGUgSURzIGNoYW5nZS4KPiA+Pgo+ID4+IFRoZSB3YXJuaW5nIGFib3V0IFBM
TCBpZCBub3QgY29ycmVzcG9uZGluZyB0byBhIGNvbWJvIHBoeSBpbiBpbnRlbF9kaXNwbGF5Cj4g
Pj4gd2FzIHJlbW92ZWQgYXMgSSBkb24ndCB0aGluayBpdCBzaG91bGQgZXZlciB0cmlnZ2VyLgo+
ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogTHVjYXMgRGUgTWFyY2hpIDxsdWNhcy5kZW1hcmNoaUBp
bnRlbC5jb20+Cj4gPj4gLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs
YXkuYyAgfCAgMyAtLQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5j
IHwgNTQgKysrKysrKysrKysrKysrKystLS0tLS0tLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2RwbGxfbWdyLmggfCAgMSAtCj4gPj4gIDMgZmlsZXMgY2hhbmdlZCwgMzUgaW5z
ZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pCj4gPj4KPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfZGlzcGxheS5jCj4gPj4gaW5kZXggYjFkNjNjMzJjYTk0Li5hMmJlMzUxMThkZDUgMTAwNjQ0
Cj4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPj4gKysr
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPj4gQEAgLTk1OTIsOSAr
OTU5Miw2IEBAIHN0YXRpYyB2b2lkIGljZWxha2VfZ2V0X2RkaV9wbGwoc3RydWN0IGRybV9pOTE1
X3ByaXZhdGUgKmRldl9wcml2LAo+ID4+ICAJCXRlbXAgPSBJOTE1X1JFQUQoRFBDTEtBX0NGR0NS
MF9JQ0wpICYKPiA+PiAgCQkgICAgICAgRFBDTEtBX0NGR0NSMF9ERElfQ0xLX1NFTF9NQVNLKHBv
cnQpOwo+ID4+ICAJCWlkID0gdGVtcCA+PiBEUENMS0FfQ0ZHQ1IwX0RESV9DTEtfU0VMX1NISUZU
KHBvcnQpOwo+ID4+IC0KPiA+PiAtCQlpZiAoV0FSTl9PTighaW50ZWxfZHBsbF9pc19jb21ib3Bo
eShpZCkpKQo+ID4+IC0JCQlyZXR1cm47Cj4gPj4gIAl9IGVsc2UgaWYgKGludGVsX3BvcnRfaXNf
dGMoZGV2X3ByaXYsIHBvcnQpKSB7Cj4gPj4gIAkJaWQgPSBpY2xfdGNfcG9ydF90b19wbGxfaWQo
aW50ZWxfcG9ydF90b190YyhkZXZfcHJpdiwgcG9ydCkpOwo+ID4+ICAJfSBlbHNlIHsKPiA+PiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYyBiL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMKPiA+PiBpbmRleCBlNGVjNzNkNDE1ZDku
LmNkYjQ0NjNiYWI1ZCAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9kcGxsX21nci5jCj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9t
Z3IuYwo+ID4+IEBAIC0yNjM5LDYgKzI2MzksMTMgQEAgaW50IGljbF9jYWxjX2RwX2NvbWJvX3Bs
bF9saW5rKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+PiAgCXJldHVybiBs
aW5rX2Nsb2NrOwo+ID4+ICB9Cj4gPj4KPiA+PiArZW51bSBpY2xfZHBsbF9mbGFncyB7Cj4gPj4g
KwlJQ0xfRFBMTF9UWVBFX0NPTUJPUEhZLAo+ID4+ICsJSUNMX0RQTExfVFlQRV9UQlQsCj4gPj4g
KwlJQ0xfRFBMTF9UWVBFX01HLAo+ID4+ICsJX0lDTF9EUExMX1RZUEVfTUFTSyA9IDB4NywKPiA+
PiArfTsKPiA+PiArCj4gPj4gIHN0YXRpYyBlbnVtIHRjX3BvcnQgaWNsX3BsbF9pZF90b190Y19w
b3J0KGVudW0gaW50ZWxfZHBsbF9pZCBpZCkKPiA+PiAgewo+ID4+ICAJcmV0dXJuIGlkIC0gRFBM
TF9JRF9JQ0xfTUdQTEwxOwo+ID4+IEBAIC0yNjQ5LDkgKzI2NTYsOSBAQCBlbnVtIGludGVsX2Rw
bGxfaWQgaWNsX3RjX3BvcnRfdG9fcGxsX2lkKGVudW0gdGNfcG9ydCB0Y19wb3J0KQo+ID4+ICAJ
cmV0dXJuIHRjX3BvcnQgKyBEUExMX0lEX0lDTF9NR1BMTDE7Cj4gPj4gIH0KPiA+Pgo+ID4+IC1i
b29sIGludGVsX2RwbGxfaXNfY29tYm9waHkoZW51bSBpbnRlbF9kcGxsX2lkIGlkKQo+ID4+ICtz
dGF0aWMgZW51bSBpY2xfZHBsbF9mbGFncyBpY2xfZHBsbF90eXBlKGNvbnN0IHN0cnVjdCBkcGxs
X2luZm8gKmluZm8pCj4gPj4gIHsKPiA+PiAtCXJldHVybiBpZCA9PSBEUExMX0lEX0lDTF9EUExM
MCB8fCBpZCA9PSBEUExMX0lEX0lDTF9EUExMMTsKPiA+PiArCXJldHVybiBpbmZvLT5wbGF0Zm9y
bV9mbGFncyAmIF9JQ0xfRFBMTF9UWVBFX01BU0s7Cj4gPj4gIH0KPiA+Pgo+ID4+ICBzdGF0aWMg
Ym9vbCBpY2xfbWdfcGxsX2ZpbmRfZGl2aXNvcnMoaW50IGNsb2NrX2toeiwgYm9vbCBpc19kcCwg
Ym9vbCB1c2Vfc3NjLAo+ID4+IEBAIC0yOTU2LDE0ICsyOTYzLDIyIEBAIGljbF9nZXRfZHBsbChz
dHJ1Y3QgaW50ZWxfY3J0YyAqY3J0Yywgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3Rh
dGUsCj4gPj4gIAlyZXR1cm4gcGxsOwo+ID4+ICB9Cj4gPj4KPiA+PiAtc3RhdGljIGk5MTVfcmVn
X3QgaWNsX3BsbF9pZF90b19lbmFibGVfcmVnKGVudW0gaW50ZWxfZHBsbF9pZCBpZCkKPiA+PiAr
c3RhdGljIGk5MTVfcmVnX3QKPiA+PiAraWNsX3BsbF9pbmZvX3RvX2VuYWJsZV9yZWcoY29uc3Qg
c3RydWN0IGRwbGxfaW5mbyAqaW5mbykKPiA+PiAgewo+ID4+IC0JaWYgKGludGVsX2RwbGxfaXNf
Y29tYm9waHkoaWQpKQo+ID4+IC0JCXJldHVybiBDTkxfRFBMTF9FTkFCTEUoaWQpOwo+ID4+IC0J
ZWxzZSBpZiAoaWQgPT0gRFBMTF9JRF9JQ0xfVEJUUExMKQo+ID4+IC0JCXJldHVybiBUQlRfUExM
X0VOQUJMRTsKPiA+PiArCWVudW0gaWNsX2RwbGxfZmxhZ3MgdHlwZSA9IGljbF9kcGxsX3R5cGUo
aW5mbyk7Cj4gPj4KPiA+PiAtCXJldHVybiBNR19QTExfRU5BQkxFKGljbF9wbGxfaWRfdG9fdGNf
cG9ydChpZCkpOwo+ID4+ICsJc3dpdGNoICh0eXBlKSB7Cj4gPj4gKwljYXNlIElDTF9EUExMX1RZ
UEVfQ09NQk9QSFk6Cj4gPj4gKwkJcmV0dXJuIENOTF9EUExMX0VOQUJMRShpbmZvLT5pZCk7Cj4g
Pj4gKwljYXNlIElDTF9EUExMX1RZUEVfVEJUOgo+ID4+ICsJCXJldHVybiBUQlRfUExMX0VOQUJM
RTsKPiA+PiArCWNhc2UgSUNMX0RQTExfVFlQRV9NRzoKPiA+PiArCQlyZXR1cm4gTUdfUExMX0VO
QUJMRShpY2xfcGxsX2lkX3RvX3RjX3BvcnQoaW5mby0+aWQpKTsKPiA+PiArCWRlZmF1bHQ6Cj4g
Pj4gKwkJTUlTU0lOR19DQVNFKHR5cGUpOwo+ID4+ICsJCXJldHVybiBDTkxfRFBMTF9FTkFCTEUo
aW5mby0+aWQpOwo+ID4+ICsJfQo+ID4+ICB9Cj4gPgo+ID5UaGlzIHNlZW1zIGEgcmF0aGVyIHJv
dW5kYWJvdXQgd2F5IG9mIGRvaW5nIHRoaW5ncyB3aGVuIHdlIGFscmVhZHkgaGF2ZQo+ID50aGUg
dmZ1bmNzLgo+ID4KPiA+SG93IGFib3V0IGp1c3Q6Cj4gPgo+ID5tZ19wbGxfZW5hYmxlKCkKPiA+
ewo+ID4JaWNsX3BsbF9lbmFibGUoTUdfUkVHKTsKPiA+fQo+ID4KPiA+Y29tYm9fcGxsX2VuYWJs
ZSgpCj4gPnsKPiA+CWljbF9wbGxfZW5hYmxlKENPTUJPX1JFRyk7Cj4gPn0KPiA+Cj4gPm9yIHNv
bWV0aGluZyBhbG9uZyB0aG9zZSBsaW5lcy4KPiAKPiBodW1uLi4uIEkgdGhvdWdodCBhYm91dCB0
aGlzIGFwcHJvYWNoIGFzIGFuIGludGVybWVkaWF0ZSBzdGVwIHRvIHRoZQo+IGZ1bGwgYmxvd24g
ImFkZCBhbm90aGVyIHZmdW5jIHN0cnVjdCBhbmQgcGFzcyB0aGF0IGluc3RlYWQiLiAgUGxhdGZv
cm1zCj4gYXJlIGZyZWUgdG8gdXNlIHRoaXMgZm9yIHNtYWxsIGRpZmZlcmVuY2VzIHRoYXQgZG9u
J3QganVzdGlmeSBnb2luZyB0aGF0Cj4gcm91dGUuCj4gCj4gSW4geW91ciBhcHByb2FjaCB5b3Ug
Z28gdGhlIHJvdXRlIG9mICJhbHdheXMgdXNlIHZmdW5jIGFuZCBhZGQKPiBhZGRpdGlvbmFsIGFy
Z3VtZW50cyB0byB0aGUgY29tbW9uIGZ1bmN0aW9uIi4KPiBDb21wYXJlZCB0byB0aGUgYXBwcm9h
Y2ggaGVyZSwgaXQncyBub3Qgc3ViamVjdGl2ZSBvbiB3aGF0IHRvIGRvIGluCj4gc2ltaWxhciBj
YXNlcywgYnV0IGhhcyBpdHMgZG93bnNpZGVzIGFzIHdlbGwuCj4gCj4gMSkgVGhlIGZ1bmN0aW9u
IGNhbid0IGJlIGlubGluZWQgc28gdGhlcmUncyBhbmQgZXh0cmEgaG9wIHdoZW4gY2FsbGluZwo+
IHRoZSB2ZnVuYwoKV2UgYWxyZWFkeSBoYXZlIHRoZSB2ZnVuYy4gQW5kIGV2ZW4gaWYgd2UgZGlk
bid0LCBhbiBleHRyYSB2ZnVuYyBpbgptb2Rlc2V0dGluZyBjb2RlIGlzIHByb2JhYmx5IGluIHRo
ZSBub2lzZS4KCj4gMikgaWYgdGhlIGNhbGxlZSBpcyBpbmxpbmVkIHdlIGJhc2ljYWxseSBkdXBs
aWNhdGUgLnRleHQsIGJ1dCBJIGRvdWJ0Cj4gYW55IGNvbXBpbGVyIHdvdWxkIGRvIHRoYXQKCkVp
dGhlciBpdCBpbmxpbmVzIG9yIG5vdC4gV2h5IHNob3VsZCB3ZSBjYXJlIGluIHRoaXMgcGFydGlj
dWxhciBjYXNlPwoKPiAzKSByZWcgYXMgdGhlIGFyZ3VtZW50IGlzIHByb2JhYmx5IG5vdCBhIGdv
b2QgY2hvaWNlIGFzIGl0IG1heSBjaGFuZ2UKPiBpbiB0aGUgbmV4dCBwbGF0Zm9ybSAtIHNvIHdl
IHdvdWxkIG5lZWQgdG8gYWRkIGEgInR5cGUiIG5vbmV0aGVsZXNzCgpOb3Qgc3VyZSB3aGF0IHlv
dSBtZWFuLiBJZiB0aGUgcmVnIGNoYW5nZXMgeW91IHBhc3MgaW4gYSBkaWZmZXJlbnQgcmVnLgpJ
ZiBvdGhlciB0aGluZ3MgZGlmZmVyIHNpZ25pZmljYW50bHkgeW91IHdyaXRlIGEgbmV3IGZ1bmN0
aW9uLgoKPiAKPiBTaW5jZSBmbGFncyBpcyBhbHJlYWR5IHRoZXJlCj4gYW5kIHVuZGVyLXV0aWxp
emVkIEkgZG9uJ3Qgc2VlIG11Y2gKPiBhZHZhbnRhZ2Ugb24gdGhlIHZmdW5jLW9ubHkgYXBwcm9h
Y2guIEknbSBub3Qgc3Ryb25nbHkgb3Bwb3NlZCB0aG91Z2g6Cj4gSU1PIGJvdGggYXJlIGJldHRl
ciB0aGFuIHRoZSBjdXJyZW50IHN0YXRlLgoKSWYgdGhlIGV4aXN0aW5nIG1lY2hhbmlzbSBpcyBz
dWZmaWNpZW50IHRvIHRoZSB0YXNrIHRoZW4gd2Ugc2hvdWxkCmdlbmVyYWxseSB1c2UgaXQgcmF0
aGVyIHRoYW4gYWRkaW5nIHlldCBhbm90aGVyIG1lY2hhbmlzbS4gVGhpcwprZWVwcyB0aGUgY29k
ZSBtb3JlIHVuaWZvcm0gYW5kIHRodXMgZWFzaWVyIGZvciBldmVyeW9uZSB0bwp1bmRlcnN0YW5k
LgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0
cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s
aXN0aW5mby9pbnRlbC1nZng=