From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() Date: Tue, 26 Feb 2019 16:21:44 +0100 Message-ID: <20190226152144.GA17948@kroah.com> References: <20190224153622.8877-1-digetx@gmail.com> <20190225080715.4965810a@dimatab> <20190226105615.GA12397@kroah.com> <20190226145857.GB26080@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Osipenko Cc: Joe Perches , Andy Whitcroft , Peter Chen , Thierry Reding , Jonathan Hunter , "linux-usb@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-tegra@vger.kernel.org On Tue, Feb 26, 2019 at 06:08:17PM +0300, Dmitry Osipenko wrote: > 26.02.2019 17:58, Greg Kroah-Hartman пишет: > > On Tue, Feb 26, 2019 at 05:33:05PM +0300, Dmitry Osipenko wrote: > >> 26.02.2019 13:56, Greg Kroah-Hartman пишет: > >>> On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote: > >>>> В Mon, 25 Feb 2019 02:27:19 +0000 > >>>> Peter Chen пишет: > >>>> > >>>>> > >>>>>> > >>>>>> Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for > >>>>>> Tegra20/30/114/124") > >>>>> > >>>>> I suppose you need to apply at stable tree too, right? > >>>>> > >>>> > >>>> It is enough to have the "Fixes" tag to get patch backported into all > >>>> relevant kernel versions. > >>> > >>> No it is not. My scripts do NOT trigger off of the fixes: tag, please > >>> read: > >>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > >>> for how to do this properly. > >> > >> Okay, my bad then. Maybe this is something that could warned by checkpatch.. adding Joe and Andy to the thread. > > > > Why? It's allowed to put fixes: tags for a patch that does not belong > > in a stable tree. That happens all the time, and is encouraged. Look > > at some of the stuff in linux-next now, we have Fixes: for commits that > > are still in linux-next as well, because we do not rebase our trees. > > When they all merge into Linus's tree, all is good. > > > > So this is not something that checkpatch needs to do anything about. > > At least that might help in cases like this if maintainer is also oblivious. If the maintainer is "oblivious", they are not going to be running checkpatch :) Remember, the "Fixes:" tag is a relatively new thing compared to the cc: stable tag, which has been a documented requirement for over a decade. Yes, some subsystems do not even do cc: stable, but that is because those subsystem maintainers do not want to do it, or do not care. Again, checkpatch is not going to help them. checkpatch is not a panacea, people still have to use their brains. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() From: Greg Kroah-Hartman Message-Id: <20190226152144.GA17948@kroah.com> Date: Tue, 26 Feb 2019 16:21:44 +0100 To: Dmitry Osipenko Cc: Joe Perches , Andy Whitcroft , Peter Chen , Thierry Reding , Jonathan Hunter , "linux-usb@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-ID: T24gVHVlLCBGZWIgMjYsIDIwMTkgYXQgMDY6MDg6MTdQTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+IDI2LjAyLjIwMTkgMTc6NTgsIEdyZWcgS3JvYWgtSGFydG1hbiDQv9C40YjQtdGC Ogo+ID4gT24gVHVlLCBGZWIgMjYsIDIwMTkgYXQgMDU6MzM6MDVQTSArMDMwMCwgRG1pdHJ5IE9z aXBlbmtvIHdyb3RlOgo+ID4+IDI2LjAyLjIwMTkgMTM6NTYsIEdyZWcgS3JvYWgtSGFydG1hbiDQ v9C40YjQtdGCOgo+ID4+PiBPbiBNb24sIEZlYiAyNSwgMjAxOSBhdCAwODowNzoxNUFNICswMzAw LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gPj4+PiDQkiBNb24sIDI1IEZlYiAyMDE5IDAyOjI3 OjE5ICswMDAwCj4gPj4+PiBQZXRlciBDaGVuIDxwZXRlci5jaGVuQG54cC5jb20+INC/0LjRiNC1 0YI6Cj4gPj4+Pgo+ID4+Pj4+ICAKPiA+Pj4+Pj4KPiA+Pj4+Pj4gRml4ZXM6IGRmZWJiNWY0M2E3 ODgyN2EgKCJ1c2I6IGNoaXBpZGVhOiBBZGQgc3VwcG9ydCBmb3IKPiA+Pj4+Pj4gVGVncmEyMC8z MC8xMTQvMTI0IikgIAo+ID4+Pj4+Cj4gPj4+Pj4gSSBzdXBwb3NlIHlvdSBuZWVkIHRvIGFwcGx5 IGF0IHN0YWJsZSB0cmVlIHRvbywgcmlnaHQ/Cj4gPj4+Pj4KPiA+Pj4+Cj4gPj4+PiBJdCBpcyBl bm91Z2ggdG8gaGF2ZSB0aGUgIkZpeGVzIiB0YWcgdG8gZ2V0IHBhdGNoIGJhY2twb3J0ZWQgaW50 byBhbGwKPiA+Pj4+IHJlbGV2YW50IGtlcm5lbCB2ZXJzaW9ucy4KPiA+Pj4KPiA+Pj4gTm8gaXQg aXMgbm90LiAgTXkgc2NyaXB0cyBkbyBOT1QgdHJpZ2dlciBvZmYgb2YgdGhlIGZpeGVzOiB0YWcs IHBsZWFzZQo+ID4+PiByZWFkOgo+ID4+PiAgICAgaHR0cHM6Ly93d3cua2VybmVsLm9yZy9kb2Mv aHRtbC9sYXRlc3QvcHJvY2Vzcy9zdGFibGUta2VybmVsLXJ1bGVzLmh0bWwKPiA+Pj4gZm9yIGhv dyB0byBkbyB0aGlzIHByb3Blcmx5Lgo+ID4+Cj4gPj4gT2theSwgbXkgYmFkIHRoZW4uIE1heWJl IHRoaXMgaXMgc29tZXRoaW5nIHRoYXQgY291bGQgd2FybmVkIGJ5IGNoZWNrcGF0Y2guLiBhZGRp bmcgSm9lIGFuZCBBbmR5IHRvIHRoZSB0aHJlYWQuCj4gPiAKPiA+IFdoeT8gIEl0J3MgYWxsb3dl ZCB0byBwdXQgZml4ZXM6IHRhZ3MgZm9yIGEgcGF0Y2ggdGhhdCBkb2VzIG5vdCBiZWxvbmcKPiA+ IGluIGEgc3RhYmxlIHRyZWUuICBUaGF0IGhhcHBlbnMgYWxsIHRoZSB0aW1lLCBhbmQgaXMgZW5j b3VyYWdlZC4gIExvb2sKPiA+IGF0IHNvbWUgb2YgdGhlIHN0dWZmIGluIGxpbnV4LW5leHQgbm93 LCB3ZSBoYXZlIEZpeGVzOiBmb3IgY29tbWl0cyB0aGF0Cj4gPiBhcmUgc3RpbGwgaW4gbGludXgt bmV4dCBhcyB3ZWxsLCBiZWNhdXNlIHdlIGRvIG5vdCByZWJhc2Ugb3VyIHRyZWVzLgo+ID4gV2hl biB0aGV5IGFsbCBtZXJnZSBpbnRvIExpbnVzJ3MgdHJlZSwgYWxsIGlzIGdvb2QuCj4gPiAKPiA+ IFNvIHRoaXMgaXMgbm90IHNvbWV0aGluZyB0aGF0IGNoZWNrcGF0Y2ggbmVlZHMgdG8gZG8gYW55 dGhpbmcgYWJvdXQuCj4gCj4gQXQgbGVhc3QgdGhhdCBtaWdodCBoZWxwIGluIGNhc2VzIGxpa2Ug dGhpcyBpZiBtYWludGFpbmVyIGlzIGFsc28gb2JsaXZpb3VzLgoKSWYgdGhlIG1haW50YWluZXIg aXMgIm9ibGl2aW91cyIsIHRoZXkgYXJlIG5vdCBnb2luZyB0byBiZSBydW5uaW5nCmNoZWNrcGF0 Y2ggOikKClJlbWVtYmVyLCB0aGUgIkZpeGVzOiIgdGFnIGlzIGEgcmVsYXRpdmVseSBuZXcgdGhp bmcgY29tcGFyZWQgdG8gdGhlIGNjOgpzdGFibGUgdGFnLCB3aGljaCBoYXMgYmVlbiBhIGRvY3Vt ZW50ZWQgcmVxdWlyZW1lbnQgZm9yIG92ZXIgYSBkZWNhZGUuClllcywgc29tZSBzdWJzeXN0ZW1z IGRvIG5vdCBldmVuIGRvIGNjOiBzdGFibGUsIGJ1dCB0aGF0IGlzIGJlY2F1c2UKdGhvc2Ugc3Vi c3lzdGVtIG1haW50YWluZXJzIGRvIG5vdCB3YW50IHRvIGRvIGl0LCBvciBkbyBub3QgY2FyZS4K QWdhaW4sIGNoZWNrcGF0Y2ggaXMgbm90IGdvaW5nIHRvIGhlbHAgdGhlbS4KCmNoZWNrcGF0Y2gg aXMgbm90IGEgcGFuYWNlYSwgcGVvcGxlIHN0aWxsIGhhdmUgdG8gdXNlIHRoZWlyIGJyYWlucy4K CmdyZWcgay1oCg==