From: Wolfram Sang <wsa@the-dreams.de>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Gareth Williams <gareth.williams.jx@renesas.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Phil Edworthy <phil.edworthy@renesas.com>,
devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Luis Oliveira <Luis.Oliveira@synopsys.com>
Subject: Re: [PATCH v4 1/2] dt: snps,designware-i2c: Add clock bindings documentation
Date: Tue, 26 Feb 2019 16:39:21 +0100 [thread overview]
Message-ID: <20190226153921.GC839@kunai> (raw)
In-Reply-To: <de2a72f3-6d2c-cc18-73f3-1e925bd5b88f@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
> > + - clock-names : Contains the names of the clocks:
> > + "ic_clk", for the core clock used to generate the external I2C clock.
> > + "pclk", the peripheral clock, required for register accesses.
> > +
>
> Actually it looks there is need to revert back to bus clock (or better) in
> comments but keep the "pclk" property.
>
> The specification I have tells the ic_clk is the peripheral clock which runs
> the logic and the pclk (exactly pclk) is for bus interface and where
> registers are.
Can we make it "bus interface clock" then? I'd think this is a tad
better.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-02-26 15:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 16:10 [PATCH v4 0/2] i2c: designware: Add support for a bus clock Gareth Williams
2019-02-21 16:10 ` [PATCH v4 1/2] dt: snps,designware-i2c: Add clock bindings documentation Gareth Williams
2019-02-22 15:06 ` Rob Herring
2019-02-26 14:54 ` Jarkko Nikula
2019-02-26 15:39 ` Wolfram Sang [this message]
2019-02-27 7:10 ` Jarkko Nikula
2019-02-27 9:43 ` Luis de Oliveira
2019-02-27 9:43 ` Luis de Oliveira
2019-02-26 18:39 ` Luis de Oliveira
2019-02-26 18:39 ` Luis de Oliveira
2019-02-21 16:10 ` [PATCH v4 2/2] i2c: designware: Add support for a peripheral clock Gareth Williams
2019-02-23 9:32 ` [PATCH v4 0/2] i2c: designware: Add support for a bus clock Wolfram Sang
2019-02-25 9:28 ` Gareth Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226153921.GC839@kunai \
--to=wsa@the-dreams.de \
--cc=Luis.Oliveira@synopsys.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=gareth.williams.jx@renesas.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=phil.edworthy@renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.