From: Tony Lindgren <tony@atomide.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@kernel.org>, Peter Geis <pgwipeout@gmail.com>,
Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: cpcap: Remove unused vsel_shift from struct cpcap_regulator
Date: Tue, 26 Feb 2019 07:51:11 -0800 [thread overview]
Message-ID: <20190226155111.GB39872@atomide.com> (raw)
In-Reply-To: <20190226055230.25482-1-axel.lin@ingics.com>
* Axel Lin <axel.lin@ingics.com> [190226 05:52]:
> This driver uses regulator_get/set_voltage_sel_regmap so it does not use
> vsel_shift. Actually, vsel_shift can be calculated by vsel_mask setting.
Thanks for doing this, still works for me:
Tested-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2019-02-26 15:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 5:52 [PATCH 1/2] regulator: cpcap: Remove unused vsel_shift from struct cpcap_regulator Axel Lin
2019-02-26 5:52 ` [PATCH 2/2] regulator: cpcap: Constify omap4_regulators and xoom_regulators Axel Lin
2019-02-26 15:51 ` Tony Lindgren
2019-02-26 16:07 ` Sebastian Reichel
2019-02-26 15:51 ` Tony Lindgren [this message]
2019-02-26 16:07 ` [PATCH 1/2] regulator: cpcap: Remove unused vsel_shift from struct cpcap_regulator Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226155111.GB39872@atomide.com \
--to=tony@atomide.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pgwipeout@gmail.com \
--cc=sebastian.reichel@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.