From: David Ahern <dsahern@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, David Ahern <dsahern@gmail.com>
Subject: [PATCH net 0/3] net: Fail route add with unsupported nexthop attribute
Date: Tue, 26 Feb 2019 09:00:01 -0800 [thread overview]
Message-ID: <20190226170004.4535-1-dsahern@kernel.org> (raw)
From: David Ahern <dsahern@gmail.com>
RTA_VIA was added for MPLS as a way of specifying a gateway from a
different address family. IPv4 and IPv6 do not currently support RTA_VIA
so using it leads to routes that are not what the user intended. Catch
and fail - returning a proper error message.
MPLS on the other hand does not support RTA_GATEWAY since it does not
make sense to have a nexthop from the MPLS address family. Similarly,
catch and fail - returning a proper error message.
David Ahern (3):
ipv4: Return error for RTA_VIA attribute
ipv6: Return error for RTA_VIA attribute
mpls: Return error for RTA_GATEWAY attribute
net/ipv4/fib_frontend.c | 4 ++++
net/ipv6/route.c | 4 ++++
net/mpls/af_mpls.c | 3 +++
3 files changed, 11 insertions(+)
--
2.11.0
next reply other threads:[~2019-02-26 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 17:00 David Ahern [this message]
2019-02-26 17:00 ` [PATCH net 1/3] ipv4: Return error for RTA_VIA attribute David Ahern
2019-02-26 17:00 ` [PATCH net 2/3] ipv6: " David Ahern
2019-02-26 17:00 ` [PATCH net 3/3] mpls: Return error for RTA_GATEWAY attribute David Ahern
2019-02-26 22:27 ` [PATCH net 0/3] net: Fail route add with unsupported nexthop attribute David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226170004.4535-1-dsahern@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.