All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, jasowang@redhat.com
Cc: quintela@redhat.com
Subject: [Qemu-devel] [PATCH v5 7/9] qmp: Add announce-self command
Date: Tue, 26 Feb 2019 19:59:57 +0000	[thread overview]
Message-ID: <20190226195959.28759-8-dgilbert@redhat.com> (raw)
In-Reply-To: <20190226195959.28759-1-dgilbert@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Add a qmp command that can trigger guest announcements.

It uses its own announce-timer instance, and parameters
passed to it explicitly in the command.

Like most qmp commands, it's in the main thread/bql, so
there's no racing with any outstanding timer.

Based on work of Germano Veit Michel <germano@redhat.com> and
                 Vladislav Yasevich <vyasevic@redhat.com>

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
---
 net/announce.c |  7 +++++++
 qapi/net.json  | 20 ++++++++++++++++++++
 2 files changed, 27 insertions(+)

diff --git a/net/announce.c b/net/announce.c
index 070f37a7fa..91e9a6e267 100644
--- a/net/announce.c
+++ b/net/announce.c
@@ -12,6 +12,7 @@
 #include "net/net.h"
 #include "qapi/clone-visitor.h"
 #include "qapi/qapi-visit-net.h"
+#include "qapi/qapi-commands-net.h"
 #include "trace.h"
 
 int64_t qemu_announce_timer_step(AnnounceTimer *timer)
@@ -131,3 +132,9 @@ void qemu_announce_self(AnnounceTimer *timer, AnnounceParameters *params)
         qemu_announce_timer_del(timer);
     }
 }
+
+void qmp_announce_self(AnnounceParameters *params, Error **errp)
+{
+    static AnnounceTimer announce_timer;
+    qemu_announce_self(&announce_timer, params);
+}
diff --git a/qapi/net.json b/qapi/net.json
index 5face0c14b..c093087278 100644
--- a/qapi/net.json
+++ b/qapi/net.json
@@ -707,3 +707,23 @@
             'max': 'int',
             'rounds': 'int',
             'step': 'int' } }
+
+##
+# @announce-self:
+#
+# Trigger generation of broadcast RARP frames to update network switches.
+# This can be useful when network bonds fail-over the active slave.
+#
+# @params: AnnounceParameters giving timing and repetition count of announce
+#
+# Example:
+#
+# -> { "execute": "announce-self"
+#      "arguments": { "params:" {
+#          "initial": 50, "max": 550, "rounds": 10, "step": 50 } } }
+# <- { "return": {} }
+#
+# Since: 4.0
+##
+{ 'command': 'announce-self',
+  'data' : {'params': 'AnnounceParameters'} }
-- 
2.20.1

  parent reply	other threads:[~2019-02-26 20:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-26 19:59 [Qemu-devel] [PATCH v5 0/9] Network announce changes Dr. David Alan Gilbert (git)
2019-02-26 19:59 ` [Qemu-devel] [PATCH v5 1/9] net: Introduce announce timer Dr. David Alan Gilbert (git)
2019-02-26 19:59 ` [Qemu-devel] [PATCH v5 2/9] migration: Add announce parameters Dr. David Alan Gilbert (git)
2019-02-26 19:59 ` [Qemu-devel] [PATCH v5 3/9] virtio-net: Switch to using announce timer Dr. David Alan Gilbert (git)
2019-02-26 19:59 ` [Qemu-devel] [PATCH v5 4/9] migration: " Dr. David Alan Gilbert (git)
2019-02-26 19:59 ` [Qemu-devel] [PATCH v5 5/9] net: Add a network device specific self-announcement ability Dr. David Alan Gilbert (git)
2019-02-26 19:59 ` [Qemu-devel] [PATCH v5 6/9] virtio-net: Allow qemu_announce_self to trigger virtio announcements Dr. David Alan Gilbert (git)
2019-02-26 19:59 ` Dr. David Alan Gilbert (git) [this message]
2019-02-26 20:36   ` [Qemu-devel] [PATCH v5 7/9] qmp: Add announce-self command Eric Blake
2019-02-27  6:53   ` Markus Armbruster
2019-02-27  9:59     ` Dr. David Alan Gilbert
2019-02-27 12:37       ` Markus Armbruster
2019-02-27 12:56         ` Dr. David Alan Gilbert
2019-02-26 19:59 ` [Qemu-devel] [PATCH v5 8/9] hmp: Add hmp_announce_self Dr. David Alan Gilbert (git)
2019-02-26 19:59 ` [Qemu-devel] [PATCH v5 9/9] tests: Add a test for qemu self announcements Dr. David Alan Gilbert (git)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190226195959.28759-8-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.