Re: [Outreachy kernel] [PATCH v3] Staging: vt6655: Alignment of static function declaration

[Madhumthia Prabakaran <madhumithabiw@gmail.com>]

On Wed, Feb 27, 2019 at 05:28:34PM +0100, Greg KH wrote:
> On Wed, Feb 27, 2019 at 10:01:48AM -0600, Madhumitha Prabakaran wrote:
> > Align function arguments and function return type to improve
> > readability.
> > 
> > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> > ---
> > Changes in v3
> > - Included driver name in subject line.
> > 
> > Changes in v2
> > - Improved alignment of function declaration
> > - Modified subject line and commit log
> > ---
> >  drivers/staging/vt6655/card.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> > index 229137f29690..8d0182f5725c 100644
> > --- a/drivers/staging/vt6655/card.c
> > +++ b/drivers/staging/vt6655/card.c
> > @@ -62,7 +62,7 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
> >  
> >  static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
> >  				       unsigned char *pbyTxRate,
> > -				       unsigned char *pbyRsvTime)
> > +				       unsigned char *pbyRsvTime);
> 
> The patch does not do what your changelog text says it is doing :(

I want to ensure whether you mean 'git diff' is not same as it is stated in commit log. I think, i didn't reset the commited patch and just edited the subject line. Please correct me, if I'm wrong