From: Patrick Steinhardt <ps@pks.im>
To: Steve Dickson <SteveD@RedHat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 3/3] svc_socket: fix use of undefined macro HAVE_GETRPCBYNUMBER_R
Date: Wed, 27 Feb 2019 18:37:36 +0100 [thread overview]
Message-ID: <20190227173736.GA1893@xps> (raw)
In-Reply-To: <b4f940b5-d073-7aff-7f20-0644a6e57be4@RedHat.com>
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
On Wed, Feb 27, 2019 at 12:16:18PM -0500, Steve Dickson wrote:
>
>
> On 2/4/19 9:31 AM, Patrick Steinhardt wrote:
> > The macro HAVE_GETRPCBYNUMBER_R is set based on whether the
> > `getrpcbynumber_r` function was found by autoconf or not. While another
> > location correctly checks whether it is set by using `#ifdef`,
> > `getservport()` instead wrongly uses `#if HAVE_GETRPCBYNUMBER_R`. This
> > may cause a compilation error with gcc with "-Werror=undef" if the macro
> > has not been defined.
> >
> > Fix the error by using `#ifdef` instead.
> >
> > Signed-off-by: Patrick Steinhardt <ps@pks.im>
> Committed...
>
> BTW... If the future, feel free to ping me it appears
> patches slide off my radar... like these did... ;-(
>
> steved.
Will do. I know from my own experience that it's hard to keep
track and be able to always respond in time :)
So thanks for your review and for committing them.
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-02-27 17:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 14:31 [PATCH 1/3] configure.ac: more carefully detect availability of res_querydomain(3) Patrick Steinhardt
2019-02-04 14:31 ` [PATCH 2/3] file: fix missing include for PATH_MAX constant Patrick Steinhardt
2019-02-27 17:14 ` Steve Dickson
2019-02-04 14:31 ` [PATCH 3/3] svc_socket: fix use of undefined macro HAVE_GETRPCBYNUMBER_R Patrick Steinhardt
2019-02-27 17:16 ` Steve Dickson
2019-02-27 17:37 ` Patrick Steinhardt [this message]
2019-02-22 7:52 ` [PATCH 1/3] configure.ac: more carefully detect availability of res_querydomain(3) Patrick Steinhardt
2019-02-22 20:40 ` J. Bruce Fields
2019-02-27 16:41 ` Steve Dickson
2019-02-27 17:14 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227173736.GA1893@xps \
--to=ps@pks.im \
--cc=SteveD@RedHat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.