From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 3/3] drm/i915/icl: decouple dpll ids from type Date: Wed, 27 Feb 2019 20:15:51 +0200 Message-ID: <20190227181551.GY20097@intel.com> References: <20190222232324.16405-1-lucas.demarchi@intel.com> <20190222232324.16405-3-lucas.demarchi@intel.com> <20190225204534.GP20097@intel.com> <20190225212823.c7kinbsasku4pnmg@ldmartin-desk.jf.intel.com> <20190226144823.GV20097@intel.com> <20190226190258.c6awuraryxdghpy2@ldmartin-desk.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id D57BE6E0F0 for ; Wed, 27 Feb 2019 18:15:55 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190226190258.c6awuraryxdghpy2@ldmartin-desk.jf.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBGZWIgMjYsIDIwMTkgYXQgMTE6MDI6NThBTSAtMDgwMCwgTHVjYXMgRGUgTWFyY2hp IHdyb3RlOgo+IE9uIFR1ZSwgRmViIDI2LCAyMDE5IGF0IDA0OjQ4OjIzUE0gKzAyMDAsIFZpbGxl IFN5cmrDpGzDpCB3cm90ZToKPiA+PiA+VGhpcyBzZWVtcyBhIHJhdGhlciByb3VuZGFib3V0IHdh eSBvZiBkb2luZyB0aGluZ3Mgd2hlbiB3ZSBhbHJlYWR5IGhhdmUKPiA+PiA+dGhlIHZmdW5jcy4K PiA+PiA+Cj4gPj4gPkhvdyBhYm91dCBqdXN0Ogo+ID4+ID4KPiA+PiA+bWdfcGxsX2VuYWJsZSgp Cj4gPj4gPnsKPiA+PiA+CWljbF9wbGxfZW5hYmxlKE1HX1JFRyk7Cj4gPj4gPn0KPiA+PiA+Cj4g Pj4gPmNvbWJvX3BsbF9lbmFibGUoKQo+ID4+ID57Cj4gPj4gPglpY2xfcGxsX2VuYWJsZShDT01C T19SRUcpOwo+ID4+ID59Cj4gPj4gPgo+ID4+ID5vciBzb21ldGhpbmcgYWxvbmcgdGhvc2UgbGlu ZXMuCj4gPj4KPiA+PiBodW1uLi4uIEkgdGhvdWdodCBhYm91dCB0aGlzIGFwcHJvYWNoIGFzIGFu IGludGVybWVkaWF0ZSBzdGVwIHRvIHRoZQo+ID4+IGZ1bGwgYmxvd24gImFkZCBhbm90aGVyIHZm dW5jIHN0cnVjdCBhbmQgcGFzcyB0aGF0IGluc3RlYWQiLiAgUGxhdGZvcm1zCj4gPj4gYXJlIGZy ZWUgdG8gdXNlIHRoaXMgZm9yIHNtYWxsIGRpZmZlcmVuY2VzIHRoYXQgZG9uJ3QganVzdGlmeSBn b2luZyB0aGF0Cj4gPj4gcm91dGUuCj4gPj4KPiA+PiBJbiB5b3VyIGFwcHJvYWNoIHlvdSBnbyB0 aGUgcm91dGUgb2YgImFsd2F5cyB1c2UgdmZ1bmMgYW5kIGFkZAo+ID4+IGFkZGl0aW9uYWwgYXJn dW1lbnRzIHRvIHRoZSBjb21tb24gZnVuY3Rpb24iLgo+ID4+IENvbXBhcmVkIHRvIHRoZSBhcHBy b2FjaCBoZXJlLCBpdCdzIG5vdCBzdWJqZWN0aXZlIG9uIHdoYXQgdG8gZG8gaW4KPiA+PiBzaW1p bGFyIGNhc2VzLCBidXQgaGFzIGl0cyBkb3duc2lkZXMgYXMgd2VsbC4KPiA+Pgo+ID4+IDEpIFRo ZSBmdW5jdGlvbiBjYW4ndCBiZSBpbmxpbmVkIHNvIHRoZXJlJ3MgYW5kIGV4dHJhIGhvcCB3aGVu IGNhbGxpbmcKPiA+PiB0aGUgdmZ1bmMKPiA+Cj4gPldlIGFscmVhZHkgaGF2ZSB0aGUgdmZ1bmMu IEFuZCBldmVuIGlmIHdlIGRpZG4ndCwgYW4gZXh0cmEgdmZ1bmMgaW4KPiA+bW9kZXNldHRpbmcg Y29kZSBpcyBwcm9iYWJseSBpbiB0aGUgbm9pc2UuCj4gCj4gSSdtIHRhbGtpbmcgYWJvdXQgdGhl IGV4dHJhIGZ1bmN0aW9uIHlvdSBhZGRlZCBoZXJlLiBUaGUgdmZ1bmMgd2lsbCBjYWxsCj4gdGhp cywgd2hpY2ggdGhlbiBjYWxscyB0aGUgcmVhbCBjb21tb24gZnVuY3Rpb24uCj4gCj4gPj4gMikg aWYgdGhlIGNhbGxlZSBpcyBpbmxpbmVkIHdlIGJhc2ljYWxseSBkdXBsaWNhdGUgLnRleHQsIGJ1 dCBJIGRvdWJ0Cj4gPj4gYW55IGNvbXBpbGVyIHdvdWxkIGRvIHRoYXQKPiA+Cj4gPkVpdGhlciBp dCBpbmxpbmVzIG9yIG5vdC4gV2h5IHNob3VsZCB3ZSBjYXJlIGluIHRoaXMgcGFydGljdWxhciBj YXNlPwo+IAo+IEluIHRoaXMgY2FzZSBJJ20gcmVmZXJyaW5nIHRvIGljbF9wbGxfZW5hYmxlKCkg YmVpbmcgaW5saW5lZCBpbnNpZGUKPiBtZ19wbGxfZW5hYmxlKCkgYW5kIGNvbWJvX3BsbF9lbmFi bGUoKS4KPiAKPiBCdXQgbGV0J3MgbGVhdmUgYWxvbmUgdGhlIGlubGluZXMgYW5kIGV4dHJhIGZ1 bmN0aW9uIGNhbGxzIGFuZCB0YWxrCj4gYWJvdXQgdGhlIG9yZ2FuaXphdGlvbiBiZWxvdy4KPiAK PiA+PiAzKSByZWcgYXMgdGhlIGFyZ3VtZW50IGlzIHByb2JhYmx5IG5vdCBhIGdvb2QgY2hvaWNl IGFzIGl0IG1heSBjaGFuZ2UKPiA+PiBpbiB0aGUgbmV4dCBwbGF0Zm9ybSAtIHNvIHdlIHdvdWxk IG5lZWQgdG8gYWRkIGEgInR5cGUiIG5vbmV0aGVsZXNzCj4gPgo+ID5Ob3Qgc3VyZSB3aGF0IHlv dSBtZWFuLiBJZiB0aGUgcmVnIGNoYW5nZXMgeW91IHBhc3MgaW4gYSBkaWZmZXJlbnQgcmVnLgo+ ID5JZiBvdGhlciB0aGluZ3MgZGlmZmVyIHNpZ25pZmljYW50bHkgeW91IHdyaXRlIGEgbmV3IGZ1 bmN0aW9uLgo+IAo+IGJlY2F1c2UgaGVyZSB0aGUgZnVuY3Rpb24gY2FuIHNoYXJlIG1vcmUgd2hl biBJIGNvbnNpZGVyIHRoZSAqdHlwZSogb2YKPiB0aGUgcGxsLCBub3QgaWYgaXQncyByZWcgMHgx MCwgMHgzMCBvciAweDQwLgo+IAo+ID4+Cj4gPj4gU2luY2UgZmxhZ3MgaXMgYWxyZWFkeSB0aGVy ZQo+ID4+IGFuZCB1bmRlci11dGlsaXplZCBJIGRvbid0IHNlZSBtdWNoCj4gPj4gYWR2YW50YWdl IG9uIHRoZSB2ZnVuYy1vbmx5IGFwcHJvYWNoLiBJJ20gbm90IHN0cm9uZ2x5IG9wcG9zZWQgdGhv dWdoOgo+ID4+IElNTyBib3RoIGFyZSBiZXR0ZXIgdGhhbiB0aGUgY3VycmVudCBzdGF0ZS4KPiA+ Cj4gPklmIHRoZSBleGlzdGluZyBtZWNoYW5pc20gaXMgc3VmZmljaWVudCB0byB0aGUgdGFzayB0 aGVuIHdlIHNob3VsZAo+ID5nZW5lcmFsbHkgdXNlIGl0IHJhdGhlciB0aGFuIGFkZGluZyB5ZXQg YW5vdGhlciBtZWNoYW5pc20uIFRoaXMKPiA+a2VlcHMgdGhlIGNvZGUgbW9yZSB1bmlmb3JtIGFu ZCB0aHVzIGVhc2llciBmb3IgZXZlcnlvbmUgdG8KPiA+dW5kZXJzdGFuZC4KPiAKPiAKPiBib3Ro IG9mIHRoZW0gYWxyZWFkeSBleGlzdCAtIGZsYWdzIGlzIGFscmVhZHkgdGhlcmUuIElmIEkgaGFu ZGxlIHRoZQo+ICp0eXBlcyogZGlmZmVyZW50bHkgd2l0aCB5b3VyIGFwcHJvYWNoIEkgd291bGQg YmFzaWNhbGx5IGhhdmU6Cj4gCj4gICAgIGVudW0gcGxsX3R5cGUgewo+ICAgICAgICAgQSwKPiAg ICAgICAgIEIsCj4gICAgICAgICBDLAo+ICAgICB9Cj4gCj4gICAgIHBsbF9lbmFibGUoKQo+ICAg ICB7Cj4gICAgICAgICAuLi4KPiAKPiAgICAgICAgIGlmICh0eXBlID09IEEpCj4gICAgICAgICBl bHNlIGlmICh0eXBlID09IEIpCj4gICAgICAgICBlbHNlCgpUaGlzIHRoaW5nIHNob3VsZG4ndCBo YXZlIGFueSBpZnMgaW4gaXQgaWYgdGhpcyBpcyBkb25lIHJpZ2h0LgoKVGhlIG1vcmUgaWZzIHlv dSBoYXZlIHRoZSBoYXJkZXIgaXQgaXMgdG8gZm9sbG93IHRoZSBjb2RlLgpJZGVhbGx5IHdlJ2Qg aGF2ZSBub25lLgoKPiAKPiAgICAgICAgIC4uLgo+ICAgICB9Cj4gCj4gICAgIGFfcGxsX2VuYWJs ZSgpCj4gICAgIHsKPiAgICAgICAgIHJldHVybiBwbGxfZW5hYmxlKEEpOwo+ICAgICB9Cj4gCj4g ICAgIGJfcGxsX2VuYWJsZSgpCj4gICAgIHsKPiAgICAgICAgIHJldHVybiBwbGxfZW5hYmxlKEIp Owo+ICAgICB9Cj4gCj4gICAgIGNfcGxsX2VuYWJsZSgpCj4gICAgIHsKPiAgICAgICAgIHJldHVy biBwbGxfZW5hYmxlKEMpOwo+ICAgICB9Cj4gCj4gICAgIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZnVu Y3MgYV9mdW5jcyA9IHsKPiAgICAgICAgIC5lbmFibGUgPSBhX3BsbF9lbmFibGUoKSwKPiAgICAg fTsKPiAgICAgc3RhdGljIGNvbnN0IHN0cnVjdCBmdW5jcyBiX2Z1bmNzID0gewo+ICAgICAgICAg LmVhbmJsZSA9IGJfcGxsX2VuYWJsZSgpLAo+ICAgICB9Owo+ICAgICBzdGF0aWMgY29uc3Qgc3Ry dWN0IGZ1bmNzIGNfZnVuY3MgPSB7Cj4gICAgICAgICAuZW5hYmxlID0gY19wbGxfZW5hYmxlKCks Cj4gICAgIH07Cj4gCj4gICAgIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcGxsc1tdID0gewo+ICAgICAg ICAgeyBhX2Z1bmNzLCAuLi4gfSwKPiAgICAgICAgIHsgYl9mdW5jcywgLi4uIH0sCj4gICAgICAg ICB7IGNfZnVuY3MsIC4uLiB9LAo+ICAgICB9Owo+IAo+IAo+IFRoaXMgYXBwcm9hY2ggaGFzIGl0 cyB2YWx1ZSB3aGVuIHRoZSBpbXBsZW1lbnRhdGlvbnMgYXJlIGNvbXBsZXRlbHkKPiBkaWZmZXJl bnQgLSBlLmcuIHRoZSBtZyB2cyBjb21ibyBhcHByb2FjaCBpbiBwYXRjaCAxLiBXaGVuIHRoZQo+ IGltcGxlbWVudGF0aW9uIGlzIHZlcnkgc2ltaWxhciwgd2hhdCBJJ20gcHJvcG9zaW5nIGlzIHRv IGJlIGFibGUgdG8gZG86Cj4gCj4gICAgIGVudW0gcGxsX3R5cGUgewo+ICAgICAgICAgQSwKPiAg ICAgICAgIEIsCj4gICAgICAgICBDLAo+ICAgICB9Cj4gCj4gICAgIHBsbF9lbmFibGUoKQo+ICAg ICB7Cj4gICAgICAgICAuLi4KPiAKPiAgICAgICAgIGlmICh0eXBlID09IEEpCj4gICAgICAgICBl bHNlIGlmICh0eXBlID09IEIpCj4gICAgICAgICBlbHNlCj4gCj4gICAgICAgICAuLi4KPiAgICAg fQo+IAo+ICAgICBzdGF0aWMgY29uc3Qgc3RydWN0IGZ1bmNzIGZ1bmNzID0gewo+ICAgICAgICAg LmVuYWJsZSA9IHBsbF9lbmFibGUoKSwKPiAgICAgfTsKPiAgCj4gICAgIHN0YXRpYyBjb25zdCBz dHJ1Y3QgcGxsc1tdID0gewo+ICAgICAgICAgeyBmdW5jcywgQSwgLi4uIH0KPiAgICAgICAgIHsg ZnVuY3MsIEIsIC4uLiB9Cj4gICAgICAgICB7IGZ1bmNzLCBDLCAuLi4gfQo+ICAgICB9Cj4gCj4g V2UgaGF2ZSBsZXNzIGJvaWxlcnBsYXRlIGNvZGUgYW5kIHRoZSBpbmZvcm1hdGlvbiBpcyBpbiB0 aGUgdGFibGUgcmF0aGVyCj4gdGhhbiBzcHJlYWQgYWNyb3NzIG11bHRpcGxlIGZ1bmN0aW9ucy4g RG9uJ3QgZ2V0IG1lIHdyb25nLCB0aGUgb3RoZXIKPiBhcHByb2FjaCBoYXMgaXRzIHBsYWNlIGFu ZCBpcyBldmVuIHVzZWQgaW4gcGF0Y2ggMSBiZWNhdXNlIHRoZSBpbXBsCj4gaXMgdG90YWxseSBk aWZmZXJlbnQuCj4gCj4gSW4gdGhlIElDTCBjYXNlLCB0aGUgdHlwZSBpbiB0aGUgdGFibGUgaXMg dXNlZCB0byB0d2VhayB0aGUgYmVoYXZpb3IgZm9yCj4gTUcgdnMgVEJULCBiZWNhdXNlIHRoZXkg cmV1c2UgbW9zdCBvZiB0aGUgc2FtZSBjYWxscy4gQ29tYm8gdnMgTUcgaXMKPiBoYW5kbGVkIGlu IHBhdGNoIDEsIG5vdCBoZXJlLgo+IAo+IEx1Y2FzIERlIE1hcmNoaQoKLS0gClZpbGxlIFN5cmrD pGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=