From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH] drm: prefix header search paths with $(srctree)/ Date: Wed, 27 Feb 2019 21:05:24 +0100 Message-ID: <20190227200524.GA26912@ravnborg.org> References: <1548906999-22143-1-git-send-email-yamada.masahiro@socionext.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1548906999-22143-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Masahiro Yamada Cc: freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, David Airlie , nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Rodrigo Vivi , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Daniel Vetter , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alex Deucher , intel-gvt-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Christian =?iso-8859-1?Q?K=F6nig?= , Zhi Wang , Ben Skeggs List-Id: amd-gfx.lists.freedesktop.org SGkgTWFzYWhpcm8uCgpPbiBUaHUsIEphbiAzMSwgMjAxOSBhdCAxMjo1NjozOVBNICswOTAwLCBN YXNhaGlybyBZYW1hZGEgd3JvdGU6Cj4gQ3VycmVudGx5LCB0aGUgS2J1aWxkIGNvcmUgbWFuaXB1 bGF0ZXMgaGVhZGVyIHNlYXJjaCBwYXRocyBpbiBhIGNyYXp5Cj4gd2F5IFsxXS4KPiAKPiBUbyBm aXggdGhpcyBtZXNzLCBJIHdhbnQgYWxsIE1ha2VmaWxlcyB0byBhZGQgZXhwbGljaXQgJChzcmN0 cmVlKS8gdG8KPiB0aGUgc2VhcmNoIHBhdGhzIGluIHRoZSBzcmN0cmVlLiBTb21lIE1ha2VmaWxl cyBhcmUgYWxyZWFkeSB3cml0dGVuIGluCj4gdGhhdCB3YXksIGJ1dCBub3QgYWxsLiBUaGUgZ29h bCBvZiB0aGlzIHdvcmsgaXMgdG8gbWFrZSB0aGUgbm90YXRpb24KPiBjb25zaXN0ZW50LCBhbmQg ZmluYWxseSBnZXQgcmlkIG9mIHRoZSBncm9zcyBoYWNrcy4KPiAKPiBIYXZpbmcgd2hpdGVzcGFj ZXMgYWZ0ZXIgLUkgZG9lcyBub3QgbWF0dGVyIHNpbmNlIGNvbW1pdCA0OGY2ZTNjZjViYzYKPiAo ImtidWlsZDogZG8gbm90IGRyb3AgLUkgd2l0aG91dCBwYXJhbWV0ZXIiKS4KPiAKPiBbMV06IGh0 dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvOTYzMjM0Ny8KPiAKPiBTaWduZWQtb2Zm LWJ5OiBNYXNhaGlybyBZYW1hZGEgPHlhbWFkYS5tYXNhaGlyb0Bzb2Npb25leHQuY29tPgoKUGF0 Y2ggbG9va3MgZ29vZDoKUmV2aWV3ZWQtYnk6IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9y Zz4KCj4gLS0tCj4gCj4gSSBwdXQgYWxsIGdwdS9kcm0gY2hhbmdlcyBpbnRvIGEgc2luZ2xlIHBh dGNoIGJlY2F1c2UKPiB0aGV5IGFyZSB0cml2aWFsIGNvbnZlcnNpb24uCj4KPiBQbGVhc2UgbGV0 IG1lIGtub3cgaWYgSSBuZWVkIHRvIHNwbGl0IHRoaXMgaW50byBwZXItZHJpdmVyIHBhdGNoZXMu CkFncmVlIHRoYXQgaXQgaXMgZ29vZCB0byBoYXZlIHRob3NlIHJlbGF0ZWQgY2huZ2VzIHRvZ2V0 aGVyIGluIG9uZSBwYXRjaC4KCkkgc3RpbGwgbmVlZCB0byBsb29rIGludG8gZ2V0dGluZyBjb21t aXQtcmlnaHRzLgpEYW5pZWwgLSBjYW4geW91IHRha2UgdGhpcyB0byBkcm0tbWlzYz8KCglTYW0K X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KRnJlZWRyZW5v IG1haWxpbmcgbGlzdApGcmVlZHJlbm9AbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZnJlZWRyZW5v From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDF0AC43381 for ; Wed, 27 Feb 2019 20:05:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADBB521850 for ; Wed, 27 Feb 2019 20:05:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730285AbfB0UFe (ORCPT ); Wed, 27 Feb 2019 15:05:34 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:56427 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726594AbfB0UFd (ORCPT ); Wed, 27 Feb 2019 15:05:33 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 94088803F0; Wed, 27 Feb 2019 21:05:28 +0100 (CET) Date: Wed, 27 Feb 2019 21:05:24 +0100 From: Sam Ravnborg To: Masahiro Yamada , Daniel Vetter Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ben Skeggs , Rodrigo Vivi , Alex Deucher , freedreno@lists.freedesktop.org, Christian =?iso-8859-1?Q?K=F6nig?= , Zhi Wang Subject: Re: [PATCH] drm: prefix header search paths with $(srctree)/ Message-ID: <20190227200524.GA26912@ravnborg.org> References: <1548906999-22143-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548906999-22143-1-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=UpRNyd4B c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=VwQbUJbxAAAA:8 a=c-n4J4-pAAAA:8 a=7gkXJVJtAAAA:8 a=zdyCDPBueh_U94vGZl0A:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=L0NDqeB7ZLmQzAogN4cw:22 a=E9Po1WZjFZOl8hwRPBS3:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro. On Thu, Jan 31, 2019 at 12:56:39PM +0900, Masahiro Yamada wrote: > Currently, the Kbuild core manipulates header search paths in a crazy > way [1]. > > To fix this mess, I want all Makefiles to add explicit $(srctree)/ to > the search paths in the srctree. Some Makefiles are already written in > that way, but not all. The goal of this work is to make the notation > consistent, and finally get rid of the gross hacks. > > Having whitespaces after -I does not matter since commit 48f6e3cf5bc6 > ("kbuild: do not drop -I without parameter"). > > [1]: https://patchwork.kernel.org/patch/9632347/ > > Signed-off-by: Masahiro Yamada Patch looks good: Reviewed-by: Sam Ravnborg > --- > > I put all gpu/drm changes into a single patch because > they are trivial conversion. > > Please let me know if I need to split this into per-driver patches. Agree that it is good to have those related chnges together in one patch. I still need to look into getting commit-rights. Daniel - can you take this to drm-misc? Sam