diff for duplicates of <20190228085058.GA5694@archlinux-ryzen> diff --git a/a/1.txt b/N1/1.txt index 6a052cf..3a3d95a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -16,7 +16,7 @@ drivers/mtd/ubi/wl.c:1514:6: warning: variable 'err' is used uninitialized whene if (!force) { ^~~~~~ drivers/mtd/ubi/wl.c:1520:6: note: uninitialized use occurs here - if (err = UBI_IO_BITFLIPS || force) { + if (err == UBI_IO_BITFLIPS || force) { ^~~ drivers/mtd/ubi/wl.c:1514:2: note: remove the 'if' if its condition is always true if (!force) { @@ -39,8 +39,8 @@ drivers/mtd/ubi/wl.c:1478:9: note: initialize the variable 'err' to silence this > > mutex_unlock(&ubi->buf_mutex); > > } > > -> > - if (err = UBI_IO_BITFLIPS || force) { -> > + if (force || err = UBI_IO_BITFLIPS) { +> > - if (err == UBI_IO_BITFLIPS || force) { +> > + if (force || err == UBI_IO_BITFLIPS) { > > /* > > * Okay, bit flip happened, let's figure out what we can do. > > */ @@ -61,3 +61,7 @@ https://lore.kernel.org/lkml/20190221222123.GC6474@magnolia/ Thanks, Nathan + +______________________________________________________ +Linux MTD discussion mailing list +http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/a/content_digest b/N1/content_digest index 3e75ead..b90d1b5 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\08490920.CCJDc82j5X@blindfold\0" "From\0Nathan Chancellor <natechancellor@gmail.com>\0" "Subject\0Re: [PATCH] ubi: wl: Silence uninitialized variable warning\0" - "Date\0Thu, 28 Feb 2019 08:50:58 +0000\0" + "Date\0Thu, 28 Feb 2019 01:50:58 -0700\0" "To\0Richard Weinberger <richard@nod.at>\0" "Cc\0Boris Brezillon <bbrezillon@kernel.org>" Artem Bityutskiy <dedekind1@gmail.com> @@ -32,7 +32,7 @@ " if (!force) {\n" " ^~~~~~\n" "drivers/mtd/ubi/wl.c:1520:6: note: uninitialized use occurs here\n" - " if (err = UBI_IO_BITFLIPS || force) {\n" + " if (err == UBI_IO_BITFLIPS || force) {\n" " ^~~\n" "drivers/mtd/ubi/wl.c:1514:2: note: remove the 'if' if its condition is always true\n" " if (!force) {\n" @@ -55,8 +55,8 @@ "> > \t\tmutex_unlock(&ubi->buf_mutex);\n" "> > \t}\n" "> > \n" - "> > -\tif (err = UBI_IO_BITFLIPS || force) {\n" - "> > +\tif (force || err = UBI_IO_BITFLIPS) {\n" + "> > -\tif (err == UBI_IO_BITFLIPS || force) {\n" + "> > +\tif (force || err == UBI_IO_BITFLIPS) {\n" "> > \t\t/*\n" "> > \t\t * Okay, bit flip happened, let's figure out what we can do.\n" "> > \t\t */\n" @@ -76,6 +76,10 @@ "> \n" "\n" "Thanks,\n" - Nathan + "Nathan\n" + "\n" + "______________________________________________________\n" + "Linux MTD discussion mailing list\n" + http://lists.infradead.org/mailman/listinfo/linux-mtd/ -8937456570361d92261566525c91fcf8174e9cfcfe0f9199004cb6b372501ee6 +6544e809417ca8e888ac7e005328876818c112b63cd858a15d4671f098e660a7
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.