From mboxrd@z Thu Jan 1 00:00:00 1970 From: dan.carpenter at oracle.com (Dan Carpenter) Date: Thu, 28 Feb 2019 16:54:03 +0300 Subject: [RFC v4 08/17] kunit: test: add support for test abort In-Reply-To: References: <20190214213729.21702-1-brendanhiggins@google.com> <20190214213729.21702-9-brendanhiggins@google.com> <155121334527.260864.5324117081460979741@swboyd.mtv.corp.google.com> Message-ID: <20190228135403.GD9806@kadam> On Thu, Feb 28, 2019 at 01:03:24AM -0800, Brendan Higgins wrote: > you could do: > > if (IS_ERR_OR_NULL(ptr)) { > KUNIT_FAIL(test, "ptr is an errno or null: %ld", ptr); > return; > } It's best to not mix error pointers and NULL but when we do mix them, it means that NULL is a special kind of success. Like we try to load a feature and we get back: valid pointer <-- success null <-- feature is disabled. not an error. error pointer <-- feature is broken. fail. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: dan.carpenter@oracle.com (Dan Carpenter) Date: Thu, 28 Feb 2019 16:54:03 +0300 Subject: [RFC v4 08/17] kunit: test: add support for test abort In-Reply-To: References: <20190214213729.21702-1-brendanhiggins@google.com> <20190214213729.21702-9-brendanhiggins@google.com> <155121334527.260864.5324117081460979741@swboyd.mtv.corp.google.com> Message-ID: <20190228135403.GD9806@kadam> Content-Type: text/plain; charset="UTF-8" Message-ID: <20190228135403.SsJI4pFV4mYo4jfBl1a58O25OgW8tdfVMeREhZ0Ed6w@z> On Thu, Feb 28, 2019@01:03:24AM -0800, Brendan Higgins wrote: > you could do: > > if (IS_ERR_OR_NULL(ptr)) { > KUNIT_FAIL(test, "ptr is an errno or null: %ld", ptr); > return; > } It's best to not mix error pointers and NULL but when we do mix them, it means that NULL is a special kind of success. Like we try to load a feature and we get back: valid pointer <-- success null <-- feature is disabled. not an error. error pointer <-- feature is broken. fail. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [RFC v4 08/17] kunit: test: add support for test abort Date: Thu, 28 Feb 2019 16:54:03 +0300 Message-ID: <20190228135403.GD9806@kadam> References: <20190214213729.21702-1-brendanhiggins@google.com> <20190214213729.21702-9-brendanhiggins@google.com> <155121334527.260864.5324117081460979741@swboyd.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Brendan Higgins Cc: brakmo@fb.com, Petr Mladek , Amir Goldstein , dri-devel , Sasha Levin , linux-kselftest@vger.kernel.org, shuah@kernel.org, Frank Rowand , linux-nvdimm , Richard Weinberger , Knut Omang , Kieran Bingham , wfg@linux.intel.com, Joel Stanley , "Bird, Timothy" , devicetree , Jeff Dike , Kees Cook , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , Dan Williams , kunit-dev@googlegroups.com, Stephen Boyd , Greg KH , Linux List-Id: linux-nvdimm@lists.01.org T24gVGh1LCBGZWIgMjgsIDIwMTkgYXQgMDE6MDM6MjRBTSAtMDgwMCwgQnJlbmRhbiBIaWdnaW5z IHdyb3RlOgo+IHlvdSBjb3VsZCBkbzoKPiAKPiBpZiAoSVNfRVJSX09SX05VTEwocHRyKSkgewo+ ICAgICAgICAgS1VOSVRfRkFJTCh0ZXN0LCAicHRyIGlzIGFuIGVycm5vIG9yIG51bGw6ICVsZCIs IHB0cik7Cj4gICAgICAgICByZXR1cm47Cj4gfQoKSXQncyBiZXN0IHRvIG5vdCBtaXggZXJyb3Ig cG9pbnRlcnMgYW5kIE5VTEwgYnV0IHdoZW4gd2UgZG8gbWl4IHRoZW0sCml0IG1lYW5zIHRoYXQg TlVMTCBpcyBhIHNwZWNpYWwga2luZCBvZiBzdWNjZXNzLiAgTGlrZSB3ZSB0cnkgdG8gbG9hZAph IGZlYXR1cmUgYW5kIHdlIGdldCBiYWNrOgoKICAgIHZhbGlkIHBvaW50ZXIgPC0tIHN1Y2Nlc3MK ICAgIG51bGwgICAgICAgICAgPC0tIGZlYXR1cmUgaXMgZGlzYWJsZWQuICBub3QgYW4gZXJyb3Iu CiAgICBlcnJvciBwb2ludGVyIDwtLSBmZWF0dXJlIGlzIGJyb2tlbi4gIGZhaWwuCgpyZWdhcmRz LApkYW4gY2FycGVudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2130.oracle.com ([141.146.126.79]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzM9q-0005gT-30 for linux-um@lists.infradead.org; Thu, 28 Feb 2019 13:55:31 +0000 Date: Thu, 28 Feb 2019 16:54:03 +0300 From: Dan Carpenter Subject: Re: [RFC v4 08/17] kunit: test: add support for test abort Message-ID: <20190228135403.GD9806@kadam> References: <20190214213729.21702-1-brendanhiggins@google.com> <20190214213729.21702-9-brendanhiggins@google.com> <155121334527.260864.5324117081460979741@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Brendan Higgins Cc: brakmo@fb.com, Petr Mladek , Amir Goldstein , dri-devel , Sasha Levin , linux-kselftest@vger.kernel.org, shuah@kernel.org, Rob Herring , Frank Rowand , linux-nvdimm , Richard Weinberger , Knut Omang , Kieran Bingham , wfg@linux.intel.com, Joel Stanley , "Bird, Timothy" , devicetree , Jeff Dike , Kees Cook , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , Dan Williams , kunit-dev@googlegroups.com, Stephen Boyd , Greg KH , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , Michael Ellerman , Joe Perches , Kevin Hilman On Thu, Feb 28, 2019 at 01:03:24AM -0800, Brendan Higgins wrote: > you could do: > > if (IS_ERR_OR_NULL(ptr)) { > KUNIT_FAIL(test, "ptr is an errno or null: %ld", ptr); > return; > } It's best to not mix error pointers and NULL but when we do mix them, it means that NULL is a special kind of success. Like we try to load a feature and we get back: valid pointer <-- success null <-- feature is disabled. not an error. error pointer <-- feature is broken. fail. regards, dan carpenter _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7F69C43381 for ; Thu, 28 Feb 2019 13:56:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94FA7214D8 for ; Thu, 28 Feb 2019 13:56:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="CdHdgI4X" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732098AbfB1N4P (ORCPT ); Thu, 28 Feb 2019 08:56:15 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:54236 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730385AbfB1N4N (ORCPT ); Thu, 28 Feb 2019 08:56:13 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1SDrkUx072980; Thu, 28 Feb 2019 13:54:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=AnSV16BWU6ZICyMuI2YDl0upxNWLL2KYJXjKVaKDYuk=; b=CdHdgI4XFAAmkFKHJEAxZ6YwzdSerPUhFayIy893RRVBJv9vVdd24gB1xWjw9j5fXAXH ZAZFYjwgNIusuMTq5QgUbMbQi9lwmcrlSG5lPuE5rM24Np4b9qyTLKTesQY24zXlT4Yk iKjHwdG8Vqfa3JArqgUX3v/Byu6hIfKLWSZkPAmxYvjC5WgBoNZaoz6bBtgYhkKcK1NM 1RoVkijZ8tdyUNcForUttJQOw8SbajQbf1dpGXWbd6gnhwynoFDZ8NbMZh0dFEy7ox1w SXO36q6z1YV99dx6s0A93mDkGm3o8NieYzirGwBMOYibvZcAffcCjaSsbh0hlLxR+kYZ pQ== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2130.oracle.com with ESMTP id 2qtupeh9h8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Feb 2019 13:54:28 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1SDsRon025517 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Feb 2019 13:54:27 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x1SDsLk6017266; Thu, 28 Feb 2019 13:54:21 GMT Received: from kadam (/197.157.0.25) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 28 Feb 2019 05:54:20 -0800 Date: Thu, 28 Feb 2019 16:54:03 +0300 From: Dan Carpenter To: Brendan Higgins Cc: Stephen Boyd , Frank Rowand , Kees Cook , Kieran Bingham , Luis Chamberlain , Rob Herring , shuah@kernel.org, Greg KH , Joel Stanley , Michael Ellerman , Joe Perches , brakmo@fb.com, Steven Rostedt , "Bird, Timothy" , Kevin Hilman , Julia Lawall , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Linux Kernel Mailing List , Jeff Dike , Richard Weinberger , linux-um@lists.infradead.org, Daniel Vetter , dri-devel , Dan Williams , linux-nvdimm , Knut Omang , devicetree , Petr Mladek , Sasha Levin , Amir Goldstein , wfg@linux.intel.com Subject: Re: [RFC v4 08/17] kunit: test: add support for test abort Message-ID: <20190228135403.GD9806@kadam> References: <20190214213729.21702-1-brendanhiggins@google.com> <20190214213729.21702-9-brendanhiggins@google.com> <155121334527.260864.5324117081460979741@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9180 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=676 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902280097 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 28, 2019 at 01:03:24AM -0800, Brendan Higgins wrote: > you could do: > > if (IS_ERR_OR_NULL(ptr)) { > KUNIT_FAIL(test, "ptr is an errno or null: %ld", ptr); > return; > } It's best to not mix error pointers and NULL but when we do mix them, it means that NULL is a special kind of success. Like we try to load a feature and we get back: valid pointer <-- success null <-- feature is disabled. not an error. error pointer <-- feature is broken. fail. regards, dan carpenter